Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review138633 --- Ship it! Master (e0d6485) is green with this patch.

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-20 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/ --- (Updated June 20, 2016, 9:47 a.m.) Review request for Aurora and Maxim

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review138293 --- Ship it! Master (e0d6485) is green with this patch.

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-17 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/ --- (Updated June 17, 2016, 12:46 p.m.) Review request for Aurora and Maxim

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-16 Thread Maxim Khutornenko
> On June 15, 2016, 5:41 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/migration/V006_PopulateTierField.java, > > lines 50-52 > > > > > > This should be unnecessary as zero

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-16 Thread Mehrdad Nurolahzade
> On June 15, 2016, 10:41 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/migration/V006_PopulateTierField.java, > > lines 50-52 > > > > > > This should be unnecessary as zero

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-16 Thread Maxim Khutornenko
> On June 15, 2016, 5:41 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/TierManager.java, lines 125-127 > > > > > > Reiterating my previous comment: can this (and other places checking

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-16 Thread Mehrdad Nurolahzade
> On June 15, 2016, 10:41 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/migration/V006_PopulateTierField.java, > > lines 50-52 > > > > > > This should be unnecessary as zero

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-15 Thread Mehrdad Nurolahzade
> On June 15, 2016, 10:41 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java, line 14 > > > > > > Not sure why this class has been moved but if you want to keep it >

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review137763 --- src/main/java/org/apache/aurora/scheduler/TierManager.java

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review137555 --- Ship it! Master (f9bbfb3) is green with this patch.

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-14 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review137553 --- @ReviewBot retry - Mehrdad Nurolahzade On June 14, 2016, 10:12

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review137548 --- Master (f9bbfb3) is red with this patch.

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-14 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/ --- (Updated June 14, 2016, 10:12 a.m.) Review request for Aurora and Maxim

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-14 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review137538 ---

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-14 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/ --- (Updated June 14, 2016, 9:46 a.m.) Review request for Aurora and Maxim

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review137037 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 249)

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review137041 --- Ship it! Master (f9bbfb3) is green with this patch.