Re: Review Request 49578: Close `PathChildrenCache` before its framework.

2016-07-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140618 --- Ship it! Trusting your analysis, the patch looks sane to me.

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

2016-07-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140594 --- Ship it! Master (1103571) is green with this patch.

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

2016-07-03 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140590 --- @ReviewBot retry - John Sirois On July 3, 2016, 5:02 p.m.,

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

2016-07-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140585 --- Master (1103571) is red with this patch.

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

2016-07-03 Thread John Sirois
> On July 3, 2016, 5:16 p.m., Aurora ReviewBot wrote: > > Master (1103571) is red with this patch. > > ./build-support/jenkins/build.sh > > > > 1015 tests completed, 31 failed, 2 skipped > > :test FAILED > > :jacocoTestReport > > Coverage report generated: > >

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

2016-07-03 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140583 --- @ReviewBot retry - John Sirois On July 3, 2016, 5:02 p.m.,

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

2016-07-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140581 --- Master (1103571) is red with this patch.

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

2016-07-03 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140578 --- NB: I included both Bill and Zameer on this review since they