Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review149286 --- Ship it! Master (496397a) is green with this patch.

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/ --- (Updated Sept. 16, 2016, 2:50 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review149216 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 15, 2016,

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

> On Sept. 15, 2016, 12:48 vorm., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 82 > > > > > > Did you try to rollback to pre 0.15

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review149115 --- Ship it! Master (783baae) is green with this patch.

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/ --- (Updated Sept. 15, 2016, 12:02 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

> On Sept. 14, 2016, 3:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 82 > > > > > > Did you try to rollback to pre 0.15

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

> On Sept. 14, 2016, 3:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 82 > > > > > > Did you try to rollback to pre 0.15

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

> On Sept. 14, 2016, 3:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 82 > > > > > > Did you try to rollback to pre 0.15

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/ --- (Updated Sept. 14, 2016, 5:33 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

> On Sept. 14, 2016, 3:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 82 > > > > > > Did you try to rollback to pre 0.15

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review148988 ---

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review148973 --- Ship it! Ship It! - Joshua Cohen On Sept. 14, 2016, 8:58

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review148972 --- Ship it! Master (5069f93) is green with this patch.

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review148971 --- Ship it! Thanks for the detailed testing! LGTM. It seems like

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/ --- (Updated Sept. 14, 2016, 1:58 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

> On Sept. 13, 2016, 5:11 p.m., Zameer Manji wrote: > > I support this change as a developer. > > > > As an operator I am scared. > > > > What happens to an existing cluster if we don't set `framework_name`? Will > > it register another frameowork_id? (bad) or will it fail to register? > >

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

> On Sept. 13, 2016, 5:11 p.m., Zameer Manji wrote: > > I support this change as a developer. > > > > As an operator I am scared. > > > > What happens to an existing cluster if we don't set `framework_name`? Will > > it register another frameowork_id? (bad) or will it fail to register? > >

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review148866 --- Ship it! I have done the switch on a small test cluster and it

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

> On Sept. 13, 2016, 5:11 p.m., Zameer Manji wrote: > > I support this change as a developer. > > > > As an operator I am scared. > > > > What happens to an existing cluster if we don't set `framework_name`? Will > > it register another frameowork_id? (bad) or will it fail to register? > >

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review148819 --- Ship it! Master (5069f93) is green with this patch.

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

> On Sept. 13, 2016, 5:11 p.m., Zameer Manji wrote: > > I support this change as a developer. > > > > As an operator I am scared. > > > > What happens to an existing cluster if we don't set `framework_name`? Will > > it register another frameowork_id? (bad) or will it fail to register? > >

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/ --- (Updated Sept. 13, 2016, 5:18 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

> On Sept. 13, 2016, 5:12 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 83 > > > > > > I like the idea of making the framework name

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review148817 ---

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/ --- (Updated Sept. 13, 2016, 5:05 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review148813 --- This patch does not apply cleanly against master (5069f93), do

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/ --- (Updated Sept. 13, 2016, 5:01 p.m.) Review request for Aurora, Joshua Cohen