Re: Review Request 33411: Add typed Shiro permissions SPI.

> On April 22, 2015, 11:17 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/spi/Permissions.java, lines 90-94 > > > > > > You probably want Enums.getIfPresent() instead or may be even forgo

Re: Review Request 33411: Add typed Shiro permissions SPI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/#review81191 --- Ship it! src/main/java/org/apache/aurora/scheduler/spi/Permissions

Re: Review Request 33411: Add typed Shiro permissions SPI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/#review81174 --- Ship it! Ship It! - Joshua Cohen On April 21, 2015, 11 p.m., Kev

Re: Review Request 33411: Add typed Shiro permissions SPI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/#review81088 --- Ship it! Master (8ba1b11) is green with this patch. ./build-suppo

Re: Review Request 33411: Add typed Shiro permissions SPI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/ --- (Updated April 21, 2015, 4 p.m.) Review request for Aurora, Joshua Cohen and Bi

Re: Review Request 33411: Add typed Shiro permissions SPI.

> On April 21, 2015, 3:27 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, > > line 60 > > > > > > Is this used anywhere now? Nope, removed. > On Apri

Re: Review Request 33411: Add typed Shiro permissions SPI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/#review81082 --- Ship it! Master (d10d2d1) is green with this patch. ./build-suppo

Re: Review Request 33411: Add typed Shiro permissions SPI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/#review81076 --- src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecu

Review Request 33411: Add typed Shiro permissions SPI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora D