Re: Review Request 35813: Removing GC executor code.

2015-06-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/#review89380 --- Ship it! Master (d28bd4f) is green with this patch. ./build-suppo

Re: Review Request 35813: Removing GC executor code.

2015-06-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/ --- (Updated June 25, 2015, 4:59 p.m.) Review request for Aurora, Bill Farner and B

Re: Review Request 35813: Removing GC executor code.

2015-06-25 Thread Maxim Khutornenko
> On June 25, 2015, 4:34 p.m., Bill Farner wrote: > > 25 files changed, 2 insertions(+), 2054 deletions(-) > > > > Nice! 2 requests: > > > > - Can you confirm that end-to-end tests still pass? > > - Can you add to this patch a note in NEWS under 0.9.0 that the GC executor > > has been removed

Re: Review Request 35813: Removing GC executor code.

2015-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/#review89372 --- Ship it! 25 files changed, 2 insertions(+), 2054 deletions(-) Nice

Re: Review Request 35813: Removing GC executor code.

2015-06-24 Thread Kevin Sweeney
> On June 23, 2015, 5:31 p.m., Brian Wickman wrote: > > slightly overzealous deleting. the thermos gc stuff should still be part > > of the thermos toolchain. > > Maxim Khutornenko wrote: > Should not we rather rely on task reconciliation to do any cleanup > instead? Force GCing a task do

Re: Review Request 35813: Removing GC executor code.

2015-06-24 Thread Brian Wickman
> On June 24, 2015, 12:31 a.m., Brian Wickman wrote: > > slightly overzealous deleting. the thermos gc stuff should still be part > > of the thermos toolchain. > > Maxim Khutornenko wrote: > Should not we rather rely on task reconciliation to do any cleanup > instead? Force GCing a task d

Re: Review Request 35813: Removing GC executor code.

2015-06-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/#review89214 --- Ship it! Ship It! - Brian Wickman On June 24, 2015, 12:22 a.m.,

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Maxim Khutornenko
> On June 24, 2015, 12:31 a.m., Brian Wickman wrote: > > slightly overzealous deleting. the thermos gc stuff should still be part > > of the thermos toolchain. > > Maxim Khutornenko wrote: > Should not we rather rely on task reconciliation to do any cleanup > instead? Force GCing a task d

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Maxim Khutornenko
> On June 24, 2015, 12:31 a.m., Brian Wickman wrote: > > slightly overzealous deleting. the thermos gc stuff should still be part > > of the thermos toolchain. Should not we rather rely on task reconciliation to do any cleanup instead? Force GCing a task does not seem to be a critical feature

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/#review89108 --- Ship it! Master (4b8c34c) is green with this patch. ./build-suppo

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/#review89104 --- slightly overzealous deleting. the thermos gc stuff should still be

Review Request 35813: Removing GC executor code.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/ --- Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-1333