Re: Review Request 37719: Revocable: schema changes.

2015-08-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- (Updated Aug. 25, 2015, 10:28 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37719: Revocable: schema changes.

2015-08-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96438 --- Ship it! Ship It! - Bill Farner On Aug. 25, 2015, 3:28 p.m.,

Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1414

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Maxim Khutornenko
On Aug. 24, 2015, 8 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? There was a `production = True` kvarg added that required to reformat here. This is to enforce production

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Bill Farner
On Aug. 24, 2015, 8 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Maxim Khutornenko
On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 https://reviews.apache.org/r/37719/diff/1/?file=1048455#file1048455line255 Will this attribute be required in the future? Absolutely. Otherwise, how will users specify

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Maxim Khutornenko
On Aug. 24, 2015, 8 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Maxim Khutornenko
On Aug. 24, 2015, 8 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Zameer Manji
On Aug. 24, 2015, 1 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Zameer Manji
On Aug. 24, 2015, 1 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96199 --- Ship it! api/src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Bill Farner
On Aug. 24, 2015, 8 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Bill Farner
On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 https://reviews.apache.org/r/37719/diff/1/?file=1048455#file1048455line255 Will this attribute be required in the future? Maxim Khutornenko wrote: Absolutely.

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96229 --- src/main/java/org/apache/aurora/scheduler/TierManager.java (line

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Maxim Khutornenko
On Aug. 25, 2015, 12:12 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TierManager.java, line 39 https://reviews.apache.org/r/37719/diff/2/?file=1048730#file1048730line39 I suggest the 'prod' constant go in api.thrift. This will require deprecation cycle and

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- (Updated Aug. 25, 2015, 12:54 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96278 --- Ship it! Master (f202f2d) is green with this patch.

Re: Review Request 37719: Revocable: schema changes.

2015-08-24 Thread Maxim Khutornenko
On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 https://reviews.apache.org/r/37719/diff/1/?file=1048455#file1048455line255 Will this attribute be required in the future? Maxim Khutornenko wrote: Absolutely.