Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/ --- (Updated Sept. 9, 2015, 6:35 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review98238 --- Ship it! Master (4577de4) is green with this patch.

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review98053 --- Ship it! NEWS (line 16)

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review98023 --- Ship it! Master (2773826) is green with this patch.

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-08 Thread Maxim Khutornenko
> On Sept. 8, 2015, 3:55 p.m., Bill Farner wrote: > > Looks good! Holding back the ship until a `NEWS` entry is included in the > > patch. Thanks for reminding! Added. > On Sept. 8, 2015, 3:55 p.m., Bill Farner wrote: > >

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/ --- (Updated Sept. 7, 2015, 11:51 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-04 Thread Maxim Khutornenko
> On Sept. 3, 2015, 6:36 p.m., Zameer Manji wrote: > > I think there should be a `NEWS` file entry about this change and > > documentation updates. I'm comfortable with documentation changes being in > > another review but I think this commit should also update the `NEWS` file. Sure. > On

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Maxim Khutornenko
> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369 > > > > > > I think it will be better if we split this into > > nonProdSharedConsumption and

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review97664 --- Ship it! I think there should be a `NEWS` file entry about this

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Suman Karumuri
> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369 > > > > > > I think it will be better if we split this into > > nonProdSharedConsumption and

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Suman Karumuri
> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369 > > > > > > I think it will be better if we split this into > > nonProdSharedConsumption and

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Maxim Khutornenko
> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369 > > > > > > I think it will be better if we split this into > > nonProdSharedConsumption and

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review97675 --- Ship it! Ship It! - Joshua Cohen On Sept. 3, 2015, 12:46 a.m.,

Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/ --- Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji. Bugs:

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review97590 --- Ship it! Master (a459527) is green with this patch.