Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review99157 --- Master (44e4726) is green with this patch. ./build-support/jenkins

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/ --- (Updated Sept. 15, 2015, 7:35 p.m.) Review request for Aurora and Joshua Cohen.

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

> On Sept. 14, 2015, 2:49 p.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java, > > line 105 > > > > > > How is this related to the diff? It isn't, thanks f

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

> On Sept. 14, 2015, 11:01 a.m., Kevin Sweeney wrote: > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java, > > lines 72-73 > > > > > > Will this ever appear to the client? Presumabl

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

> On Sept. 14, 2015, 9:19 a.m., Joshua Cohen wrote: > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java, > > line 78 > > > > > > nit, not even related to your change, but this can

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98925 --- src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerM

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98877 --- Ship it! commons/src/main/java/org/apache/aurora/common/net/http/h

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98858 --- Ship it! Couple of nits, lgtm in general. commons/src/main/java/o

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

> On Sept. 13, 2015, 12:49 p.m., Zameer Manji wrote: > > Maybe we should move these endpoints out of commons and into > > org.apache.aurora.scheduler.http.endpoints? > > Bill Farner wrote: > If it's all the same to you, i'd like to save that for a follow-up to > minimize diff churn. SGTM

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

> On Sept. 13, 2015, 12:49 p.m., Zameer Manji wrote: > > Maybe we should move these endpoints out of commons and into > > org.apache.aurora.scheduler.http.endpoints? If it's all the same to you, i'd like to save that for a follow-up to minimize diff churn. - Bill -

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98781 --- Maybe we should move these endpoints out of commons and into org.a

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98777 --- Ship it! Master (5dccf92) is green with this patch. ./build-suppo

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/ --- (Updated Sept. 13, 2015, 11:06 a.m.) Review request for Aurora and Joshua Cohen

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

> On Sept. 12, 2015, 5:37 p.m., Aurora ReviewBot wrote: > > Master (5dccf92) is red with this patch. > > ./build-support/jenkins/build.sh > > > > > > :processJmhResources UP-TO-DATE > > :jmhClasses > > :checkstyleJmh > > :jsHint > > :checkstyleMain > > :compileTestJavaNote: Some input files u

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98757 --- Master (5dccf92) is red with this patch. ./build-support/jenkins/b

Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --