Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39143/#review102479 --- Ship it! Ship It! - David McLaughlin On Oct. 9, 2015, 10:43

Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39143/#review102532 --- Ship it!

Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-13 Thread Maxim Khutornenko
> On Oct. 13, 2015, 8:51 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java, > > line 479 > > > > > > "Diff is not currently supported for cron jobs." Any

Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-13 Thread Bill Farner
> On Oct. 13, 2015, 1:51 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java, > > line 479 > > > > > > "Diff is not currently supported for cron jobs." > >

Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-13 Thread Maxim Khutornenko
> On Oct. 13, 2015, 8:51 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java, > > line 479 > > > > > > "Diff is not currently supported for cron jobs." > >

Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-13 Thread Maxim Khutornenko
> On Oct. 13, 2015, 8:51 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java, > > line 479 > > > > > > "Diff is not currently supported for cron jobs." > >

Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39143/#review102131 --- Ship it! Master (f630bf7) is green with this patch.

Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39143/#review102088 --- Please, ignore this CR for now. I will update it to match the