Re: Review Request 39532: Always set SessionKey to empty in the client.

2015-10-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/#review103618 --- @reviewbot retry - Kevin Sweeney On Oct. 22, 2015, 10:36 a.m.,

Re: Review Request 39532: Always set SessionKey to empty in the client.

2015-10-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/ --- (Updated Oct. 22, 2015, 10:36 a.m.) Review request for Aurora, Maxim

Re: Review Request 39532: Always set SessionKey to empty in the client.

2015-10-22 Thread Kevin Sweeney
> On Oct. 22, 2015, 10:42 a.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 56-62 > > > > > > Why removing these fields now? This does not feel like a safe > >

Re: Review Request 39532: Always set SessionKey to empty in the client.

2015-10-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/#review103625 --- Ship it! Master (4eeec7a) is green with this patch.

Re: Review Request 39532: Always set SessionKey to empty in the client.

2015-10-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/#review103616 --- Master (4eeec7a) is red with this patch.

Re: Review Request 39532: Always set SessionKey to empty in the client.

2015-10-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/#review103498 --- Ship it! Master (4eeec7a) is green with this patch.

Review Request 39532: Always set SessionKey to empty in the client.

2015-10-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Repository:

Re: Review Request 39532: Always set SessionKey to empty in the client.

2015-10-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/ --- (Updated Oct. 21, 2015, 5:30 p.m.) Review request for Aurora, Maxim