---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40219/#review106527
---
Replacement RB using official plugin is here:
> On Nov. 12, 2015, 12:05 p.m., Zameer Manji wrote:
> > Although the end result LGTM, I'm not sure if having our own custom pants
> > plugin is the way to go here. Historically we have been very bad at
> > upgrading pants and maintaining it, I'm afraid that if we add a custom
> > plugin here
> On Nov. 12, 2015, 12:05 p.m., Zameer Manji wrote:
> > Although the end result LGTM, I'm not sure if having our own custom pants
> > plugin is the way to go here. Historically we have been very bad at
> > upgrading pants and maintaining it, I'm afraid that if we add a custom
> > plugin here
> On Nov. 12, 2015, 12:05 p.m., Zameer Manji wrote:
> > Although the end result LGTM, I'm not sure if having our own custom pants
> > plugin is the way to go here. Historically we have been very bad at
> > upgrading pants and maintaining it, I'm afraid that if we add a custom
> > plugin here
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40219/#review106207
---
Ship it!
Master (48aedae) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40219/#review106213
---
Ship it!
Master (48aedae) is green with this patch.
> On Nov. 12, 2015, 11:05 a.m., Zameer Manji wrote:
> > Although the end result LGTM, I'm not sure if having our own custom pants
> > plugin is the way to go here. Historically we have been very bad at
> > upgrading pants and maintaining it, I'm afraid that if we add a custom
> > plugin here
> On Nov. 12, 2015, 12:05 p.m., Zameer Manji wrote:
> > Although the end result LGTM, I'm not sure if having our own custom pants
> > plugin is the way to go here. Historically we have been very bad at
> > upgrading pants and maintaining it, I'm afraid that if we add a custom
> > plugin here
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40219/#review106301
---
Although the end result LGTM, I'm not sure if having our own
> On Nov. 12, 2015, 12:05 p.m., Zameer Manji wrote:
> > Although the end result LGTM, I'm not sure if having our own custom pants
> > plugin is the way to go here. Historically we have been very bad at
> > upgrading pants and maintaining it, I'm afraid that if we add a custom
> > plugin here
10 matches
Mail list logo
