Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110725 --- Drive-by

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110738 --- Ship it! Ship It! - Joshua Cohen On Dec. 16, 2015, 7:53 p.m.,

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110739 --- Ship it! Ship It! - John Sirois On Dec. 16, 2015, 12:53 p.m.,

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110712 ---

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110742 --- Ship it! Master (fb8155d) is green with this patch.

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Bill Farner
> On Dec. 16, 2015, 11:29 a.m., John Sirois wrote: > > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java, line > > 148 > > > > > > It looks like this can be an NPE without advanced knowledge of

Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description