On March 13, 2016, 6:04 a.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
On March 13, 2016, 6:04 a.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
On March 13, 2016, 6:04 a.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
On March 13, 2016, 12:04 p.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
On March 13, 2016, 6:04 a.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
On March 13, 2016, 12:04 p.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
On March 13, 2016, 6:04 a.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
On March 13, 2016, 12:04 p.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
On March 13, 2016, 12:04 p.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
On March 13, 2016, 1:04 p.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
On March 13, 2016, 12:04 p.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
> On March 14, 2016, 9:31 a.m., Joshua Cohen wrote:
> > This seems like something we should cover with the end to end tests? Would
> > you mind adding a test that spins up the scheduler to allow executor-less
> > tasks, launches a task and then confirms it responds as expected?
> >
> > Also,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44745/#review123425
---
This seems like something we should cover with the end to end
On March 13, 2016, 5:04 a.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44745/#review123314
---
src/main/python/apache/aurora/config/__init__.py (line 142)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44745/#review123293
---
Ship it!
Master (de128a1) is green with this patch.
> On March 12, 2016, 1:37 p.m., Bill Farner wrote:
> > LGTM overall, though if possible it would be nice to omit the
> > `processes=[]` line altogether.
Agreed, and the error was cryptic to boot when omitted previously - fixed.
> On March 12, 2016, 1:37 p.m., Bill Farner wrote:
> >
17 matches
Mail list logo
