Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142990 --- Ship it! I'm not super bothered by the double labels, so I'm

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/ --- (Updated July 20, 2016, 9:26 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

> On July 19, 2016, 11:13 p.m., Dmitriy Shirchenko wrote: > > File Attachment: NEW - offers-new.json > > > > > > Why is there a double nested labels: labels array under reservation? Is > > this just a carry over from how Aurora gets offers

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

> On July 19, 2016, 2:13 p.m., Dmitriy Shirchenko wrote: > > File Attachment: NEW - offers-new.json > > > > > > Why is there a double nested labels: labels array under reservation? Is > > this just a carry over from how Aurora gets offers

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142830 --- File Attachment: NEW - offers-new.json

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142805 --- Fix it, then Ship it! Looks good to me! Additional things

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

> On July 18, 2016, 12:15 a.m., Stephan Erb wrote: > > Should we consider adopting `protobuf-java-util`'s JsonFormatter rather > > than implementing this on our own? > > > > * > > https://github.com/google/protobuf/blob/master/java/util/src/main/java/com/google/protobuf/util/JsonFormat.java

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142682 --- Ship it! Master (e67c6a7) is green with this patch.

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/ --- (Updated July 18, 2016, 7:12 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/ --- (Updated July 18, 2016, 7:11 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/ --- (Updated July 18, 2016, 12:32 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

> On July 17, 2016, 3:15 p.m., Stephan Erb wrote: > > Should we consider adopting `protobuf-java-util`'s JsonFormatter rather > > than implementing this on our own? > > > > * > > https://github.com/google/protobuf/blob/master/java/util/src/main/java/com/google/protobuf/util/JsonFormat.java >

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

> On July 17, 2016, 3:15 p.m., Stephan Erb wrote: > > Should we consider adopting `protobuf-java-util`'s JsonFormatter rather > > than implementing this on our own? > > > > * > > https://github.com/google/protobuf/blob/master/java/util/src/main/java/com/google/protobuf/util/JsonFormat.java >

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

> On July 17, 2016, 3:15 p.m., Stephan Erb wrote: > > Should we consider adopting `protobuf-java-util`'s JsonFormatter rather > > than implementing this on our own? > > > > * > > https://github.com/google/protobuf/blob/master/java/util/src/main/java/com/google/protobuf/util/JsonFormat.java >

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142524 --- Should we consider adopting `protobuf-java-util`'s JsonFormatter

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142443 --- Master (e67c6a7) is red with this patch.

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

> On July 14, 2016, 7:34 p.m., Joshua Cohen wrote: > > How do you feel about adding a unit test for `getOffers` that verifies all > > this new logic? I feel good. :) > On July 14, 2016, 7:34 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/Offers.java, line 89 > >

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142326 --- How do you feel about adding a unit test for `getOffers` that

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142305 --- Master (e67c6a7) is green with this patch.

Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1736