Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/ --- (Updated Sept. 13, 2016, 12:08 a.m.) Review request for Aurora and Maxim Khutor

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Stephan Erb
> On Sept. 12, 2016, 9:31 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 75 > > > > > > Would be great to have a e2e test when this functionality is

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Maxim Khutornenko
> On Sept. 12, 2016, 7:31 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java, > > lines 22-33 > > > > > > This is somewhat non-standard way to define cmd flag

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Stephan Erb
> On Sept. 12, 2016, 9:31 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 75 > > > > > > Would be great to have a e2e test when this functionality is

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/#review148600 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 12, 2016, 1:3

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Stephan Erb
> On Sept. 12, 2016, 8:06 p.m., Zameer Manji wrote: > > docs/reference/scheduler-configuration.md, line 205 > > > > > > As an aside, could you file a ticket to clean up the default here? > > Seems useless ATM. > >

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Stephan Erb
> On Sept. 12, 2016, 9:31 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java, > > lines 22-33 > > > > > > This is somewhat non-standard way to define cmd flag

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/#review148563 --- src/main/java/org/apache/aurora/scheduler/resources/ResourceSetti

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Zameer Manji
> On Sept. 12, 2016, 11:06 a.m., Zameer Manji wrote: > > docs/reference/scheduler-configuration.md, line 205 > > > > > > As an aside, could you file a ticket to clean up the default here? > > Seems useless ATM. > >

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Joshua Cohen
> On Sept. 12, 2016, 6:06 p.m., Zameer Manji wrote: > > docs/reference/scheduler-configuration.md, line 205 > > > > > > As an aside, could you file a ticket to clean up the default here? > > Seems useless ATM. Do y

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/#review148541 --- docs/reference/scheduler-configuration.md (line 205)

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/#review148485 --- Master (b429612) is green with this patch. ./build-support/jenki

Review Request 51807: Introduce a flag to treat RAM as a revocable resources

2016-09-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti