Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/#review156791 --- Ship it! Ship It! - Joshua Cohen On Nov. 23, 2016, 7:44 p.m.

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/#review156775 --- Ship it! Master (4797dfe) is green with this patch. ./build-s

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/ --- (Updated Nov. 23, 2016, 11:44 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/#review156761 --- Fix it, then Ship it! src/jmh/java/org/apache/aurora/benchmark

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Zameer Manji
> On Nov. 23, 2016, 4:36 a.m., Stephan Erb wrote: > > Have you considerd writing a single benchmark with a single `run()` method > > that: > > > > * inserts pending tasks > > * assigns the pending tasks > > * deletes the tasks > > > > Even though the benchmark would not be very fine grained, I

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/#review156727 --- Have you considerd writing a single benchmark with a single `run()

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/#review156695 --- Ship it! Master (320ee08) is green with this patch. ./build-s

Review Request 54011: Add benchmarks for `StateManagerImpl`.

2016-11-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1823