Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-17 Thread Mehrdad Nurolahzade
> On March 17, 2017, 5:01 p.m., Mehrdad Nurolahzade wrote: > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > > Line 85 (original), 87 (patched) > > > > > > Needs to be mentioned in release notes.

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-17 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57708/#review169346 --- Ship it! Ship It!

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57708/#review169347 --- Ship it! Master (e1504a7) is green with this patch.

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-17 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57708/ --- (Updated March 17, 2017, 4:36 p.m.) Review request for Aurora, Mehrdad

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57708/#review169343 --- Master (e1504a7) is red with this patch.

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-17 Thread Zameer Manji
> On March 17, 2017, 8:02 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/FrameworkInfoFactory.java > > Lines 64 (patched) > > > > > > Aurora can run behind an HTTPS capable reverse

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-17 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57708/ --- (Updated March 17, 2017, 3:42 p.m.) Review request for Aurora, Mehrdad

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-17 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57708/#review169288 ---

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57708/#review169222 --- Ship it! Master (e1504a7) is green with this patch.

Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57708/ --- Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb. Bugs:

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

2017-03-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57708/ --- (Updated March 16, 2017, 3:42 p.m.) Review request for Aurora, Mehrdad