Re: Review Request 62958: Add URL handling for tab switching on Job page

2017-10-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62958/#review188377 --- Due to the lack of strong opinions - I'm going to ship this

Re: Review Request 62958: Add URL handling for tab switching on Job page

2017-10-16 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62958/#review188201 --- Ship it! LGTM. I am +1 to Josh's suggestion if the additional

Re: Review Request 62958: Add URL handling for tab switching on Job page

2017-10-16 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62958/#review188181 --- Ship it! LGTM - Kai Huang On Oct. 13, 2017, 12:10 a.m.,

Re: Review Request 62958: Add URL handling for tab switching on Job page

2017-10-16 Thread David McLaughlin
> On Oct. 13, 2017, 2:48 p.m., Joshua Cohen wrote: > > When I implemented this originally I wanted it to be a separate URL > > (http://aurora/scheduler/role/env/job/completed) rather than a query > > parameter (?tab=completed), but due to something in Angular's router it > > wasn't really

Re: Review Request 62958: Add URL handling for tab switching on Job page

2017-10-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62958/#review187962 --- When I implemented this originally I wanted it to be a separate

Re: Review Request 62958: Add URL handling for tab switching on Job page

2017-10-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62958/#review187914 --- Master (2aee90d) is red with this patch.

Review Request 62958: Add URL handling for tab switching on Job page

2017-10-12 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62958/ --- Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar