Re: Review Request 65338: Fix error handling logic for launch failures

2018-01-25 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65338/#review196275 --- Ship it! Ship It! - Jordan Ly On Jan. 25, 2018, 6:21 p.m.,

Re: Review Request 65338: Fix error handling logic for launch failures

2018-01-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65338/ --- (Updated Jan. 25, 2018, 6:21 p.m.) Review request for Aurora, Jordan Ly and

Re: Review Request 65338: Fix error handling logic for launch failures

2018-01-25 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65338/#review196273 --- Ship it! Please link to -

Re: Review Request 65338: Fix error handling logic for launch failures

2018-01-25 Thread David McLaughlin
> On Jan. 25, 2018, 2 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskAssignerImpl.java > > Line 135 (original), 135 (patched) > > > > > > To prevent future mistakes of the same

Re: Review Request 65338: Fix error handling logic for launch failures

2018-01-25 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65338/#review196248 ---

Re: Review Request 65338: Fix error handling logic for launch failures

2018-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65338/#review196226 --- Ship it! Master (dbe7137) is green with this patch.

Review Request 65338: Fix error handling logic for launch failures

2018-01-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65338/ --- Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.