Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 15, 2018, 10:15 a.m.) Review request for Aurora, David

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203049 --- Master (805a53f) is green with this patch.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203047 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 14, 2018,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203045 --- Master (805a53f) is red with this patch.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 14, 2018, 9:52 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 14, 2018, 9:52 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202850 --- Looking really good! I am easily able to use this for my

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202790 --- Ship it! Master (805a53f) is green with this patch.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 9, 2018, 10:49 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On May 8, 2018, 4:30 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > > Lines 110 (patched) > > > > > > I'm wondering if defaultSlaPolicy needs to be

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On May 8, 2018, 9:30 a.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceModule.java > > Lines 35 (patched) > > > > > > Missing javadoc. Done. > On May 8, 2018,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202665 --- Ship it! Master (805a53f) is green with this patch.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202652 --- Looks good, mostly minor feedback.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202657 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 8, 2018,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202651 --- Master (805a53f) is red with this patch.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 8, 2018, 8:49 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On May 3, 2018, 10:43 a.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > > Lines 144-150 (patched) > > > > > > If bound in a private module, you don't need to

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On May 7, 2018, 2:12 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/state/SlaManager.java > > Lines 124-130 (patched) > > > > > > I believe that you will want to only look at the lastest task

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On May 3, 2018, 3:26 p.m., Reza Motamedi wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 248 (patched) > > > > > > Should the comment be updated to match the struct in resolution? > >

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 8, 2018, 8:28 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202594 --- src/main/java/org/apache/aurora/scheduler/state/SlaManager.java

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202386 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift Lines 248

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202363 --- The interface for SlaManager looks good to me! Thanks for the

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202250 --- Master (a3d596e) is red with this patch.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202246 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 1, 2018,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202229 --- Master (a3d596e) is red with this patch.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On April 20, 2018, 3:31 p.m., Jordan Ly wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 263 (patched) > > > > > > Is this per request? Will end users be able to do partial ACKs? Turned

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 1, 2018, 2:19 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review201642 --- Thanks for starting the work on this feature! Very exciting.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review201545 --- Ship it! Master (ad0bc5f) is green with this patch.

Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.