Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Kevin Sweeney
Me too, but I'm okay with killing the sdist targets as an intermediate step and reintroducing them with a non-pants build On Friday, July 24, 2015, Brian Wickman wick...@apache.org wrote: On July 24, 2015, 5:57 p.m., Brian Wickman wrote: src/main/python/apache/thermos/observer/BUILD, line

Review Request 36785: Add retroactive NEWS entry for 0.8.0.

2015-07-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36785/ --- Review request for Aurora and Steve Niemitz. Bugs: AURORA-1403

Re: Review Request 36785: Add retroactive NEWS entry for 0.8.0.

2015-07-24 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36785/#review92948 --- Ship it! Ship It! - Steve Niemitz On July 24, 2015, 6 p.m.,

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/#review92944 --- src/main/python/apache/thermos/observer/BUILD (line 74)

Re: Review Request 36785: Add retroactive NEWS entry for 0.8.0.

2015-07-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36785/#review92952 --- Ship it! Master (55a95ba) is green with this patch.

Re: Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

2015-07-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36797/#review92997 --- @ReviewBot retry - Kevin Sweeney On July 24, 2015, 2:38 p.m.,

Re: Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

2015-07-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36797/#review92995 --- Master (3d9ed87) is red with this patch.

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Brian Wickman
On July 24, 2015, 5:57 p.m., Brian Wickman wrote: src/main/python/apache/thermos/observer/BUILD, line 74 https://reviews.apache.org/r/36700/diff/2/?file=1020365#file1020365line74 This puts an aurora dependency on thermos and I imagine causes a cycle in the build graph (pants may