Re: Review Request 36289: Custom executor support for Scheduler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review95689 --- Master (22f9cbb) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.path_detector . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.http_lifecycle . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . FAILURE src.test.python.apache.thermos.cli.commands.commands . SUCCESS src.test.python.apache.thermos.cli.common . SUCCESS src.test.python.apache.thermos.cli.main . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 18, 2015, 6:10 a.m., Renan DelValle wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/ --- (Updated Aug. 18, 2015, 6:10 a.m.) Review request for Aurora and Bill Farner. Repository: aurora
Re: Review Request 36289: Custom executor support for Scheduler
On Aug. 18, 2015, 3:06 a.m., Aurora ReviewBot wrote: Master (22f9cbb) is red with this patch. ./build-support/jenkins/build.sh :api:checkPython :api:generateThriftEntitiesJava :api:classesThriftEntities :api:compileJava UP-TO-DATE :api:generateThriftResources :api:processResources UP-TO-DATE :api:classes :api:jar :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :startScripts :distTar :distZip :assemble :compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/ExecutorConfiguration.java:23:8: Unused import - com.google.gson.JsonObject. FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleMain'. Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 35.518 secs I will refresh this build result if you post a review containing @ReviewBot retry @ReviewBot retry - Renan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review95680 --- On Aug. 18, 2015, 6:10 a.m., Renan DelValle wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/ --- (Updated Aug. 18, 2015, 6:10 a.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- What was done: == Added support for dynamically chosing an executor that's definied in a server side config file. Removed command line arguments that were moved over to the config file. Updated existing code to reflect the use of a Map instead of a single ExecutorSettings object. Future: === Create an offshoot of the current client that allows to send thrift calls with different executor configs which will allow use of custom executors. Some work on this has already been done and will be published ASAP for testing. Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift f792be0ad393072b4a4ec525363e06cfd16b63d0 examples/vagrant/executors-config.json PRE-CREATION examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/ResourceSlot.java e5953bbf02fc2b08fbdff5c25b5389c5a209dfca src/main/java/org/apache/aurora/scheduler/app/ExecutorConfiguration.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java e74b36bc5f85e5ae5fbb2e0b1e34961251739d9e src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 10389640c87b203386313ab79204ea936272d350 src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java b3c913892248e4a9a8111412307463985f5ca97f src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ff6eb980292c05e35dcf68104c870a7bef95629a src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8162323816aedc711a3af84cd499250b78718ab3 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java a0e71e1c74f67b8836e7da5418012f342977f661 src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 50e7fc91108993e547869df5b9e5c925fb89a225 src/test/java/org/apache/aurora/scheduler/app/ExecutorConfigurationTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoaderTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 37772d0b75d022f072af10d82d096981680e193f src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 608af1afe6fc27c8c597490e88fed75580076c95 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java b2327a47374d81b59886c1e4575ded8340322db7
Re: Review Request 36289: Custom executor support for Scheduler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/ --- (Updated Aug. 18, 2015, 6:10 a.m.) Review request for Aurora and Bill Farner. Changes --- Commited unused import that I had forgotten to :B Repository: aurora Description --- What was done: == Added support for dynamically chosing an executor that's definied in a server side config file. Removed command line arguments that were moved over to the config file. Updated existing code to reflect the use of a Map instead of a single ExecutorSettings object. Future: === Create an offshoot of the current client that allows to send thrift calls with different executor configs which will allow use of custom executors. Some work on this has already been done and will be published ASAP for testing. Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/api.thrift f792be0ad393072b4a4ec525363e06cfd16b63d0 examples/vagrant/executors-config.json PRE-CREATION examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/ResourceSlot.java e5953bbf02fc2b08fbdff5c25b5389c5a209dfca src/main/java/org/apache/aurora/scheduler/app/ExecutorConfiguration.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java e74b36bc5f85e5ae5fbb2e0b1e34961251739d9e src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 10389640c87b203386313ab79204ea936272d350 src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java b3c913892248e4a9a8111412307463985f5ca97f src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ff6eb980292c05e35dcf68104c870a7bef95629a src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8162323816aedc711a3af84cd499250b78718ab3 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java a0e71e1c74f67b8836e7da5418012f342977f661 src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 50e7fc91108993e547869df5b9e5c925fb89a225 src/test/java/org/apache/aurora/scheduler/app/ExecutorConfigurationTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoaderTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 37772d0b75d022f072af10d82d096981680e193f src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 608af1afe6fc27c8c597490e88fed75580076c95 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java b2327a47374d81b59886c1e4575ded8340322db7 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 02fe96445148d1e14d85dc7a6fa386d84a8a8c70 src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 6a80503aeb2058e8f8065285adc151197d2d14d6 src/test/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java a1ac922d471013779710e02c0c9ca9f84b506807 src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java b9cb5bfe9f89a8bfdb96b6eeb1998ed105963484 src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 66f20c6a63b331353c467cde5521f21e4df49e2d src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimTest.java 09380f95a7d9405f770513db35d2a45d23d89b61 src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorImplTest.java b07ff7babd217dac4153831a0d78325bcb72b306 src/test/resources/org/apache/aurora/scheduler/app/executor-settings-example.json PRE-CREATION src/test/resources/org/apache/aurora/scheduler/app/executor-settings-mesos-command-example.json PRE-CREATION src/test/resources/org/apache/aurora/scheduler/app/executor-settings-thermos-no-observer.json PRE-CREATION Diff: https://reviews.apache.org/r/36289/diff/ Testing --- Ran jenkins build test, passed all tests, code style checks, findbugs check, and PMD. Ran end to end, failed upon reaching kerberos tests. Thanks, Renan DelValle
Re: Review Request 37560: Adding TierManager initial implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/#review95750 --- src/main/java/org/apache/aurora/scheduler/TierInfo.java (line 27) https://reviews.apache.org/r/37560/#comment150864 For better readability, how about using an enum? - Stephan Erb On Aug. 18, 2015, 7:04 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/ --- (Updated Aug. 18, 2015, 7:04 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- Introducing `TierManager` implementation. This diff addresses basic needs within the Oversubscription feature scope. Only TaskAssigner is modified to use TierManager. Other consumers will be addressed separately. More about the TierManager concept here: https://docs.google.com/document/d/1r1WCHgmPJp5wbrqSZLsgtxPNj3sULfHrSFmxp2GyPTo Diffs - src/main/java/org/apache/aurora/scheduler/Resources.java 40df26234ad9959227d8a56edbe563f252d47560 src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 45265ea6cef5e26a3d7303a9653cfca110528d4b src/main/java/org/apache/aurora/scheduler/TierInfo.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/TierManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java ca4b5b0b01c7b347fc90f40d77f96cf9d4d94163 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 88958d1510cf9402a7d1e422de9f7918004e188b Diff: https://reviews.apache.org/r/37560/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37560: Adding TierManager initial implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/ --- (Updated Aug. 18, 2015, 6:23 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Changes --- Fixing visibility and adding coverage. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- Introducing `TierManager` implementation. This diff addresses basic needs within the Oversubscription feature scope. Only TaskAssigner is modified to use TierManager. Other consumers will be addressed separately. More about the TierManager concept here: https://docs.google.com/document/d/1r1WCHgmPJp5wbrqSZLsgtxPNj3sULfHrSFmxp2GyPTo Diffs (updated) - src/main/java/org/apache/aurora/scheduler/Resources.java 40df26234ad9959227d8a56edbe563f252d47560 src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 45265ea6cef5e26a3d7303a9653cfca110528d4b src/main/java/org/apache/aurora/scheduler/TierInfo.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/TierManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java ca4b5b0b01c7b347fc90f40d77f96cf9d4d94163 src/test/java/org/apache/aurora/scheduler/ResourcesTest.java a5878a4efada5b5872be77ad887a0ffe8695d6b8 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 88958d1510cf9402a7d1e422de9f7918004e188b Diff: https://reviews.apache.org/r/37560/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37560: Adding TierManager initial implementation.
On Aug. 18, 2015, 8:08 p.m., Stephan Erb wrote:
src/main/java/org/apache/aurora/scheduler/TierInfo.java, line 27
https://reviews.apache.org/r/37560/diff/2/?file=1043194#file1043194line27
For better readability, how about using an enum?
Maxim Khutornenko wrote:
Not sure I undestand. Are you proposing converting TierInfo into an enum
or the arguments of TierInfo to be an EnumSet? I am afraid neither would make
sense as TierInfo will eventually wrap free-form task attributes defined in
an external config file. Given the config file example in
https://docs.google.com/document/d/1r1WCHgmPJp5wbrqSZLsgtxPNj3sULfHrSFmxp2GyPTo,
a possible TierInfo constructor could look similar to this:
```
TierInfo(String name, boolean revocable, boolean preemtible, boolean
quotaRequired, AmountLong, TimeUnit uptime, double percentage ...)
```
I was referring to the boolean values which IMHO make constructor calls (for
example in tests) very hard to read. For example: `TierInfo('mytier', false,
false, true, ...)` vs `TierInfo('mytier', Offers.UNREVOCABLE,
Jobs.UNPREEMPTIBLE, Quotas.REQUIRED, ...)`.
But you are right that this adds an aditional indirection layer when passing
values from the config.
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37560/#review95750
---
On Aug. 18, 2015, 8:23 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37560/
---
(Updated Aug. 18, 2015, 8:23 p.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Bugs: AURORA-1437
https://issues.apache.org/jira/browse/AURORA-1437
Repository: aurora
Description
---
Introducing `TierManager` implementation. This diff addresses basic needs
within the Oversubscription feature scope.
Only TaskAssigner is modified to use TierManager. Other consumers will be
addressed separately.
More about the TierManager concept here:
https://docs.google.com/document/d/1r1WCHgmPJp5wbrqSZLsgtxPNj3sULfHrSFmxp2GyPTo
Diffs
-
src/main/java/org/apache/aurora/scheduler/Resources.java
40df26234ad9959227d8a56edbe563f252d47560
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
45265ea6cef5e26a3d7303a9653cfca110528d4b
src/main/java/org/apache/aurora/scheduler/TierInfo.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/TierManager.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java
ca4b5b0b01c7b347fc90f40d77f96cf9d4d94163
src/test/java/org/apache/aurora/scheduler/ResourcesTest.java
a5878a4efada5b5872be77ad887a0ffe8695d6b8
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
88958d1510cf9402a7d1e422de9f7918004e188b
Diff: https://reviews.apache.org/r/37560/diff/
Testing
---
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 37560: Adding TierManager initial implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/#review95748 --- Master (22f9cbb) is red with this patch. ./build-support/jenkins/build.sh :api:compileJava UP-TO-DATE :api:generateThriftResources :api:processResources UP-TO-DATE :api:classes :api:jar :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :startScripts :distTar :distZip :assemble :compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/ResourcesTest.java:121: error: CPU has private access in Resources Resources.from(createOffer(resources)).filter(Resources.CPU).slot()); ^ 1 error FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileTestJava'. Compilation failed; see the compiler error output for details. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 51.786 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 18, 2015, 5:04 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/ --- (Updated Aug. 18, 2015, 5:04 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- Introducing `TierManager` implementation. This diff addresses basic needs within the Oversubscription feature scope. Only TaskAssigner is modified to use TierManager. Other consumers will be addressed separately. More about the TierManager concept here: https://docs.google.com/document/d/1r1WCHgmPJp5wbrqSZLsgtxPNj3sULfHrSFmxp2GyPTo Diffs - src/main/java/org/apache/aurora/scheduler/Resources.java 40df26234ad9959227d8a56edbe563f252d47560 src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 45265ea6cef5e26a3d7303a9653cfca110528d4b src/main/java/org/apache/aurora/scheduler/TierInfo.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/TierManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java ca4b5b0b01c7b347fc90f40d77f96cf9d4d94163 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 88958d1510cf9402a7d1e422de9f7918004e188b Diff: https://reviews.apache.org/r/37560/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37560: Adding TierManager initial implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/#review95772 --- Ship it! Master (22f9cbb) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 18, 2015, 6:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/ --- (Updated Aug. 18, 2015, 6:23 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- Introducing `TierManager` implementation. This diff addresses basic needs within the Oversubscription feature scope. Only TaskAssigner is modified to use TierManager. Other consumers will be addressed separately. More about the TierManager concept here: https://docs.google.com/document/d/1r1WCHgmPJp5wbrqSZLsgtxPNj3sULfHrSFmxp2GyPTo Diffs - src/main/java/org/apache/aurora/scheduler/Resources.java 40df26234ad9959227d8a56edbe563f252d47560 src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 45265ea6cef5e26a3d7303a9653cfca110528d4b src/main/java/org/apache/aurora/scheduler/TierInfo.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/TierManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java ca4b5b0b01c7b347fc90f40d77f96cf9d4d94163 src/test/java/org/apache/aurora/scheduler/ResourcesTest.java a5878a4efada5b5872be77ad887a0ffe8695d6b8 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 88958d1510cf9402a7d1e422de9f7918004e188b Diff: https://reviews.apache.org/r/37560/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 18, 2015, 9:23 p.m.) Review request for Aurora, David McLaughlin and Maxim Khutornenko. Changes --- rebase. Repository: aurora Description --- Add a new UI page to show all tasks (active and completed) for a specific instance id. N.B.: changes to controllers.js look significant, but it's 90% refactoring so that JobController and JobInstanceController can reuse common code. Diffs (updated) - src/main/python/apache/aurora/client/base.py dee4c28a26828912bec073c7e5213a03c9703eee src/main/resources/scheduler/assets/breadcrumb.html 13147935c3c28680d5decd1e03e40d9cf04aaed3 src/main/resources/scheduler/assets/css/app.css a4735efe58a09a46f2b95ebe98f219cb9e7ee27d src/main/resources/scheduler/assets/instance.html PRE-CREATION src/main/resources/scheduler/assets/job.html 942635a61132bb9a38a6faf3f8fe046e6bcabd95 src/main/resources/scheduler/assets/js/app.js b66409f628046c67b62c92a75cbeed20c09b4ec1 src/main/resources/scheduler/assets/js/controllers.js 04ea1cb6998af7c238eb2fd1a7d05a9663abc56c src/main/resources/scheduler/assets/js/services.js a514fa7da3c049e1f5a3e49263a82cf2c28d1b2d src/main/resources/scheduler/assets/taskInstance.html PRE-CREATION src/test/python/apache/aurora/client/cli/test_supdate.py 21bea702a6e6fe68652e2195c5d24b56b6477738 src/test/python/apache/aurora/client/test_base.py 1a560088279ac945cce14d02454e50b8483771e4 Diff: https://reviews.apache.org/r/37365/diff/ Testing --- - ./gradlew jsHint - ./pants test src/test/python/apache/aurora/client:base - Verified update page url in client was correct in Vagrant. - See attached screenshot for an example of what the instance page looks like. File Attachments Example of instance page in action. https://reviews.apache.org/media/uploaded/files/2015/08/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png Thanks, Joshua Cohen
Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95775 --- Ship it! Looks much better with the services change, thanks! Screenshot also LGTM. - David McLaughlin On Aug. 17, 2015, 9:55 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 17, 2015, 9:55 p.m.) Review request for Aurora, David McLaughlin and Maxim Khutornenko. Repository: aurora Description --- Add a new UI page to show all tasks (active and completed) for a specific instance id. N.B.: changes to controllers.js look significant, but it's 90% refactoring so that JobController and JobInstanceController can reuse common code. Diffs - src/main/python/apache/aurora/client/base.py dee4c28a26828912bec073c7e5213a03c9703eee src/main/resources/scheduler/assets/breadcrumb.html 13147935c3c28680d5decd1e03e40d9cf04aaed3 src/main/resources/scheduler/assets/css/app.css a4735efe58a09a46f2b95ebe98f219cb9e7ee27d src/main/resources/scheduler/assets/instance.html PRE-CREATION src/main/resources/scheduler/assets/job.html 942635a61132bb9a38a6faf3f8fe046e6bcabd95 src/main/resources/scheduler/assets/js/app.js b66409f628046c67b62c92a75cbeed20c09b4ec1 src/main/resources/scheduler/assets/js/controllers.js 04ea1cb6998af7c238eb2fd1a7d05a9663abc56c src/main/resources/scheduler/assets/js/services.js a514fa7da3c049e1f5a3e49263a82cf2c28d1b2d src/main/resources/scheduler/assets/taskInstance.html PRE-CREATION src/test/python/apache/aurora/client/cli/test_supdate.py 21bea702a6e6fe68652e2195c5d24b56b6477738 src/test/python/apache/aurora/client/test_base.py 1a560088279ac945cce14d02454e50b8483771e4 Diff: https://reviews.apache.org/r/37365/diff/ Testing --- - ./gradlew jsHint - ./pants test src/test/python/apache/aurora/client:base - Verified update page url in client was correct in Vagrant. - See attached screenshot for an example of what the instance page looks like. File Attachments Example of instance page in action. https://reviews.apache.org/media/uploaded/files/2015/08/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png Thanks, Joshua Cohen
Re: Review Request 37593: Modifying resource counters to support revocable resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37593/#review95814 --- Ship it! Master (f5025f3) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 18, 2015, 10:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37593/ --- (Updated Aug. 18, 2015, 10:58 p.m.) Review request for Aurora and Zameer Manji. Bugs: AURORA-1439 https://issues.apache.org/jira/browse/AURORA-1439 Repository: aurora Description --- This could have been a bit easier if we did not expose zero-counters by default. The full counter name expansion is now handled by SLOT_GROUPS. Diffs - src/main/java/org/apache/aurora/scheduler/Resources.java 3b4fbb6c625061b0c3afa57482a7ba99a9c6ced5 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 74a654619b56301c8745eac47cfb9d38b9d7de66 src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 6dbc5d6c052f59a0d326ecfe33a92669d4b38e13 src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 39c055da8f2552bd11705f7f1e147ffc98b99f7c src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java b6623d5e1160e97af397b1a54da3f5d4304dcceb Diff: https://reviews.apache.org/r/37593/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
