Re: Review Request 38326: Adding ssh options into "aurora task" commands.

> On Sept. 11, 2015, 4:36 p.m., Bill Farner wrote: > > How would you feel about an env var instead of command line arg? This > > seems like something people might put in their bash profile. > > Maxim Khutornenko wrote: > I don't really like relying on env variables in places where direct

Re: Review Request 38390: Adding oversubscription summary.

> On Sept. 15, 2015, 1:20 a.m., Bill Farner wrote: > > docs/configuration-reference.md, lines 344-355 > > > > > > Tiers seems like a significant enough topic to warrant its own page > > with some more context and

Re: Review Request 38390: Adding oversubscription summary.

> On Sept. 15, 2015, 8:59 p.m., Stephan Erb wrote: > > docs/configuration-reference.md, line 346 > > > > > > How about attaching a date or version classifier here? Makes it much > > easier for a reader to

Re: Review Request 38390: Adding oversubscription summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38390/ --- (Updated Sept. 16, 2015, 12:38 a.m.) Review request for Aurora and Bill

Re: Review Request 38385: Documenting dedicated job & quota relationship.

> On Sept. 16, 2015, 2:51 a.m., Bill Farner wrote: > > docs/configuration-tutorial.md, line 583 > > > > > > Woah, this is a new doc to me...seems significantly redundant with > > configuration-reference.md. All

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

> On Sept. 11, 2015, 4:36 p.m., Bill Farner wrote: > > How would you feel about an env var instead of command line arg? This > > seems like something people might put in their bash profile. > > Maxim Khutornenko wrote: > I don't really like relying on env variables in places where direct

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/ --- (Updated Sept. 15, 2015, 7:35 p.m.) Review request for Aurora and Joshua

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review99157 --- Master (44e4726) is green with this patch.

Re: Review Request 38385: Documenting dedicated job & quota relationship.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99134 --- Ship it! Master (44e4726) is green with this patch.

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

> On Sept. 14, 2015, 11:01 a.m., Kevin Sweeney wrote: > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java, > > lines 72-73 > > > > > > Will this ever appear to the client?

Re: Review Request 38390: Adding oversubscription summary.

> On Sept. 14, 2015, 6:20 p.m., Bill Farner wrote: > > docs/configuration-reference.md, lines 344-355 > > > > > > Tiers seems like a significant enough topic to warrant its own page > > with some more context and

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99132 --- This patch is looking good to me, but i won't have time to give it

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38389/#review99133 --- Ship it! Ship It! - Bill Farner On Sept. 15, 2015, 12:56 p.m.,

Re: Review Request 38385: Documenting dedicated job & quota relationship.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99136 --- Overall content LGTM. Mostly nits about organization, and a

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

> On Sept. 14, 2015, 9:19 a.m., Joshua Cohen wrote: > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java, > > line 78 > > > > > > nit, not even related to your change, but this can

Re: Review Request 38385: Documenting dedicated job & quota relationship.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/ --- (Updated Sept. 16, 2015, 12:14 a.m.) Review request for Aurora and Bill

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38326/#review99130 --- Ship it!

Re: Review Request 38390: Adding oversubscription summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38390/#review99137 --- Ship it! Master (44e4726) is green with this patch.

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

> On Sept. 11, 2015, 11:36 p.m., Bill Farner wrote: > > How would you feel about an env var instead of command line arg? This > > seems like something people might put in their bash profile. > > Maxim Khutornenko wrote: > I don't really like relying on env variables in places where direct

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38389/#review99005 --- Ship it! Master (44e4726) is green with this patch.

Re: Review Request 38390: Adding oversubscription summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38390/#review99006 --- Ship it! Master (44e4726) is green with this patch.

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38389/#review99082 --- Ship it! Master (44e4726) is green with this patch.

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

> On Sept. 15, 2015, 1:24 a.m., Bill Farner wrote: > > The default value wasn't a hack, but moving it to the end of the > > `TaskConfig` message definition was. I think the default is useful and > > should really remain. IIRC we concluded that the `optional` was > > unnecessary, though. > >

Re: Review Request 38385: Documenting dedicated job & quota relationship.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99090 --- Reading your changes, I have noticed that we are missing a