Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39143/#review102131 --- Ship it! Master (f630bf7) is green with this patch.

Re: Review Request 37851: Use "Mesos Agent" instead of "Mesos Slave" in docs.

2015-10-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37851/#review102075 --- This patch does not apply cleanly on master (8816d49), do you need

Re: Review Request 37851: Use "Mesos Agent" instead of "Mesos Slave" in docs.

2015-10-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37851/ --- (Updated Oct. 9, 2015, 9:38 a.m.) Review request for Aurora, Maxim Khutornenko

Review Request 39169: Minor improvement of the storoge documentation

2015-10-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39169/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 39170: Fix NPE on accessing crons set at impossible dates

2015-10-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39170/#review102055 --- Master (8816d49) is red with this patch.

Re: Review Request 39170: Fix NPE on accessing crons set at impossible dates

2015-10-09 Thread Brice Arnould
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39170/ --- (Updated oct. 9, 2015, 12:41 après-midi) Review request for Aurora and Kevin

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/#review102083 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 351)

Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

2015-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39143/#review102088 --- Please, ignore this CR for now. I will update it to match the

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-09 Thread David McLaughlin
> On Oct. 9, 2015, 5:12 p.m., Kevin Sweeney wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 351 > > > > > > Please rename this to deprecatedInstanceIds. -1 to this deprecation technique. -

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-09 Thread Kevin Sweeney
> On Oct. 9, 2015, 10:12 a.m., Kevin Sweeney wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 351 > > > > > > Please rename this to deprecatedInstanceIds. > > David McLaughlin wrote: > -1

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-09 Thread Maxim Khutornenko
> On Oct. 9, 2015, 5:12 p.m., Kevin Sweeney wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 351 > > > > > > Please rename this to deprecatedInstanceIds. > > David McLaughlin wrote: > -1 to

Re: Review Request 39057: "aurora config read" command

2015-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39057/#review102076 --- Ship it! src/main/python/apache/aurora/client/cli/config.py

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/#review102086 --- Ship it! Ship It! - David McLaughlin On Oct. 9, 2015, 1:32

Re: Review Request 39169: Fix minor inconsistencies in the storage documentation

2015-10-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39169/ --- (Updated Oct. 9, 2015, 2:59 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 39170: Fix NPE on accessing crons set at impossible dates

2015-10-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39170/#review102054 --- src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java

Re: Review Request 37851: Use "Mesos Agent" instead of "Mesos Slave" in docs.

2015-10-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37851/#review102091 --- Ship it! Master (8816d49) is green with this patch.