Re: Review Request 40104: Callback should only be called on drained hosts.

2015-11-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40104/#review105737 --- Master (ec61b8b) is red with this patch.

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105748 --- @ReviewBot retry - John Sirois On Nov. 9, 2015, 2:47 p.m., John

Review Request 40104: Callback should only be called on drained hosts.

2015-11-09 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40104/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs:

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105743 --- @ReviewBot retry - John Sirois On Oct. 29, 2015, 4:05 p.m.,

Re: Review Request 38975: AURORA-1512: Aurora rpm missing std output switch

2015-11-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38975/#review105782 --- Ship it! Sorry for the egregious delay here! - Bill Farner On

Re: Review Request 39958: deleting unused function deprecation_warning adding test coverage to base, job_monitor, quota_check, scheduler_client

2015-11-09 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39958/#review105716 --- Ship it! Ship It! - Zameer Manji On Nov. 4, 2015, 5:26 p.m.,

Re: Review Request 39958: deleting unused function deprecation_warning adding test coverage to base, job_monitor, quota_check, scheduler_client

2015-11-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39958/#review105722 --- Dmitriy - your reviewboard profile doesn't include an e-mail

Re: Review Request 39958: deleting unused function deprecation_warning adding test coverage to base, job_monitor, quota_check, scheduler_client

2015-11-09 Thread Dmitriy Shirchenko
> On Nov. 9, 2015, 7:17 p.m., Bill Farner wrote: > > Dmitriy - your reviewboard profile doesn't include an e-mail address, which > > would land in the commit message on master. Can you add one so we can give > > proper authorship credit? Shoot, I just changed it since @uber.com originating