Re: Review Request 48591: Ensure we can verify release candidates in the Vagrant box

2016-06-11 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48591/#review137141
---



@ReviewBot retry

- Stephan Erb


On June 12, 2016, 12:21 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48591/
> ---
> 
> (Updated June 12, 2016, 12:21 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> * bump the virtualbox memory to make the tests pass
>   (otherwise failing with 'Cannot allocate memory')
> * remove unnecessary destroy step that seems to be copy
>   pasted from the egg-building scripts.
> 
> 
> Diffs
> -
> 
>   Vagrantfile b2b8f005bda89f2d5530fb2ccc0902b53bb0d9f7 
>   build-support/release/verify-release-candidate 
> 7aa9c9095bbab1ad497186ec700fde2d52498ea7 
> 
> Diff: https://reviews.apache.org/r/48591/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>



Review Request 48591: Ensure we can verify release candidates in the Vagrant box

2016-06-11 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48591/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

* bump the virtualbox memory to make the tests pass
  (otherwise failing with 'Cannot allocate memory')
* remove unnecessary destroy step that seems to be copy
  pasted from the egg-building scripts.


Diffs
-

  Vagrantfile b2b8f005bda89f2d5530fb2ccc0902b53bb0d9f7 
  build-support/release/verify-release-candidate 
7aa9c9095bbab1ad497186ec700fde2d52498ea7 

Diff: https://reviews.apache.org/r/48591/diff/


Testing
---


Thanks,

Stephan Erb



Re: Review Request 48513: Update rpm services to match debian

2016-06-11 Thread Kasisnu Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48513/
---

(Updated June 12, 2016, 1:28 a.m.)


Review request for Aurora and Stephan Erb.


Bugs: AURORA-1394
https://issues.apache.org/jira/browse/AURORA-1394


Repository: aurora-packaging


Description
---

Update rpm startup scripts to match deb patterns in use


Diffs
-

  specs/rpm/SOURCES/aurora.init.sh  
  specs/rpm/SOURCES/aurora.logrotate  
  specs/rpm/SOURCES/aurora.service  
  specs/rpm/SOURCES/aurora.startup.sh 3c444d98c4bd02a7e25b60c20bc3f6a988014046 
  specs/rpm/SOURCES/aurora.sysconfig  
  specs/rpm/SOURCES/thermos-observer.init.sh 
38eea53cd0bd5e38e379b5e4ef54482c53d79dd0 
  specs/rpm/SOURCES/thermos-observer.logrotate  
  specs/rpm/SOURCES/thermos-observer.service 
d0196350883d5a15e2cc6017d27917d8bb13b1b9 
  specs/rpm/SOURCES/thermos-observer.startup.sh 
2d94fd9314daa6e461f1e162a43ea965d53a904b 
  specs/rpm/SOURCES/thermos-observer.sysconfig  
  specs/rpm/aurora.spec a4fc46dc5241fc163a854da0b16c38e44d3be97e 

Diff: https://reviews.apache.org/r/48513/diff/


Testing
---

Setup a fresh aurora cluster using rpms built with these changes.


Tickets covered: AURORA-1394

Is a rebase of https://reviews.apache.org/r/40877/


Thanks,

Kasisnu Singh



Re: Review Request 48591: Ensure we can verify release candidates in the Vagrant box

2016-06-11 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48591/#review137140
---



Master (f9bbfb3) is red with this patch.
  ./build-support/jenkins/build.sh

   with temporary_dir() as checkpoint_root:
 te = AuroraExecutor(
 >   
runner_provider=make_provider(checkpoint_root),
 
sandbox_provider=DefaultTestSandboxProvider())
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:580: 
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in 
make_provider
 pex_location=thermos_runner_path(),
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
 build = True
 
 def thermos_runner_path(build=True):
   if not build:
 return getattr(thermos_runner_path, 'value', 
None)
 
   if not hasattr(thermos_runner_path, 'value'):
 pex_dir = safe_mkdtemp()
 >   assert subprocess.call(["./pants", 
"--pants-distdir=%s" % pex_dir, "binary",
   
"src/main/python/apache/thermos/runner:thermos_runner"]) == 0
 E   assert 1 == 0
 E+  where 1 = (['./pants', '--pants-distdir=/tmp/user/2396/tmpU8sLiq', 
'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
 E+where  = subprocess.call
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: 
AssertionError
 -- Captured stderr call --
 Traceback (most recent call last):
   File 
"/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", 
line 7, in 
 from pants.bin.pants_exe import main
 ImportError: No module named pants.bin.pants_exe
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  16 failed, 638 passed, 6 skipped, 1 warnings, 8 
error in 127.24 seconds 
 
FAILURE


   Waiting for background workers to finish.
22:35:40 02:58   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 11, 2016, 10:21 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48591/
> ---
> 
> (Updated June 11, 2016, 10:21 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> * bump the virtualbox memory to make the tests pass
>   (otherwise failing with 'Cannot allocate memory')
> * remove unnecessary destroy step that seems to be copy
>   pasted from the egg-building scripts.
> 
> 
> Diffs
> -
> 
>   Vagrantfile b2b8f005bda89f2d5530fb2ccc0902b53bb0d9f7 
>   build-support/release/verify-release-candidate 
> 7aa9c9095bbab1ad497186ec700fde2d52498ea7 
> 
> Diff: https://reviews.apache.org/r/48591/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>



Re: Review Request 48591: Ensure we can verify release candidates in the Vagrant box

2016-06-11 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48591/#review137143
---



Master (f9bbfb3) is red with this patch.
  ./build-support/jenkins/build.sh

  Test coverage missing for 
org/apache/aurora/scheduler/storage/log/WriteAheadStorage
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogManager
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/StorageBackup$StorageBackupImpl$BackupConfig
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/BackupModule
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/StorageBackup$StorageBackupImpl
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$7
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$6
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$5
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$4
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$3
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$2
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$1
  Test coverage missing for org/apache/aurora/scheduler/TaskVars
  Test coverage missing for 
org/apache/aurora/scheduler/SchedulerLifecycle$SchedulerCandidateImpl
  Test coverage missing for 
org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
  Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
  Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
  Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
  Test coverage missing for org/apache/aurora/scheduler/SchedulerModule
  Test coverage missing for 
org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
  Test coverage missing for 
org/apache/aurora/scheduler/TierManager$TierManagerImpl
  Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$1
  Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl
  Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle
  Test coverage missing for 
org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateStatusTypeHandler
  Test coverage missing for 
org/apache/aurora/scheduler/storage/db/typehandlers/MaintenanceModeTypeHandler
  Test coverage missing for 
org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateActionTypeHandler

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

BUILD FAILED

Total time: 5 mins 40.778 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 11, 2016, 10:21 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48591/
> ---
> 
> (Updated June 11, 2016, 10:21 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> * bump the virtualbox memory to make the tests pass
>   (otherwise failing with 'Cannot allocate memory')
> * remove unnecessary destroy step that seems to be copy
>   pasted from the egg-building scripts.
> 
> 
> Diffs
> -
> 
>   Vagrantfile b2b8f005bda89f2d5530fb2ccc0902b53bb0d9f7 
>   build-support/release/verify-release-candidate 
> 7aa9c9095bbab1ad497186ec700fde2d52498ea7 
> 
> Diff: https://reviews.apache.org/r/48591/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>