Re: Review Request 55409: AURORA-1873 CuratorServiceGroupMonitor.LOG should use its own logger name

2017-01-11 Thread Bing-Qian Luan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55409/ --- (Updated Jan. 11, 2017, 3:59 p.m.) Review request for Aurora and Joshua Cohen.

Re: Review Request 55409: AURORA-1873 CuratorServiceGroupMonitor.LOG should use its own logger name

2017-01-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55409/#review161250 --- Ship it! Thanks for cleaning this up! - Joshua Cohen On

Re: Review Request 55434: Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.

2017-01-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55434/#review161303 --- Master (a94601a) is red with this patch.

Re: Review Request 55434: Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.

2017-01-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55434/#review161310 --- Ship it! I am aware this is just a move, but why not make it

Re: Review Request 55434: Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.

2017-01-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55434/#review161312 --- Master (a94601a) is red with this patch.

Re: Review Request 55434: Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.

2017-01-11 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55434/#review161316 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Jan. 11,

Re: Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

2017-01-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54967/#review161315 --- Ship it! Ship It! - Joshua Cohen On Dec. 22, 2016, 7:37

Re: Review Request 55434: Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.

2017-01-11 Thread Santhosh Kumar Shanmugham
> On Jan. 11, 2017, 2:11 p.m., Santhosh Kumar Shanmugham wrote: > > Ship It! Thanks for fixing this. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55434/#review161316

Re: Review Request 55357: AURORA-1867 Consider reserving for multiple tasks per preemption round

2017-01-11 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55357/ --- (Updated Jan. 11, 2017, 8:48 a.m.) Review request for Aurora, David

Re: Review Request 55357: AURORA-1867 Consider reserving for multiple tasks per preemption round

2017-01-11 Thread Mehrdad Nurolahzade
> On Jan. 10, 2017, 2:11 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java, > > lines 64-65 > > > > > > We only have a reservation once we have found a match. How

Re: Review Request 55409: AURORA-1873 CuratorServiceGroupMonitor.LOG should use its own logger name

2017-01-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55409/#review161196 --- Master (3bdf027) is green with this patch.

Re: Review Request 55058: AURORA-1859 Expose stats on statically banned offers

2017-01-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55058/#review161319 --- Ship it! Ship It! - Joshua Cohen On Dec. 28, 2016, 6:25

Re: Review Request 55434: Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.

2017-01-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55434/ --- (Updated Jan. 11, 2017, 10:18 p.m.) Review request for Aurora and Santhosh

Re: Review Request 55357: AURORA-1867 Consider reserving for multiple tasks per preemption round

2017-01-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55357/#review161265 --- Master (a94601a) is red with this patch.

Review Request 55434: Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.

2017-01-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55434/ --- Review request for Aurora and Santhosh Kumar Shanmugham. Bugs: AURORA-1878