Re: Review Request 61249: Cron timezone should be configurable per job

> On Aug. 2, 2017, 10:38 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > > Lines 185-186 (patched) > > > > > > Can you add a comment to this

Re: Review Request 61249: Cron timezone should be configurable per job

> On Aug. 2, 2017, 8:38 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > > Lines 266 (patched) > > > > > > This will be null for all crons scheduled

Re: Review Request 61249: Cron timezone should be configurable per job

> On Aug. 2, 2017, 10:38 p.m., David McLaughlin wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 328 (patched) > > > > > > Needs to be marked optional to support your backwards-compatible >

Re: Review Request 61249: Cron timezone should be configurable per job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61249/#review182151 --- Thanks a lot for the patch! This looks good to me in general. I

Re: Review Request 61249: Cron timezone should be configurable per job

> On Aug. 2, 2017, 8:38 p.m., David McLaughlin wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 328 (patched) > > > > > > Needs to be marked optional to support your backwards-compatible >

Re: Review Request 61249: Cron timezone should be configurable per job

> On Aug. 2, 2017, 10:38 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > > Lines 266 (patched) > > > > > > This will be null for all crons scheduled

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182164 --- Thanks for the patch! Good work with the cleanup. I am not an

Re: Review Request 61402: FIX observer themos extra arguments usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61402/#review182106 --- Ship it! Ship It! - Stephan Erb On Aug. 3, 2017, 2:51 p.m.,

Review Request 61402: FIX observer themos extra arguments usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61402/ --- Review request for Aurora and Stephan Erb. Repository: aurora-packaging