Re: Review Request 63564: Migrate from findbugs to spotbugs

2017-11-05 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63564/#review190110
---


Ship it!




Ship It!

- Bill Farner


On Nov. 5, 2017, 2:42 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63564/
> ---
> 
> (Updated Nov. 5, 2017, 2:42 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Findbugs [1] is no longer developed and replaced by spotbugs [2]
> as mostly a drop-in replacement.
> 
> [1] https://github.com/findbugsproject/findbugs
> [2] 
> https://mailman.cs.umd.edu/pipermail/findbugs-discuss/2017-September/004383.html
> 
> 
> Diffs
> -
> 
>   build.gradle 26051ac9267060606a5a4e05a1ac432c1ff4c79b 
>   config/findbugs/excludeFilter.xml 4d5b36f0c9ae9312ba6afdc6f0b4a42ab0c2dc2b 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferOrderBuilder.java 
> 2676da0a4aba3ff4afc7801dfd8f9d16918d87ff 
> 
> 
> Diff: https://reviews.apache.org/r/63564/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

2017-11-05 Thread Mohit Jaggi 
Thanks Stephan.

On Fri, Nov 3, 2017 at 11:05 AM, Stephan Erb  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57524/
>
> On November 2nd, 2017, 10:38 p.m. CET, *Mohit Jaggi* wrote:
>
> Folks, Is this going to get committed?
>
> I believe this breaks a few things when enabled (e.g. user creation). I will 
> need to take a closer look next week.
>
>
> - Stephan
>
> On March 13th, 2017, 5:36 p.m. CET, Zameer Manji wrote:
> Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.
> By Zameer Manji.
>
> *Updated March 13, 2017, 5:36 p.m.*
> *Bugs: * AURORA-1903 
> *Repository: * aurora
> Description
>
> The mesos unified containerizer does not support absolute container path 
> mounts if no rootfs is set. This allows operators to switch between our 
> current behaviour (mounting images as a volume) and setting the rootfs. See 
> AURORA-1903 for more detailed analysis.
>
> Diffs
>
>- src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java (
>f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49)
>- 
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>(4dac9757a65e144142d36ee921b85a02a5311fe5)
>- 
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java
>(5c987fd051728486172c8afd34219e86d56f00d5)
>- src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
>(0d639f66db456858278b0485c91c40975c3b45ac)
>- src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java
>(e1cd81e6fbd98f23046e6e775be268be4310c62a)
>- 
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
>(93cc34cf8393f969087cd0fd6f577228c00170e9)
>
> View Diff 
>

Re: Review Request 63564: Migrate from findbugs to spotbugs

2017-11-05 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63564/#review190109
---



Master (d101655) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 5, 2017, 10:42 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63564/
> ---
> 
> (Updated Nov. 5, 2017, 10:42 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Findbugs [1] is no longer developed and replaced by spotbugs [2]
> as mostly a drop-in replacement.
> 
> [1] https://github.com/findbugsproject/findbugs
> [2] 
> https://mailman.cs.umd.edu/pipermail/findbugs-discuss/2017-September/004383.html
> 
> 
> Diffs
> -
> 
>   build.gradle 26051ac9267060606a5a4e05a1ac432c1ff4c79b 
>   config/findbugs/excludeFilter.xml 4d5b36f0c9ae9312ba6afdc6f0b4a42ab0c2dc2b 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferOrderBuilder.java 
> 2676da0a4aba3ff4afc7801dfd8f9d16918d87ff 
> 
> 
> Diff: https://reviews.apache.org/r/63564/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 63564: Migrate from findbugs to spotbugs

2017-11-05 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63564/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Findbugs [1] is no longer developed and replaced by spotbugs [2]
as mostly a drop-in replacement.

[1] https://github.com/findbugsproject/findbugs
[2] 
https://mailman.cs.umd.edu/pipermail/findbugs-discuss/2017-September/004383.html


Diffs
-

  build.gradle 26051ac9267060606a5a4e05a1ac432c1ff4c79b 
  config/findbugs/excludeFilter.xml 4d5b36f0c9ae9312ba6afdc6f0b4a42ab0c2dc2b 
  src/main/java/org/apache/aurora/scheduler/offers/OfferOrderBuilder.java 
2676da0a4aba3ff4afc7801dfd8f9d16918d87ff 


Diff: https://reviews.apache.org/r/63564/diff/1/


Testing
---


Thanks,

Stephan Erb