Re: Review Request 33105: Return Iterable from TaskStore.fetchTasks to allow for streaming.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33105/#review79809 --- Master (eb9e408) is red with this patch. ./build-support/jenkins/build.sh :check :build :api:assemble :api:compileTestJava UP-TO-DATE :api:processTestResources UP-TO-DATE :api:testClasses UP-TO-DATE :api:test UP-TO-DATE :api:check UP-TO-DATE :api:build :buildSrc:compileJava UP-TO-DATE :buildSrc:processResources UP-TO-DATE :buildSrc:classes UP-TO-DATE :buildSrc:jar :buildSrc:assemble :buildSrc:compileTestJava UP-TO-DATE :buildSrc:processTestResources UP-TO-DATE :buildSrc:testClasses UP-TO-DATE :buildSrc:test UP-TO-DATE :buildSrc:check UP-TO-DATE :buildSrc:build BUILD SUCCESSFUL Total time: 4 mins 7.27 secs + export PIP_DEFAULT_TIMEOUT=60 + PIP_DEFAULT_TIMEOUT=60 + mkdir -p third_party + pip install -d third_party -r /dev/fd/63 ++ grep -v mesos.native 3rdparty/python/requirements.txt Downloading/unpacking bottle==0.11.6 (from -r /dev/fd/63 (line 1)) Saved ./third_party/bottle-0.11.6-py2.py3-none-any.whl Downloading/unpacking CherryPy==3.6.0 (from -r /dev/fd/63 (line 2)) pip can't proceed with requirement 'CherryPy==3.6.0 (from -r /dev/fd/63 (line 2))' due to a pre-existing build directory. location: /tmp/user/2395/pip_build_jenkins/CherryPy This is likely due to a previous installation that failed. pip is being responsible and not assuming it can delete this. Please delete it and try again. Storing debug log for failure in /home/jenkins/.pip/pip.log I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On April 11, 2015, 6:22 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33105/ --- (Updated April 11, 2015, 6:22 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- This allows the store implementation to stream if it wishes, which we might want to take advantage of when the store is backed by a database. One thing worth noting is that this change is a good example of why using wide types at call sites is important. There were many callers of TaskStore.fetchTasks that were already assigning as `Iterable`, and they were immune to this refactor. Diffs - src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java ce87344dc18818faa7a1a0298143dc81fff7 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 1da35c05fb22c8fa0227a91df6a19f1b8f1aae92 src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 3bb80ec99ed1f5c1d87edb59f3c9502ab6f7c706 src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 0cf7fb40e5640d0ad07a7fc46c57548a3a385872 src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 985a3196ad809c7ccf30ba87a1f10cc3dacd5f49 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 3b5dcf819228297b3840cb01788c3085759f3c4a src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java ed82ae99f23d5a7f1634261205cbe5339fe4cec8 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 09be4dc8d6318ccfdf10397585ef7989221afd7f src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java b6a7b4aca841025c790f4b282f0490ff5bb23b2f src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java a8e3b14b3f8147f60871f9dfa84616425636e10a src/main/java/org/apache/aurora/scheduler/storage/Storage.java 6180a36255253542197234ec610eea01366135bc src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java b76c937281971a505db4b352b80cbb7ccfcafcca src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 38764e5e7484e2fe152460ac7920be9a5799b85d src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 2102adb3844fc1501ff9d672a2db78a69513231b src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 7aef1ca786fea521256f69f6a9e7a978649a7195 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java b7d3874e9f597d93c9f623773a3a0289c2b76d6d src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java c5643d9d99fc46d55fd6c48161230139fb7f12b8 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 88c0163170ebc25995d9ef8b1543335a4322bb8e src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java bcd1b4e854f5ea227268c73156bc97c7c937c1de src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 281f4e02650727aa5d0a35a09dcf0eb823ad1b50
Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated April 11, 2015, 11:52 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1275 https://issues.apache.org/jira/browse/AURORA-1275 Repository: aurora Description --- Only perform escalation wait when http teardown signal could be dispatched Diffs - src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021 src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50 src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 Diff: https://reviews.apache.org/r/32889/diff/ Testing --- ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster. Thanks, Stephan Erb
Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched
On April 10, 2015, 7:59 p.m., Zameer Manji wrote: src/test/python/apache/aurora/executor/test_thermos_task_runner.py, line 213 https://reviews.apache.org/r/32889/diff/1/?file=916618#file916618line213 Patching private methods for testing is a smell and it hinders refactoring. Please instead pass a mock clock to the ThermosTaskRunner constructor and check if the sleep method was called with ESCALATION_WAIT. Done. The rest of the class requires a working clock. I therefore ended up using a wrapper around `time` instead of a pure mock. - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review79718 --- On April 11, 2015, 11:52 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated April 11, 2015, 11:52 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1275 https://issues.apache.org/jira/browse/AURORA-1275 Repository: aurora Description --- Only perform escalation wait when http teardown signal could be dispatched Diffs - src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021 src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50 src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 Diff: https://reviews.apache.org/r/32889/diff/ Testing --- ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster. Thanks, Stephan Erb
Review Request 33103: Skip known flaky tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/ --- Review request for Aurora, Joshua Cohen and Brian Wickman. Repository: aurora Description --- We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage. Diffs - src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8 src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1 Diff: https://reviews.apache.org/r/33103/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review79817 --- Ship it! Master (eb9e408) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On April 11, 2015, 9:52 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated April 11, 2015, 9:52 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1275 https://issues.apache.org/jira/browse/AURORA-1275 Repository: aurora Description --- Only perform escalation wait when http teardown signal could be dispatched Diffs - src/main/python/apache/aurora/executor/thermos_task_runner.py 505a1e69ebfe1bd2fa74623063cb923ecff8a021 src/test/python/apache/aurora/executor/BUILD 013f056d2e131ae8077f0fcc542a340195a90e50 src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 Diff: https://reviews.apache.org/r/32889/diff/ Testing --- ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster. Thanks, Stephan Erb
