Re: Review Request 33106: Simplify AttributeAggregate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33106/#review79986 --- Ship it! Master (9aab87f) is green with this patch. ./build-suppo

Re: Review Request 33106: Simplify AttributeAggregate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33106/ --- (Updated April 14, 2015, 4 a.m.) Review request for Aurora and Maxim Khutornenk

Re: Review Request 32907: Generalizing preemption reservation pool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/#review79976 --- Ship it! Master (9aab87f) is green with this patch. ./build-suppo

Re: Review Request 32907: Generalizing preemption reservation pool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/ --- (Updated April 14, 2015, 1:09 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 32907: Generalizing preemption reservation pool.

> On April 9, 2015, 3:06 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, lines > > 251-252 > > > > > > Does this fail if the pending task was deleted? It's probably fi

Re: Review Request 33105: Return Iterable from TaskStore.fetchTasks to allow for streaming.

> On April 13, 2015, 11:06 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java, > > lines 149-152 > > > > > > Inline this as FluentIterable.from(...).first() `firs

Re: Review Request 33106: Simplify AttributeAggregate.

> On April 13, 2015, 10:59 p.m., Maxim Khutornenko wrote: > > The way I read these benchmark results peformance drops for all but two use > > cases by 20-70%. That's quite a big hit to our baseline with unclear > > motivation. I don't necessarily find the complexity reduction gain > > worthwhi

Re: Review Request 33105: Return Iterable from TaskStore.fetchTasks to allow for streaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33105/#review79962 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/Reschedul

Re: Review Request 33106: Simplify AttributeAggregate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33106/#review79963 --- The way I read these benchmark results peformance drops for all but

Re: Review Request 33105: Return Iterable from TaskStore.fetchTasks to allow for streaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33105/#review79960 --- Ship it! Ship It! - Maxim Khutornenko On April 11, 2015, 6:22 p.

Re: Review Request 33103: Skip known flaky tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/#review79934 --- Ship it! Master (eb9e408) is green with this patch. ./build-suppo

Re: Review Request 33103: Skip known flaky tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/#review79931 --- Ship it! Ship It! - Joe Smith On April 13, 2015, 12:44 p.m., Bil

Re: Review Request 33103: Skip known flaky tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/ --- (Updated April 13, 2015, 7:44 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 33103: Skip known flaky tests.

> On April 13, 2015, 3:32 p.m., Brian Wickman wrote: > > Actually could you also mark test_integration_quitquitquit as well? I was > > trying to address it in https://reviews.apache.org/r/32221/diff/# but don't > > feel particularly confident about that approach. Done. - Bill

Re: Review Request 33103: Skip known flaky tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/#review79908 --- Ship it! Ship It! - Joshua Cohen On April 11, 2015, 5:16 p.m., B

Re: Review Request 33103: Skip known flaky tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/#review79882 --- Actually could you also mark test_integration_quitquitquit as well?

Re: Review Request 33103: Skip known flaky tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/#review79881 --- Ship it! Ship It! - Brian Wickman On April 11, 2015, 5:16 p.m.,