Re: Review Request 33456: Adding logging threadpool executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/#review81725 --- src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java

Re: Review Request 33537: Document Aurora security features.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81722 --- Overall LGTM. Can you link to this page from

Review Request 33600: Extract an abstract base test for TaskStore implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33600/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 33537: Document Aurora security features.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81751 --- Ship it! Master (297c0eb) is green with this patch.

Re: Review Request 33243: Use explicit status update acknowledgements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/ --- (Updated April 27, 2015, 10:44 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 33243: Use explicit status update acknowledgements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review81753 --- Ship it! Ship It! - Bill Farner On April 27, 2015, 11:14 p.m.,

Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.

On April 28, 2015, 12:37 a.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 243 https://reviews.apache.org/r/33458/diff/1/?file=940120#file940120line243 I'm not too fond of this, it points out that `BenchmarkSettings` is being used

Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.

On April 28, 2015, 12:37 a.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 243 https://reviews.apache.org/r/33458/diff/1/?file=940120#file940120line243 I'm not too fond of this, it points out that `BenchmarkSettings` is being used

Re: Review Request 33611: Add benchmarks for fetching tasks over the API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81763 --- This is as far as i went towards getting some basic performance

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review81765 --- Master (e9d723d) is red with this patch.

Re: Review Request 33243: Use explicit status update acknowledgements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review81747 --- Ship it! Master (94fe6c9) is green with this patch.

Re: Review Request 33243: Use explicit status update acknowledgements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/ --- (Updated April 27, 2015, 11:14 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 33243: Use explicit status update acknowledgements.

On April 27, 2015, 11:05 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java, line 51 https://reviews.apache.org/r/33243/diff/2/?file=943401#file943401line51 Remove `credentials.get()`, it will throw a NullPointerException in this

Re: Review Request 33537: Document Aurora security features.

On April 27, 2015, 12:52 p.m., Bill Farner wrote: Overall LGTM. Can you link to this page from `deploying-aurora-scheduler.md`? done. On April 27, 2015, 12:52 p.m., Bill Farner wrote: docs/security.md, line 5 https://reviews.apache.org/r/33537/diff/1/?file=941415#file941415line5

Re: Review Request 33537: Document Aurora security features.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81760 --- Ship it! docs/security.md

Review Request 33611: Add benchmarks for fetching tasks over the API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1283

Re: Review Request 33243: Use explicit status update acknowledgements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review81750 --- Ship it! Master (297c0eb) is green with this patch.