Review Request 33950: AURORA-1308 - 0.8.0 changelog contains wontfix and duplicate ticket references

2015-05-07 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33950/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1308

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33689/#review82916 --- Looks good overall. A few suggestions below.

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82944 --- Ship it! Master (27b5e25) is green with this patch.

Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-1239

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82942 --- src/main/python/apache/aurora/client/cli/update.py

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82956 --- This patch does not apply cleanly on master (9634d25), do you need

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 122 https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122 Suggest --wait-until for consistency with job create command. `--wait-until` accepts states,

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 122 https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122 Suggest --wait-until for consistency with job create command. Bill Farner wrote:

Re: Review Request 33962: Remove often-redundant Error executing command prefix from client output.

2015-05-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33962/#review82947 --- Ship it! Ship It! - Joshua Cohen On May 8, 2015, 12:16 a.m.,

Review Request 33962: Remove often-redundant Error executing command prefix from client output.

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33962/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs:

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 122 https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122 Suggest --wait-until for consistency with job create command. Bill Farner wrote:

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Zameer Manji
On May 7, 2015, 5:04 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 122 https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122 Suggest --wait-until for consistency with job create command. Bill Farner wrote:

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- (Updated May 8, 2015, 12:44 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- (Updated May 8, 2015, 1:04 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review82958 --- Ship it! src/main/python/apache/aurora/client/cli/update.py

Review Request 33969: Fix broken style test cases causing PEP302

2015-05-07 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33969/ --- Review request for Aurora, Kevin Sweeney, Bill Farner, and Zameer Manji. Bugs:

Re: Review Request 33969: Fix broken style test cases causing PEP302

2015-05-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33969/#review82975 --- Ship it! Master (018043a) is green with this patch.

Re: Review Request 33969: Fix broken style test cases causing PEP302

2015-05-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33969/#review82973 --- Ship it! Ship It! - Kevin Sweeney On May 7, 2015, 8:30 p.m.,

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review82980 --- Ship it! Master (8157181) is green with this patch.

Review Request 33967: AURORA-1312: Fix missing license headers in new files added since 0.7.0

2015-05-07 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33967/ --- Review request for Aurora. Repository: aurora Description ---

Re: Review Request 33967: AURORA-1312: Fix missing license headers in new files added since 0.7.0

2015-05-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33967/#review82971 --- Ship it! For git log consistency consider omitting the JIRA issue

Re: Review Request 33969: Fix broken style test cases causing PEP302

2015-05-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33969/#review82974 --- Ship it! Ship It! - Maxim Khutornenko On May 8, 2015, 3:30

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-07 Thread Steve Salevan
On May 4, 2015, 7:31 p.m., Bill Farner wrote: We've had success with using vagrant to serve as test beds and build environments for things like this [1]. Docker might be a boon here, as we can use that in ASF's jenkins. Don't hesitate to punt on this for now, as it's not a

Re: Review Request 33967: AURORA-1312: Fix missing license headers in new files added since 0.7.0

2015-05-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33967/#review82965 --- Ship it! Ship It! - Zameer Manji On May 7, 2015, 7:41 p.m.,

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-07 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated May 8, 2015, 5:08 a.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review82915 --- src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java

Re: Review Request 33955: Invoke pip as a python module rather than directly.

2015-05-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33955/#review82906 --- Ship it! Master (fef7194) is green with this patch.

Re: Review Request 33950: Fix 0.8.0-RC0 issues raised due to changelog containing wontfix and duplicate ticket references

2015-05-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33950/#review82902 --- Ship it! Ship It! - Kevin Sweeney On May 7, 2015, 1:56 p.m.,

Re: Review Request 33854: Fix and enhance RC verification script.

2015-05-07 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33854/#review82837 --- build-support/release/verify-release-candidate