Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32973/#review87442 --- Master (fab6637) is red with this patch. ./build-support/jenkins/build.sh Using cached twitter.common.process-0.3.0.tar.gz Collecting twitter.common.log==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.log-0.3.0.tar.gz Collecting twitter.common.util==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.util-0.3.0.tar.gz Collecting twitter.common.collections==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.collections-0.3.0.tar.gz Collecting smmap>=0.8.5 (from gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0) Using cached smmap-0.9.0.tar.gz Collecting twitter.common.string==0.3.0 (from twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.string-0.3.0.tar.gz Collecting twitter.common.options==0.3.0 (from twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.options-0.3.0.tar.gz Collecting twitter.common.dirutil==0.3.0 (from twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.dirutil-0.3.0.tar.gz Collecting twitter.common.contextutil==0.3.0 (from twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.contextutil-0.3.0.tar.gz Collecting twitter.common.lang==0.3.0 (from twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.lang-0.3.0.tar.gz Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython, twitter.common.lang, twitter.common.string, twitter.common.process, twitter.common.options, twitter.common.dirutil, twitter.common.log, twitter.common.contextutil, twitter.common.util, twitter.common.collections, twitter.common.app, twitter.checkstyle Running setup.py install for pyflakes Running setup.py install for pep8 Running setup.py install for smmap Running setup.py install for gitdb Running setup.py install for GitPython Running setup.py install for twitter.common.lang Running setup.py install for twitter.common.string Running setup.py install for twitter.common.process Running setup.py install for twitter.common.options Running setup.py install for twitter.common.dirutil Running setup.py install for twitter.common.log Running setup.py install for twitter.common.contextutil Running setup.py install for twitter.common.util Running setup.py install for twitter.common.collections Running setup.py install for twitter.common.app Running setup.py install for twitter.checkstyle Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0 twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0 twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 twitter.common.options-0.3.0 twitter.common.process-0.3.0 twitter.common.string-0.3.0 twitter.common.util-0.3.0 T200:ERROR src/main/python/apache/aurora/executor/thermos_task_runner.py:122 Line has trailing whitespace. |self._task.graceful_shutdown_endpoint().get(), I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 10, 2015, 6:35 p.m., Brian Brazil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32973/ > --- > > (Updated June 10, 2015, 6:35 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-1257 > https://issues.apache.org/jira/browse/AURORA-1257 > > > Repository: aurora > > > Description > --- > > Fix name of test for sigterm being ignored. > > Based on > https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34 > > > Diffs > - > > docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e > src/main/python/apache/aurora/common/http_signaler.py > 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a > src/main/python/apache/aurora/executor/thermos_task_runner.py > 837ad5c55b4a02215a8d509c211e80529536f705 > src/main/python/apache/thermos/config/schema_base.py > f9143cc1b83143d6147f59d90c79435d055d0518 > src/test/python/apache/aurora/common/test_http_signaler.py > c6a21708eb997f213f4cca038891a84f6c5218d4 > src/test/python/apache/aurora/executor/test_thermos_task_runner.py > 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf > > Diff: https://reviews.
Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32973/ --- (Updated June 10, 2015, 6:35 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- Merge and handle conflicts, clean up to make the change simpler. Bugs: AURORA-1257 https://issues.apache.org/jira/browse/AURORA-1257 Repository: aurora Description (updated) --- Fix name of test for sigterm being ignored. Based on https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34 Diffs (updated) - docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e src/main/python/apache/aurora/common/http_signaler.py 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a src/main/python/apache/aurora/executor/thermos_task_runner.py 837ad5c55b4a02215a8d509c211e80529536f705 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/test/python/apache/aurora/common/test_http_signaler.py c6a21708eb997f213f4cca038891a84f6c5218d4 src/test/python/apache/aurora/executor/test_thermos_task_runner.py 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf Diff: https://reviews.apache.org/r/32973/diff/ Testing (updated) --- Unittests and manually in vagrant cluster. Also verified that the flaky tests pass. Thanks, Brian Brazil
Re: Review Request 33433: Revert "Revert "Make health check configurable""
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33433/#review87417 --- On master now. Thanks! - Maxim Khutornenko On June 10, 2015, 9:03 a.m., Brian Brazil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33433/ > --- > > (Updated June 10, 2015, 9:03 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-316 > https://issues.apache.org/jira/browse/AURORA-316 > > > Repository: aurora > > > Description > --- > > This reverts commit d92de5d1862ca694fec3df4f85b8e33c4284dc71, which reverted > 27a602d2c9efdd1cd2591c9c754f086c04ad0eb9. The rollback was due to > AURORA-1268, a backwards incompatability in the configuration language, which > is now resolved and released in Aurora 0.8.0. > > > Diffs > - > > docs/configuration-reference.md af332f27dfb88325d56a9694a3311eb4fd9c320f > src/main/python/apache/aurora/common/http_signaler.py > e3e819d60c28c972a1f8ccdfbfeb03d9e6ca345d > src/main/python/apache/aurora/config/schema/base.py > a87524a8b3ad5aa0e337e0a0028cecb85865b4e6 > src/main/python/apache/aurora/executor/common/health_checker.py > cfc29c3164837493e4ddfb8314bb6999ddaa0c91 > src/test/python/apache/aurora/common/test_http_signaler.py > f5f8419b42a5484dac78d5a3b5033a7d74b7aa73 > src/test/python/apache/aurora/executor/common/test_health_checker.py > 1b4423a1eb95cc950206a355fa657c8082c8d93f > > Diff: https://reviews.apache.org/r/33433/diff/ > > > Testing > --- > > Unittests run. > > > Thanks, > > Brian Brazil > >
Re: Review Request 33433: Revert "Revert "Make health check configurable""
> On June 9, 2015, 10:08 p.m., Maxim Khutornenko wrote: > > Please, update RB description to clearly state the history (e.g. > > commit->revert->re-apply). Updated. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33433/#review87301 --- On June 10, 2015, 9:03 a.m., Brian Brazil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33433/ > --- > > (Updated June 10, 2015, 9:03 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-316 > https://issues.apache.org/jira/browse/AURORA-316 > > > Repository: aurora > > > Description > --- > > This reverts commit d92de5d1862ca694fec3df4f85b8e33c4284dc71, which reverted > 27a602d2c9efdd1cd2591c9c754f086c04ad0eb9. The rollback was due to > AURORA-1268, a backwards incompatability in the configuration language, which > is now resolved and released in Aurora 0.8.0. > > > Diffs > - > > docs/configuration-reference.md af332f27dfb88325d56a9694a3311eb4fd9c320f > src/main/python/apache/aurora/common/http_signaler.py > e3e819d60c28c972a1f8ccdfbfeb03d9e6ca345d > src/main/python/apache/aurora/config/schema/base.py > a87524a8b3ad5aa0e337e0a0028cecb85865b4e6 > src/main/python/apache/aurora/executor/common/health_checker.py > cfc29c3164837493e4ddfb8314bb6999ddaa0c91 > src/test/python/apache/aurora/common/test_http_signaler.py > f5f8419b42a5484dac78d5a3b5033a7d74b7aa73 > src/test/python/apache/aurora/executor/common/test_health_checker.py > 1b4423a1eb95cc950206a355fa657c8082c8d93f > > Diff: https://reviews.apache.org/r/33433/diff/ > > > Testing > --- > > Unittests run. > > > Thanks, > > Brian Brazil > >
Re: Review Request 33433: Revert "Revert "Make health check configurable""
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33433/ --- (Updated June 10, 2015, 9:03 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-316 https://issues.apache.org/jira/browse/AURORA-316 Repository: aurora Description (updated) --- This reverts commit d92de5d1862ca694fec3df4f85b8e33c4284dc71, which reverted 27a602d2c9efdd1cd2591c9c754f086c04ad0eb9. The rollback was due to AURORA-1268, a backwards incompatability in the configuration language, which is now resolved and released in Aurora 0.8.0. Diffs - docs/configuration-reference.md af332f27dfb88325d56a9694a3311eb4fd9c320f src/main/python/apache/aurora/common/http_signaler.py e3e819d60c28c972a1f8ccdfbfeb03d9e6ca345d src/main/python/apache/aurora/config/schema/base.py a87524a8b3ad5aa0e337e0a0028cecb85865b4e6 src/main/python/apache/aurora/executor/common/health_checker.py cfc29c3164837493e4ddfb8314bb6999ddaa0c91 src/test/python/apache/aurora/common/test_http_signaler.py f5f8419b42a5484dac78d5a3b5033a7d74b7aa73 src/test/python/apache/aurora/executor/common/test_health_checker.py 1b4423a1eb95cc950206a355fa657c8082c8d93f Diff: https://reviews.apache.org/r/33433/diff/ Testing --- Unittests run. Thanks, Brian Brazil
