Re: Review Request 35498: Compute SLA stats for non-prod jobs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88261 --- src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java (lines 73 - 87) https://reviews.apache.org/r/35498/#comment140683 This suggests the current AlgorithmType model is not very flexible. How would you feel about moving the environment part from the AlgorithmType into MetricCalculator? That will allow keeping AlgorithmType env-agnostic and will make adding new env-based metrics much easier. The AlgorithmType would only have vanilla metric names (e.g. mtta_ms, 99.00 and etc.). The MetricCalculator would then pass nonprod into `runAlgorithms()` to get appended to the metric name (e.g. `sla_job_key_mtta_ms_nonprod`). This will change the existing nonprod metric names a bit but will let us add new metrics for various task subsets without ever touching the SlaAlgorithm. - Maxim Khutornenko On June 16, 2015, 9:07 a.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 16, 2015, 9:07 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-1350 https://issues.apache.org/jira/browse/AURORA-1350 Repository: aurora Description --- Compute SLA stats for non-prod jobs This is a first iteration closely following the design proposal of Maxim as posted on the mailinglist. Feedback welcome. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603 src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 64e986fb2e0f955dd4a9c7824eac9494728bf24e src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164 src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d Diff: https://reviews.apache.org/r/35498/diff/ Testing --- `./gradlew -Pq build` and a manual verification in Vagrant. Thanks, Stephan Erb
Review Request 35580: Fix symlink duplicates from MesosPathDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35580/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1353 https://issues.apache.org/jira/browse/AURORA-1353 Repository: aurora Description --- Fix symlink duplicates from MesosPathDetector. Also added thread ids to TaskResourceMonitor for better /threads debugging. Diffs - src/main/python/apache/aurora/executor/common/path_detector.py ba85d5c969d3f1f62d3f898bed83d930e2994bd2 src/main/python/apache/thermos/monitoring/resource.py c1d7804fe0896d8b92aa565d6dd5295fa58efd3f src/test/python/apache/aurora/executor/common/test_path_detector.py 86460bb6499596964124bec85d74ca9dba7d2c7c src/test/python/apache/thermos/monitoring/test_resource.py a7ab360d7bc0022b115b9059b16d76b8923d5e23 Diff: https://reviews.apache.org/r/35580/diff/ Testing --- Verified we realpath the paths prior to returning from path detector. Thanks, Brian Wickman
Re: Review Request 35580: Fix symlink duplicates from MesosPathDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35580/#review88278 --- Ship it! +1 on test coverage too - Joe Smith On June 17, 2015, 2:17 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35580/ --- (Updated June 17, 2015, 2:17 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1353 https://issues.apache.org/jira/browse/AURORA-1353 Repository: aurora Description --- Fix symlink duplicates from MesosPathDetector. Also added thread ids to TaskResourceMonitor for better /threads debugging. Diffs - src/main/python/apache/aurora/executor/common/path_detector.py ba85d5c969d3f1f62d3f898bed83d930e2994bd2 src/main/python/apache/thermos/monitoring/resource.py c1d7804fe0896d8b92aa565d6dd5295fa58efd3f src/test/python/apache/aurora/executor/common/test_path_detector.py 86460bb6499596964124bec85d74ca9dba7d2c7c src/test/python/apache/thermos/monitoring/test_resource.py a7ab360d7bc0022b115b9059b16d76b8923d5e23 Diff: https://reviews.apache.org/r/35580/diff/ Testing --- Verified we realpath the paths prior to returning from path detector. Thanks, Brian Wickman
Re: Review Request 35580: Fix symlink duplicates from MesosPathDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35580/#review88281 --- Ship it! Ship It! - Maxim Khutornenko On June 17, 2015, 9:17 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35580/ --- (Updated June 17, 2015, 9:17 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1353 https://issues.apache.org/jira/browse/AURORA-1353 Repository: aurora Description --- Fix symlink duplicates from MesosPathDetector. Also added thread ids to TaskResourceMonitor for better /threads debugging. Diffs - src/main/python/apache/aurora/executor/common/path_detector.py ba85d5c969d3f1f62d3f898bed83d930e2994bd2 src/main/python/apache/thermos/monitoring/resource.py c1d7804fe0896d8b92aa565d6dd5295fa58efd3f src/test/python/apache/aurora/executor/common/test_path_detector.py 86460bb6499596964124bec85d74ca9dba7d2c7c src/test/python/apache/thermos/monitoring/test_resource.py a7ab360d7bc0022b115b9059b16d76b8923d5e23 Diff: https://reviews.apache.org/r/35580/diff/ Testing --- Verified we realpath the paths prior to returning from path detector. Thanks, Brian Wickman
Re: Review Request 35587: Suppress task reconciliation status update logging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/#review88325 --- Ship it! Master (af7e1a7) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On June 18, 2015, 1:02 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/ --- (Updated June 18, 2015, 1:02 a.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Suppress task reconciliation status update logging. Diffs - src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java f233d5a181bb1f43fbbfe657dbda2cf975aa6895 src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java f0f9ac392973a276028aee3e06517a6e6d960bb6 Diff: https://reviews.apache.org/r/35587/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
