Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88699 --- Ship it! Master (d240926) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 21, 2015, 4:39 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 21, 2015, 4:34 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-21 Thread Stephan Erb
> On June 19, 2015, 8:12 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java, line 65 > > > > > > Since it backs enum, you may want to add something like: > > > > ".