---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-1334
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/
---
(Updated June 23, 2015, 2:24 p.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review89007
---
Ship it!
LGTM so long as end-to-end tests come up green.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/#review89008
---
LGTM overall, will give a ship once the rebase comes out green.
On June 23, 2015, 5:55 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line
167
https://reviews.apache.org/r/35761/diff/1/?file=990578#file990578line167
Accessing the Impl suggests an encapsulagion problem. Can you use the
On June 23, 2015, 6:58 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java,
line 133
https://reviews.apache.org/r/35793/diff/2/?file=990668#file990668line133
Any particular reason you've settled on an explicit removal call as
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/
---
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-1298
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/
---
(Updated June 23, 2015, 6:28 p.m.)
Review request for Aurora and Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/#review89026
---
Ship it!
Master (68c4620) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review89016
---
Ship it!
Master (2df2db9) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/#review89023
---
Ship it!
Master (68c4620) is green with this patch.
On June 23, 2015, 7:46 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
line 242
https://reviews.apache.org/r/35761/diff/2/?file=990689#file990689line242
s/manager/handler/
Done.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35498/#review88946
---
Ship it!
Master (2df2db9) is green with this patch.
On June 24, 2015, 12:31 a.m., Brian Wickman wrote:
slightly overzealous deleting. the thermos gc stuff should still be part
of the thermos toolchain.
Should not we rather rely on task reconciliation to do any cleanup instead?
Force GCing a task does not seem to be a critical feature (in
On June 24, 2015, 12:31 a.m., Brian Wickman wrote:
slightly overzealous deleting. the thermos gc stuff should still be part
of the thermos toolchain.
Maxim Khutornenko wrote:
Should not we rather rely on task reconciliation to do any cleanup
instead? Force GCing a task does not
On June 23, 2015, 8:12 p.m., Maxim Khutornenko wrote:
Discussed with Bill offline and it seems like having an offline periodic
async GC processor would be a better long term solution. It would allow us
to handle all cleanup in a single place but more importantly will remove
the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89108
---
Ship it!
Master (4b8c34c) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/
---
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/
---
Review request for Aurora, Bill Farner and Brian Wickman.
Bugs: AURORA-1333
19 matches
Mail list logo
