Re: Review Request 36289: Custom executor support for Scheduler

2015-08-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review95689 --- Master (22f9cbb) is red with this patch.

Re: Review Request 36289: Custom executor support for Scheduler

2015-08-18 Thread Renan DelValle
On Aug. 18, 2015, 3:06 a.m., Aurora ReviewBot wrote: Master (22f9cbb) is red with this patch. ./build-support/jenkins/build.sh :api:checkPython :api:generateThriftEntitiesJava :api:classesThriftEntities :api:compileJava UP-TO-DATE :api:generateThriftResources

Re: Review Request 36289: Custom executor support for Scheduler

2015-08-18 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/ --- (Updated Aug. 18, 2015, 6:10 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 37560: Adding TierManager initial implementation.

2015-08-18 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/#review95750 --- src/main/java/org/apache/aurora/scheduler/TierInfo.java (line 27)

Re: Review Request 37560: Adding TierManager initial implementation.

2015-08-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/ --- (Updated Aug. 18, 2015, 6:23 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 37560: Adding TierManager initial implementation.

2015-08-18 Thread Stephan Erb
On Aug. 18, 2015, 8:08 p.m., Stephan Erb wrote: src/main/java/org/apache/aurora/scheduler/TierInfo.java, line 27 https://reviews.apache.org/r/37560/diff/2/?file=1043194#file1043194line27 For better readability, how about using an enum? Maxim Khutornenko wrote: Not sure I

Re: Review Request 37560: Adding TierManager initial implementation.

2015-08-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/#review95748 --- Master (22f9cbb) is red with this patch.

Re: Review Request 37560: Adding TierManager initial implementation.

2015-08-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/#review95772 --- Ship it! Master (22f9cbb) is green with this patch.

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-18 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 18, 2015, 9:23 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95775 --- Ship it! Looks much better with the services change, thanks!

Re: Review Request 37593: Modifying resource counters to support revocable resources.

2015-08-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37593/#review95814 --- Ship it! Master (f5025f3) is green with this patch.