---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37847/
---
Review request for Aurora, Joshua Cohen and Bill Farner.
Repository: aurora
On Aug. 27, 2015, 5:23 p.m., Bill Farner wrote:
src/test/resources/org/apache/aurora/scheduler/tiers-example.json, line 2
https://reviews.apache.org/r/37825/diff/1/?file=103#file103line2
The added layer here seems slightly weird, but i can see why it's
useful - you can
On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote:
src/test/resources/org/apache/aurora/scheduler/tiers-example.json, line 2
https://reviews.apache.org/r/37825/diff/1/?file=103#file103line2
The added layer here seems slightly weird, but i can see why it's
useful - you can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/#review96703
---
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37847/#review96710
---
Should this be a part of an epic to rename all internal occurences?
On Aug. 27, 2015, 10:46 a.m., Maxim Khutornenko wrote:
Should this be a part of an epic to rename all internal occurences? Quick
check shows up plenty of mentiones in docs and public (e.g. thrift) APIs. I
think consistency is important and we should not lose track of other work
in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37847/
---
(Updated Aug. 27, 2015, 11:01 a.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37847/#review96725
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 27, 2015, 6:01 p.m.,
On Aug. 26, 2015, 3:27 p.m., Kevin Sweeney wrote:
examples/vagrant/executors-config-new.json, line 18
https://reviews.apache.org/r/37818/diff/1/?file=1055421#file1055421line18
this isn't a global property - can it be pushed into a custom
configuration object?
Renan DelValle
On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote:
src/test/resources/org/apache/aurora/scheduler/tiers-example.json, line 2
https://reviews.apache.org/r/37825/diff/1/?file=103#file103line2
The added layer here seems slightly weird, but i can see why it's
useful - you can
On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/TierManager.java, line 63
https://reviews.apache.org/r/37825/diff/1/?file=101#file101line63
Consider moving the parsing up a layer, in the module. That way we can
report earlier if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/#review96714
---
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/#review96730
---
Ship it!
Master (06ddaad) is green with this patch.
On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 70
https://reviews.apache.org/r/37825/diff/1/?file=100#file100line70
+@CanRead
That will cause loading to fail when the argument is null.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37818/#review96733
---
Ship it!
Master (06ddaad) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37851/
---
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Bugs:
On Aug. 27, 2015, 5:23 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/TierManager.java, line 63
https://reviews.apache.org/r/37825/diff/1/?file=101#file101line63
Consider moving the parsing up a layer, in the module. That way we can
report earlier if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/
---
(Updated Aug. 27, 2015, 9:17 p.m.)
Review request for Aurora, Bill Farner and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37855/
---
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/#review96771
---
Ship it!
Master (06ddaad) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37847/#review96774
---
Master (06ddaad) is red with this patch.
On Aug. 27, 2015, 5:54 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 117
https://reviews.apache.org/r/37825/diff/1/?file=100#file100line117
I think this function should also parse the data into MapString,
TierInfo. The
On Aug. 27, 2015, 10:54 a.m., Zameer Manji wrote:
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java, line 26
https://reviews.apache.org/r/37825/diff/1/?file=102#file102line26
Please add a test for the config for having keys that are not expected.
I would
On Aug. 27, 2015, 5:54 p.m., Zameer Manji wrote:
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java, line 26
https://reviews.apache.org/r/37825/diff/1/?file=102#file102line26
Please add a test for the config for having keys that are not expected.
I would
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37855/#review96772
---
Master (06ddaad) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37859/
---
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1454 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37851/#review96777
---
Ship it!
Master (06ddaad) is green with this patch.
On Aug. 27, 2015, 3:55 p.m., Kevin Sweeney wrote:
specs/rpm/aurora.spec, line 100
https://reviews.apache.org/r/37860/diff/1/?file=1056661#file1056661line100
Can you explain the rationale behind this change - unpinned mesos runs
the risk of not working with the executor it was
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37859/#review96781
---
Master (06ddaad) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37860/
---
Review request for Aurora and Kevin Sweeney.
Repository: aurora-packaging
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37860/#review96782
---
specs/rpm/aurora.spec (line 100)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37861/#review96786
---
Ship it!
Ship It!
- Kevin Sweeney
On Aug. 27, 2015, 4:05 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37861/#review96785
---
Ship it!
Ship It!
- Kevin Sweeney
On Aug. 27, 2015, 4:05 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37862/#review96787
---
Ship it!
Ship It!
- Kevin Sweeney
On Aug. 27, 2015, 4:08 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37862/
---
Review request for Aurora and Kevin Sweeney.
Repository: aurora-packaging
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37872/
---
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
36 matches
Mail list logo
