Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 06ee83335bde7053227de0bd516ca8ce24f8ce55 src/main/java/org/apache/aurora/scheduler/http/Slaves.java b64e18c4d5278e6cdb2e480043a45e6ec4f87484 src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
Re: Review Request 37825: Adding minimal implementation of the external tier config.
On Aug. 27, 2015, 5:23 p.m., Bill Farner wrote:
src/test/resources/org/apache/aurora/scheduler/tiers-example.json, line 2
https://reviews.apache.org/r/37825/diff/1/?file=103#file103line2
The added layer here seems slightly weird, but i can see why it's
useful - you can add other fields to the config in the future. I don't
necessarily expect you to change anything, but i'm curious if that was your
intention.
Zameer Manji wrote:
This also seems weird to me. I think a good schema for the file would be
{ tier name: tier properties }. Maybe this requires a mailing list
discussion?
Bill was on target with his guess. The extra layer does not add much overhead
and at the same time does not prevent adding extra metadata in future. This is
the same logical structuring proposed in the design doc.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/#review96703
---
On Aug. 27, 2015, 1:07 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/
---
(Updated Aug. 27, 2015, 1:07 a.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1437
https://issues.apache.org/jira/browse/AURORA-1437
Repository: aurora
Description
---
The external config file is optional for now as tiers are not fully defined
yet.
Diffs
-
examples/vagrant/upstart/aurora-scheduler-kerberos.conf
744b4a35c61e749734e222b3d4cbd296927665aa
examples/vagrant/upstart/aurora-scheduler.conf
789a3a0315e8530880999432aa9b1e7d0f57d1ff
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca
src/main/java/org/apache/aurora/scheduler/TierManager.java
652afece17a7eb09b0ca68066707b1b8fbf024f0
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java
eb0207114e1b93968cb65832f154a9cd3bc3232e
src/test/resources/org/apache/aurora/scheduler/tiers-example.json
PRE-CREATION
Diff: https://reviews.apache.org/r/37825/diff/
Testing
---
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 37825: Adding minimal implementation of the external tier config.
On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote:
src/test/resources/org/apache/aurora/scheduler/tiers-example.json, line 2
https://reviews.apache.org/r/37825/diff/1/?file=103#file103line2
The added layer here seems slightly weird, but i can see why it's
useful - you can add other fields to the config in the future. I don't
necessarily expect you to change anything, but i'm curious if that was your
intention.
Zameer Manji wrote:
This also seems weird to me. I think a good schema for the file would be
{ tier name: tier properties }. Maybe this requires a mailing list
discussion?
Maxim Khutornenko wrote:
Bill was on target with his guess. The extra layer does not add much
overhead and at the same time does not prevent adding extra metadata in
future. This is the same logical structuring proposed in the design doc.
I'm all for discussion on the mailing list, but i think this is minutia that is
safe to define here and avoid the overhead of outreach/waiting.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/#review96703
---
On Aug. 26, 2015, 6:07 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/
---
(Updated Aug. 26, 2015, 6:07 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1437
https://issues.apache.org/jira/browse/AURORA-1437
Repository: aurora
Description
---
The external config file is optional for now as tiers are not fully defined
yet.
Diffs
-
examples/vagrant/upstart/aurora-scheduler-kerberos.conf
744b4a35c61e749734e222b3d4cbd296927665aa
examples/vagrant/upstart/aurora-scheduler.conf
789a3a0315e8530880999432aa9b1e7d0f57d1ff
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca
src/main/java/org/apache/aurora/scheduler/TierManager.java
652afece17a7eb09b0ca68066707b1b8fbf024f0
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java
eb0207114e1b93968cb65832f154a9cd3bc3232e
src/test/resources/org/apache/aurora/scheduler/tiers-example.json
PRE-CREATION
Diff: https://reviews.apache.org/r/37825/diff/
Testing
---
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 37825: Adding minimal implementation of the external tier config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96703 --- src/main/java/org/apache/aurora/scheduler/SchedulerModule.java (line 70) https://reviews.apache.org/r/37825/#comment152332 +@CanRead src/main/java/org/apache/aurora/scheduler/TierManager.java (line 62) https://reviews.apache.org/r/37825/#comment152333 Consider moving the parsing up a layer, in the module. That way we can report earlier if the file is malformed, and you can bind a specific type (without the annotation). This will also address another complaint, which is that the config file is being parsed every time we want to find the tier a task config belongs to. src/test/resources/org/apache/aurora/scheduler/tiers-example.json (line 2) https://reviews.apache.org/r/37825/#comment152334 The added layer here seems slightly weird, but i can see why it's useful - you can add other fields to the config in the future. I don't necessarily expect you to change anything, but i'm curious if that was your intention. - Bill Farner On Aug. 26, 2015, 6:07 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 26, 2015, 6:07 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/#review96710 --- Should this be a part of an epic to rename all internal occurences? Quick check shows up plenty of mentiones in docs and public (e.g. thrift) APIs. I think consistency is important and we should not lose track of other work in this area. - Maxim Khutornenko On Aug. 27, 2015, 5:37 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- (Updated Aug. 27, 2015, 5:37 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 06ee83335bde7053227de0bd516ca8ce24f8ce55 src/main/java/org/apache/aurora/scheduler/http/Slaves.java b64e18c4d5278e6cdb2e480043a45e6ec4f87484 src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
On Aug. 27, 2015, 10:46 a.m., Maxim Khutornenko wrote: Should this be a part of an epic to rename all internal occurences? Quick check shows up plenty of mentiones in docs and public (e.g. thrift) APIs. I think consistency is important and we should not lose track of other work in this area. This change was the result of a grep for the lowest-hanging fruit, but I restricted it to the `src/main` folder and didn't include `docs`. I can definitely include `docs` in a follow-up patch. Good call on the Epic - filed https://issues.apache.org/jira/browse/AURORA-1448 - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/#review96710 --- On Aug. 27, 2015, 10:37 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- (Updated Aug. 27, 2015, 10:37 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 06ee83335bde7053227de0bd516ca8ce24f8ce55 src/main/java/org/apache/aurora/scheduler/http/Slaves.java b64e18c4d5278e6cdb2e480043a45e6ec4f87484 src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- (Updated Aug. 27, 2015, 11:01 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes --- Add bug IDs Bugs: AURORA-1449 and AURORA-1450 https://issues.apache.org/jira/browse/AURORA-1449 https://issues.apache.org/jira/browse/AURORA-1450 Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 06ee83335bde7053227de0bd516ca8ce24f8ce55 src/main/java/org/apache/aurora/scheduler/http/Slaves.java b64e18c4d5278e6cdb2e480043a45e6ec4f87484 src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/#review96725 --- Ship it! Ship It! - Joshua Cohen On Aug. 27, 2015, 6:01 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- (Updated Aug. 27, 2015, 6:01 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1449 and AURORA-1450 https://issues.apache.org/jira/browse/AURORA-1449 https://issues.apache.org/jira/browse/AURORA-1450 Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 06ee83335bde7053227de0bd516ca8ce24f8ce55 src/main/java/org/apache/aurora/scheduler/http/Slaves.java b64e18c4d5278e6cdb2e480043a45e6ec4f87484 src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
Re: Review Request 37818: Moved executor settings configuration to loadable JSON
On Aug. 26, 2015, 3:27 p.m., Kevin Sweeney wrote: examples/vagrant/executors-config-new.json, line 18 https://reviews.apache.org/r/37818/diff/1/?file=1055421#file1055421line18 this isn't a global property - can it be pushed into a custom configuration object? Renan DelValle wrote: We can, but this change causes a ripple effect. If we push this into a custom schema, we have to provide a way of unpacking custom configuration object into useful mesos data fields or information usefol to the executor. We need to come to a decision on the best way of doing this if we go for it. Tangentially, as far as I can tell this is only used when building container volumes. As this is greenfield code I'm okay with a bit of a ripple - I'd much rather cluster operators have to write this config file once than change it as our design for it evolves. On Aug. 26, 2015, 3:27 p.m., Kevin Sweeney wrote: examples/vagrant/executors-config-new.json, line 19 https://reviews.apache.org/r/37818/diff/1/?file=1055421#file1055421line19 It would be ergnomically nice to default this to an empty list if it's left unset. Renan DelValle wrote: I'll see if there's a way of doing that. If you come across anything, let me know. A bit of Googling suggests that setting defaults in a default constructor works with GSON here. In fact it seems that just about any way you can think of doing it GSON supports defaults (confirmed myself here: https://gist.github.com/kevints/d1e26514468863e8c088). Setting defaults in an initializer works too - I suggest following the pattern in `ImmutableDefaultTest`, or `ImmutableInitializeOverrideTest` if you have a `@VisibleForTesting` constructor. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/#review96605 --- On Aug. 26, 2015, 3:19 p.m., Renan DelValle wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/ --- (Updated Aug. 26, 2015, 3:19 p.m.) Review request for Aurora. Repository: aurora Description --- This is the first stage in a series of patches to create support for custom executors. In an effort to expedite the review process, I have decided to break down my patch into multiple pieces that when/if commited won't break the trunk. This patch includes the ability to load configuration from a JSON file. A JSON example file is included in examples/vagrant/executors-config.json Command line arguments have been eliminated and moved over to the JSON file. GSON is leveraged and does most of the work with the aid of a few custom deserializers that were needed. Note that right now a global container mount that does not follow specification will cause the scheduler to detect the error an exit early. It is up for discussion if this is the desired behavior or if we should just ignore said mount. Diffs - examples/vagrant/executors-config-new.json PRE-CREATION examples/vagrant/executors-config.json PRE-CREATION examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 0c440b5cd5b939872c1ee05d048bf739bfa977cb src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java b3c913892248e4a9a8111412307463985f5ca97f src/test/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoaderTest.java PRE-CREATION src/test/resources/org/apache/aurora/scheduler/configuration/executor-settings-thermos-no-observer.json PRE-CREATION src/test/resources/org/apache/aurora/scheduler/configuration/thermos-settings-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37818/diff/ Testing --- ./build-support/jenkins/build.sh: directory sandbox failed but it may be a flaky test bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Renan DelValle
Re: Review Request 37825: Adding minimal implementation of the external tier config.
On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote:
src/test/resources/org/apache/aurora/scheduler/tiers-example.json, line 2
https://reviews.apache.org/r/37825/diff/1/?file=103#file103line2
The added layer here seems slightly weird, but i can see why it's
useful - you can add other fields to the config in the future. I don't
necessarily expect you to change anything, but i'm curious if that was your
intention.
This also seems weird to me. I think a good schema for the file would be {
tier name: tier properties }. Maybe this requires a mailing list discussion?
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/#review96703
---
On Aug. 26, 2015, 6:07 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/
---
(Updated Aug. 26, 2015, 6:07 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1437
https://issues.apache.org/jira/browse/AURORA-1437
Repository: aurora
Description
---
The external config file is optional for now as tiers are not fully defined
yet.
Diffs
-
examples/vagrant/upstart/aurora-scheduler-kerberos.conf
744b4a35c61e749734e222b3d4cbd296927665aa
examples/vagrant/upstart/aurora-scheduler.conf
789a3a0315e8530880999432aa9b1e7d0f57d1ff
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca
src/main/java/org/apache/aurora/scheduler/TierManager.java
652afece17a7eb09b0ca68066707b1b8fbf024f0
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java
eb0207114e1b93968cb65832f154a9cd3bc3232e
src/test/resources/org/apache/aurora/scheduler/tiers-example.json
PRE-CREATION
Diff: https://reviews.apache.org/r/37825/diff/
Testing
---
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 37825: Adding minimal implementation of the external tier config.
On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TierManager.java, line 63 https://reviews.apache.org/r/37825/diff/1/?file=101#file101line63 Consider moving the parsing up a layer, in the module. That way we can report earlier if the file is malformed, and you can bind a specific type (without the annotation). This will also address another complaint, which is that the config file is being parsed every time we want to find the tier a task config belongs to. This will also address another complaint, which is that the config file is being parsed every time we want to find the tier a task config belongs to.' Sorry, this was a lie. Please ignore. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96703 --- On Aug. 26, 2015, 6:07 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 26, 2015, 6:07 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37825: Adding minimal implementation of the external tier config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96714 --- src/main/java/org/apache/aurora/scheduler/SchedulerModule.java (line 117) https://reviews.apache.org/r/37825/#comment152355 I think this function should also parse the data into MapString, TierInfo. The earlier we parse data (and error out if data is invalid) the better IMHO. src/main/java/org/apache/aurora/scheduler/TierManager.java (line 68) https://reviews.apache.org/r/37825/#comment152357 If applying a default value, I think we should log it. src/test/java/org/apache/aurora/scheduler/TierManagerTest.java (line 26) https://reviews.apache.org/r/37825/#comment152356 Please add a test for the config for having keys that are not expected. I would expect the scheduler to reject such files because they are malformed. - Zameer Manji On Aug. 26, 2015, 6:07 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 26, 2015, 6:07 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37825: Adding minimal implementation of the external tier config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96730 --- Ship it! Master (06ddaad) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 27, 2015, 1:07 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 27, 2015, 1:07 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37825: Adding minimal implementation of the external tier config.
On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 70 https://reviews.apache.org/r/37825/diff/1/?file=100#file100line70 +@CanRead That will cause loading to fail when the argument is null. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96703 --- On Aug. 26, 2015, 6:07 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 26, 2015, 6:07 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37818: Moved executor settings configuration to loadable JSON
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/#review96733 --- Ship it! Master (06ddaad) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 26, 2015, 10:19 p.m., Renan DelValle wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/ --- (Updated Aug. 26, 2015, 10:19 p.m.) Review request for Aurora. Repository: aurora Description --- This is the first stage in a series of patches to create support for custom executors. In an effort to expedite the review process, I have decided to break down my patch into multiple pieces that when/if commited won't break the trunk. This patch includes the ability to load configuration from a JSON file. A JSON example file is included in examples/vagrant/executors-config.json Command line arguments have been eliminated and moved over to the JSON file. GSON is leveraged and does most of the work with the aid of a few custom deserializers that were needed. Note that right now a global container mount that does not follow specification will cause the scheduler to detect the error an exit early. It is up for discussion if this is the desired behavior or if we should just ignore said mount. Diffs - examples/vagrant/executors-config-new.json PRE-CREATION examples/vagrant/executors-config.json PRE-CREATION examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 0c440b5cd5b939872c1ee05d048bf739bfa977cb src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java b3c913892248e4a9a8111412307463985f5ca97f src/test/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoaderTest.java PRE-CREATION src/test/resources/org/apache/aurora/scheduler/configuration/executor-settings-thermos-no-observer.json PRE-CREATION src/test/resources/org/apache/aurora/scheduler/configuration/thermos-settings-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37818/diff/ Testing --- ./build-support/jenkins/build.sh: directory sandbox failed but it may be a flaky test bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Renan DelValle
Review Request 37851: Use Mesos Agent instead of Mesos Slave in docs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37851/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-1451 https://issues.apache.org/jira/browse/AURORA-1451 Repository: aurora Description --- Use Mesos Agent instead of Mesos Slave in docs. There are a few referencess left - those that refer to the `mesos-slave` command line and those that document `clusters.json` attributes that use the term `slave`. Those can be replaced when upstream changes the binary name and as part of https://issues.apache.org/jira/browse/AURORA-1455. Additionally there is inconsistent capitalization in the docs - I've taken to using `Mesos Agent` or `Agent` but this is not consistent everywhere, nor did I endeavor to fix it as that would explode the size of this diff. Diffs - docs/client-cluster-configuration.md 86bd17cf2ca84d0e467be18fd957ce1d6f35e37c docs/client-commands.md f91e5df0c19104a961aa9955478bf2d37a2aa7b6 docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 docs/configuration-tutorial.md d6e7c352e16964e19a41340cb03a016620c17f7d docs/deploying-aurora-scheduler.md 8a1e68e5d54e9b8b66139bfc731563668584fa77 docs/developing-aurora-client.md b662b6f5c3667e195dd04ec7eccdce1a4c070972 docs/monitoring.md 3cb2a7910311ec4aa128d2811f956dfe6331472b docs/sla.md a558e0098e73172801d9fad927f1f85d0476413f docs/tutorial.md 812a5ccc6aa9acb06e139f2525cef10da5a2b1ad docs/user-guide.md e608500499f46ea61d4a8607e4d1b2451f88996c docs/vagrant.md 3bc201f17977dbc402eeac307500db5cc9d6bb27 Diff: https://reviews.apache.org/r/37851/diff/ Testing --- Thanks, Kevin Sweeney
Re: Review Request 37825: Adding minimal implementation of the external tier config.
On Aug. 27, 2015, 5:23 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/TierManager.java, line 63
https://reviews.apache.org/r/37825/diff/1/?file=101#file101line63
Consider moving the parsing up a layer, in the module. That way we can
report earlier if the file is malformed, and you can bind a specific type
(without the annotation).
This will also address another complaint, which is that the config file
is being parsed every time we want to find the tier a task config belongs
to.
Bill Farner wrote:
This will also address another complaint, which is that the config file
is being parsed every time we want to find the tier a task config belongs to.'
Sorry, this was a lie. Please ignore.
Good point. This was done mainly for testability but nothing prevents testing
it in the module either.
On Aug. 27, 2015, 5:23 p.m., Bill Farner wrote:
src/test/resources/org/apache/aurora/scheduler/tiers-example.json, line 2
https://reviews.apache.org/r/37825/diff/1/?file=103#file103line2
The added layer here seems slightly weird, but i can see why it's
useful - you can add other fields to the config in the future. I don't
necessarily expect you to change anything, but i'm curious if that was your
intention.
Zameer Manji wrote:
This also seems weird to me. I think a good schema for the file would be
{ tier name: tier properties }. Maybe this requires a mailing list
discussion?
Maxim Khutornenko wrote:
Bill was on target with his guess. The extra layer does not add much
overhead and at the same time does not prevent adding extra metadata in
future. This is the same logical structuring proposed in the design doc.
Bill Farner wrote:
I'm all for discussion on the mailing list, but i think this is minutia
that is safe to define here and avoid the overhead of outreach/waiting.
+1. Given that the structure has been laid down in the design doc, I'd like to
proceed with this schema and reserve dev for heavier weight discussions.
On Aug. 27, 2015, 5:23 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 70
https://reviews.apache.org/r/37825/diff/1/?file=100#file100line70
+@CanRead
Kevin Sweeney wrote:
That will cause loading to fail when the argument is null.
Exactly. Added a comment in the TODO to address it later.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/#review96703
---
On Aug. 27, 2015, 1:07 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/
---
(Updated Aug. 27, 2015, 1:07 a.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1437
https://issues.apache.org/jira/browse/AURORA-1437
Repository: aurora
Description
---
The external config file is optional for now as tiers are not fully defined
yet.
Diffs
-
examples/vagrant/upstart/aurora-scheduler-kerberos.conf
744b4a35c61e749734e222b3d4cbd296927665aa
examples/vagrant/upstart/aurora-scheduler.conf
789a3a0315e8530880999432aa9b1e7d0f57d1ff
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca
src/main/java/org/apache/aurora/scheduler/TierManager.java
652afece17a7eb09b0ca68066707b1b8fbf024f0
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java
eb0207114e1b93968cb65832f154a9cd3bc3232e
src/test/resources/org/apache/aurora/scheduler/tiers-example.json
PRE-CREATION
Diff: https://reviews.apache.org/r/37825/diff/
Testing
---
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 37825: Adding minimal implementation of the external tier config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 27, 2015, 9:17 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- Bill's and Zameer's comments. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs (updated) - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Review Request 37855: Rename slave to agent in scheduler src/main/java.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37855/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-1453 https://issues.apache.org/jira/browse/AURORA-1453 Repository: aurora Description --- Rename slave to agent in scheduler src/main/java. First patch of about 3. This updates all internal references in the scheduler to use the term Mesos Agent instead of Mesos Slave. Changed everything here that doesn't rely on an external API. This changes all JavaDoc, comments, log messages, and scheduler-private variable names. The only places not changed are those where the name is defined by an external API (specifically, `mesos.proto`, `SchedulerDriver.java`, and `api.thrift`). This change introduces a new `agent_id` key in the `Offer` struct, but preserves the `slave_id` key for backwards compatibility. For confidence and ease of review I will change DbStorage references (Mybatis XML+interface matching) and `src/test/java` in separate reviews. Diffs - src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java fbd24ea4a58e28c14a343170de137c0e0ae437a2 src/main/java/org/apache/aurora/scheduler/Resources.java 712876e1fe2bfb02cb147cd7674a84dd220de899 src/main/java/org/apache/aurora/scheduler/base/Conversions.java ad66cd86567497dc3e75d75e278540c75b88d89d src/main/java/org/apache/aurora/scheduler/base/Query.java 458530fb216fd37048d3e398c07b147a1a71cf57 src/main/java/org/apache/aurora/scheduler/base/Tasks.java 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8 src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 51376798d3e4fb7c86802e4afbe7f2c7191c0e72 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java fb0f7ccf7f4dfb3ccb2a4cb4a5643c4b5487ff8f src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 526875906adfec94bdb3aadfb045bdac942ed483 src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0 src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 0743cb09bc9ec5375513ac89227c7d839f197324 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ed639b6c20a3a51aa829cacb8e5b30265600c9cd src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 88c9f667b7abc79f6cbedb575b631b68112c1d74 src/main/java/org/apache/aurora/scheduler/preemptor/ClusterState.java ce3bc7e6da3f86625c690e26c28ccef67ed9021a src/main/java/org/apache/aurora/scheduler/preemptor/ClusterStateImpl.java 42e2ca49b3c5de997cb5363e3518512d0f5a725e src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java 506176769e172b7e9f4ba05c486fe6ab550fb5c3 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionProposal.java d598b02b68c5d67610004cbd5eeefab2e9658b69 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8f3161acdab0e2d25403ee224cd6468327ee956f src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java 67d7f072de045d4211b6239119802473278d6419 src/main/java/org/apache/aurora/scheduler/preemptor/Preemptor.java 7d2903a47dacfc35f9e547ccb6c5896efe3e013f src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java c797914ded51cd123dddef188373fe58e190773a src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 577edcbf362493d577e2f12c876f1dbb9387ad79 src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java f1b11d6513546231c2510805e4a0acf23367a761 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 617ee549cc79f3c95c70ceaceca6e26ccebd1681 src/main/java/org/apache/aurora/scheduler/state/StateManager.java 5d34fe38492cae3f50ea9ed0baca11472295af60 src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java f27c93b2a59d9efd4ed8ba0fd314a33e67a9c8e0 src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java de7ebb382f56854dc2315d3793217ef007d7fbfe src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 981bdcf665fdfa710608c57e7b7817d286dab373 src/main/java/org/apache/aurora/scheduler/storage/db/AttributeMapper.java a454887c27dfc80d753afb2b2c4b20fd330aea59 src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java ee3ff6cb9f4cec06a5ae4e4fd0a0f8d7ae663176 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java ad78432a6595d32582cb0e920900e4bcb21df8dc src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 7f0cb5c7f30883982ea9388bf6a6195705dfdd75 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 072fe459e1422d6d59499b17440232ab112254ba
Re: Review Request 37825: Adding minimal implementation of the external tier config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96771 --- Ship it! Master (06ddaad) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 27, 2015, 9:17 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 27, 2015, 9:17 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/#review96774 --- Master (06ddaad) is red with this patch. ./build-support/jenkins/build.sh :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJava :processTestResources :testClasses :checkstyleTest :findbugsJmh :findbugsMain :findbugsTest :licenseJmh UP-TO-DATE :licenseMain UP-TO-DATE :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage of 0.8962987319920261 exceeds minimum coverage of 0.89. Branch coverage is 0.823905109489051, but must be greater than 0.835 :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. Test coverage missing for org/apache/aurora/scheduler/http/Agents Test coverage missing for org/apache/aurora/scheduler/http/Agents$1 Test coverage missing for org/apache/aurora/scheduler/http/Agents$Agent * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 4 mins 12.543 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 27, 2015, 6:55 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- (Updated Aug. 27, 2015, 6:55 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1449 and AURORA-1450 https://issues.apache.org/jira/browse/AURORA-1449 https://issues.apache.org/jira/browse/AURORA-1450 Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 05af127a91b6c0e8db089cb828c38e556b07d45f src/main/java/org/apache/aurora/scheduler/http/Slaves.java a9fef25595d616f0fbbb7c5ad6de39184a60002a src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
Re: Review Request 37825: Adding minimal implementation of the external tier config.
On Aug. 27, 2015, 5:54 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 117 https://reviews.apache.org/r/37825/diff/1/?file=100#file100line117 I think this function should also parse the data into MapString, TierInfo. The earlier we parse data (and error out if data is invalid) the better IMHO. Yeah, addressed above. On Aug. 27, 2015, 5:54 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/TierManager.java, line 69 https://reviews.apache.org/r/37825/diff/1/?file=101#file101line69 If applying a default value, I think we should log it. The default tier does not deviate from the current behavior, so logging would not add any additional info here. Besides, this will generate quite a bit of extra log noise as it's used in the scheduling loop. On Aug. 27, 2015, 5:54 p.m., Zameer Manji wrote: src/test/java/org/apache/aurora/scheduler/TierManagerTest.java, line 26 https://reviews.apache.org/r/37825/diff/1/?file=102#file102line26 Please add a test for the config for having keys that are not expected. I would expect the scheduler to reject such files because they are malformed. Not sure what you mean by malformed. Are you suggesting adding extra keys or purposefully corrupt json file? The former is irrelevant as unknown keys are ignored on casting to the type and the latter just throws unhandled parsing exception (exactly what we want/expect). - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96714 --- On Aug. 27, 2015, 1:07 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 27, 2015, 1:07 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37825: Adding minimal implementation of the external tier config.
On Aug. 27, 2015, 10:54 a.m., Zameer Manji wrote: src/test/java/org/apache/aurora/scheduler/TierManagerTest.java, line 26 https://reviews.apache.org/r/37825/diff/1/?file=102#file102line26 Please add a test for the config for having keys that are not expected. I would expect the scheduler to reject such files because they are malformed. Maxim Khutornenko wrote: Not sure what you mean by malformed. Are you suggesting adding extra keys or purposefully corrupt json file? The former is irrelevant as unknown keys are ignored on casting to the type and the latter just throws unhandled parsing exception (exactly what we want/expect). I think if there are extra keys we should reject the file even if the keys are irrelevant. I think operators would want to know if the configuration contains typos or other errors. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96714 --- On Aug. 27, 2015, 2:17 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 27, 2015, 2:17 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37825: Adding minimal implementation of the external tier config.
On Aug. 27, 2015, 5:54 p.m., Zameer Manji wrote: src/test/java/org/apache/aurora/scheduler/TierManagerTest.java, line 26 https://reviews.apache.org/r/37825/diff/1/?file=102#file102line26 Please add a test for the config for having keys that are not expected. I would expect the scheduler to reject such files because they are malformed. Maxim Khutornenko wrote: Not sure what you mean by malformed. Are you suggesting adding extra keys or purposefully corrupt json file? The former is irrelevant as unknown keys are ignored on casting to the type and the latter just throws unhandled parsing exception (exactly what we want/expect). Zameer Manji wrote: I think if there are extra keys we should reject the file even if the keys are irrelevant. I think operators would want to know if the configuration contains typos or other errors. That's not unreasonable. I'll defer it to AURORA-1443 though as the validation will have to be done on the TierInfo side and would make much more sense when we get to multiple tiers. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96714 --- On Aug. 27, 2015, 9:17 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 27, 2015, 9:17 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37855: Rename slave to agent in scheduler src/main/java.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37855/#review96772 --- Master (06ddaad) is red with this patch. ./build-support/jenkins/build.sh :findbugsTest :licenseJmh UP-TO-DATE :licenseMain UP-TO-DATE :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test org.apache.aurora.scheduler.storage.db.DbAttributeStoreTest testUpdateAttributesWithRelations FAILED org.apache.aurora.scheduler.storage.Storage$StorageException at DbAttributeStoreTest.java:166 Caused by: org.apache.ibatis.binding.BindingException at DbAttributeStoreTest.java:166 org.apache.aurora.scheduler.storage.db.DbAttributeStoreTest testCrud FAILED org.apache.aurora.scheduler.storage.Storage$StorageException at DbAttributeStoreTest.java:166 Caused by: org.apache.ibatis.binding.BindingException at DbAttributeStoreTest.java:166 org.apache.aurora.scheduler.storage.db.DbAttributeStoreTest testSlaveIdChanges FAILED org.apache.aurora.scheduler.storage.Storage$StorageException at DbAttributeStoreTest.java:166 Caused by: org.apache.ibatis.binding.BindingException at DbAttributeStoreTest.java:166 933 tests completed, 3 failed, 3 skipped :test FAILED :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage of 0.8949021701192847 exceeds minimum coverage of 0.89. Branch coverage is 0.822536496350365, but must be greater than 0.835 FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':test'. There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 4 mins 22.189 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 27, 2015, 9:12 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37855/ --- (Updated Aug. 27, 2015, 9:12 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-1453 https://issues.apache.org/jira/browse/AURORA-1453 Repository: aurora Description --- Rename slave to agent in scheduler src/main/java. First patch of about 3. This updates all internal references in the scheduler to use the term Mesos Agent instead of Mesos Slave. Changed everything here that doesn't rely on an external API. This changes all JavaDoc, comments, log messages, and scheduler-private variable names. The only places not changed are those where the name is defined by an external API (specifically, `mesos.proto`, `SchedulerDriver.java`, and `api.thrift`). This change introduces a new `agent_id` key in the `Offer` struct, but preserves the `slave_id` key for backwards compatibility. For confidence and ease of review I will change DbStorage references (Mybatis XML+interface matching) and `src/test/java` in separate reviews. Diffs - src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java fbd24ea4a58e28c14a343170de137c0e0ae437a2 src/main/java/org/apache/aurora/scheduler/Resources.java 712876e1fe2bfb02cb147cd7674a84dd220de899 src/main/java/org/apache/aurora/scheduler/base/Conversions.java ad66cd86567497dc3e75d75e278540c75b88d89d src/main/java/org/apache/aurora/scheduler/base/Query.java 458530fb216fd37048d3e398c07b147a1a71cf57 src/main/java/org/apache/aurora/scheduler/base/Tasks.java 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8 src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 51376798d3e4fb7c86802e4afbe7f2c7191c0e72 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java fb0f7ccf7f4dfb3ccb2a4cb4a5643c4b5487ff8f src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 526875906adfec94bdb3aadfb045bdac942ed483 src/main/java/org/apache/aurora/scheduler/http/Offers.java 4329ce10189df41a7a45cd6cc369333d7d5f65b0 src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 0743cb09bc9ec5375513ac89227c7d839f197324 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ed639b6c20a3a51aa829cacb8e5b30265600c9cd src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 88c9f667b7abc79f6cbedb575b631b68112c1d74
Review Request 37859: Rename slave to agent in src/main/python.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37859/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1454 and AURORA-1455 https://issues.apache.org/jira/browse/AURORA-1454 https://issues.apache.org/jira/browse/AURORA-1455 Repository: aurora Description --- Use Mesos Agent instead of Mesos Slave in src/main/python. This changes the name in all places where the Python code controls the use of the name (comments, pydoc, private variable names). It doesn't change the reference in places it doesn't control (`clusters.json`, `api.thrift`, `mesos.proto`, and the `Executor` interface from `mesos.interface`). For ease of review and confidence, I intend to change `src/test/python` in a follow-up review. Diffs - src/main/python/apache/aurora/client/api/command_runner.py c7238e274e53138187c2fe6fe5f14b7ae5f43ba2 src/main/python/apache/aurora/client/base.py 487f8e73fa978b150f2e5b60e0f64c71ce783c12 src/main/python/apache/aurora/client/cli/task.py d1f2568ac0afdd95c65523fde41f0dd16670a7a8 src/main/python/apache/aurora/executor/aurora_executor.py 96d7a336deebc4c95405d237df0ee11e7e055aa2 src/main/python/apache/aurora/executor/bin/thermos_executor_main.py b3e8bf1e924999306e0b8a1314273b22c51028e7 src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d src/main/python/apache/aurora/executor/common/executor_detector.py a07bfc34caa5f86153ace8184b061e253c39e92e src/main/python/apache/aurora/executor/executor_base.py 1db97cc8c12752d4eca339a7680ba963a66ffbce Diff: https://reviews.apache.org/r/37859/diff/ Testing --- Thanks, Kevin Sweeney
Re: Review Request 37851: Use Mesos Agent instead of Mesos Slave in docs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37851/#review96777 --- Ship it! Master (06ddaad) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 27, 2015, 6:52 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37851/ --- (Updated Aug. 27, 2015, 6:52 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-1451 https://issues.apache.org/jira/browse/AURORA-1451 Repository: aurora Description --- Use Mesos Agent instead of Mesos Slave in docs. There are a few referencess left - those that refer to the `mesos-slave` command line and those that document `clusters.json` attributes that use the term `slave`. Those can be replaced when upstream changes the binary name and as part of https://issues.apache.org/jira/browse/AURORA-1455. Additionally there is inconsistent capitalization in the docs - I've taken to using `Mesos Agent` or `Agent` but this is not consistent everywhere, nor did I endeavor to fix it as that would explode the size of this diff. Diffs - docs/client-cluster-configuration.md 86bd17cf2ca84d0e467be18fd957ce1d6f35e37c docs/client-commands.md f91e5df0c19104a961aa9955478bf2d37a2aa7b6 docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 docs/configuration-tutorial.md d6e7c352e16964e19a41340cb03a016620c17f7d docs/deploying-aurora-scheduler.md 8a1e68e5d54e9b8b66139bfc731563668584fa77 docs/developing-aurora-client.md b662b6f5c3667e195dd04ec7eccdce1a4c070972 docs/monitoring.md 3cb2a7910311ec4aa128d2811f956dfe6331472b docs/sla.md a558e0098e73172801d9fad927f1f85d0476413f docs/tutorial.md 812a5ccc6aa9acb06e139f2525cef10da5a2b1ad docs/user-guide.md e608500499f46ea61d4a8607e4d1b2451f88996c docs/vagrant.md 3bc201f17977dbc402eeac307500db5cc9d6bb27 Diff: https://reviews.apache.org/r/37851/diff/ Testing --- Thanks, Kevin Sweeney
Re: Review Request 37860: Rpm: fix install dep on daemonize, be permissive with newer mesos versions.
On Aug. 27, 2015, 3:55 p.m., Kevin Sweeney wrote: specs/rpm/aurora.spec, line 100 https://reviews.apache.org/r/37860/diff/1/?file=1056661#file1056661line100 Can you explain the rationale behind this change - unpinned mesos runs the risk of not working with the executor it was compiled against. Much as we might wish that this will work, we don't know that it will and it's much easier to debug an error from yum than a runtime linker issue. If a user is convinced that we're wrong here they can always override with `--nodeps`. Sure, i'll abandon. Perhaps the right approach will be for us to do point releases to pick up new mesos versions. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37860/#review96782 --- On Aug. 27, 2015, 3:50 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37860/ --- (Updated Aug. 27, 2015, 3:50 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging Description --- Rpm: fix install dep on daemonize, be permissive with newer mesos versions. Diffs - specs/rpm/aurora.spec 3e7b8bef2272d935f3efb3e3ea6e4ac510026b7d Diff: https://reviews.apache.org/r/37860/diff/ Testing --- Successfully ran what jenkins runs: ``` ./build-artifact.sh builder/rpm/centos-7 ~/snapshot.tar.gz 0.10.0snapshot.2015.08.27 ``` Thanks, Bill Farner
Re: Review Request 37859: Rename slave to agent in src/main/python.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37859/#review96781
---
Master (06ddaad) is red with this patch.
./build-support/jenkins/build.sh
FAILURES
___ test_path_detector ___
[1mdef test_path_detector():[0m
[1m ROOTS = ('/var/lib/mesos1/slaves',
'/var/lib/mesos2/slaves')[0m
[1m FAKE_ROOT = '/var/blah/blah'[0m
[1m FAKE_CHECKPOINT_DIR = 'ckpt'[0m
[1m[0m
[1m path1_symlink, path1, path2 = ([0m
[1m ExecutorDetector.path(Match(ROOTS[0],
'slave001', 'framework1', 'executor1', 'latest')),[0m
[1m ExecutorDetector.path(Match(ROOTS[0],
'slave001', 'framework1', 'executor1', 'asdf-ghjk')),[0m
[1m ExecutorDetector.path(Match(ROOTS[1],
'slave002', 'framework2', 'executor2', 'latest')),[0m
[1m )[0m
src/test/python/apache/aurora/executor/common/test_path_detector.py:38:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
cls = class
'apache.aurora.executor.common.executor_detector.ExecutorDetector'
result = common.test_path_detector.Match object at
0x7f3edaa2b710
[1m@classmethod[0m
[1mdef path(cls, result):[0m
[1m return os.path.join(*cls.PATTERN) %
result.groups()[0m
[1m[31mE KeyError: 'agent_id'[0m
/tmp/user/2395/tmp5m7nmj/apache/aurora/executor/common/executor_detector.py:76:
KeyError
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.executor.common.path_detector.xml
[1m[31m 1 failed in 0.05 seconds
[0m
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
src.test.python.apache.aurora.executor.common.path_detector
. FAILURE
src.test.python.apache.thermos.cli.commands.commands
. SUCCESS
src.test.python.apache.thermos.cli.common
. SUCCESS
src.test.python.apache.thermos.cli.main
. SUCCESS
src.test.python.apache.thermos.common.test_pathspec
. SUCCESS
src.test.python.apache.thermos.monitoring.test_disk
. SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing @ReviewBot
retry
- Aurora ReviewBot
On Aug. 27, 2015, 10:11 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37859/
---
(Updated Aug. 27, 2015, 10:11 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1454 and AURORA-1455
https://issues.apache.org/jira/browse/AURORA-1454
https://issues.apache.org/jira/browse/AURORA-1455
Repository: aurora
Description
---
Use Mesos Agent instead of Mesos Slave in src/main/python.
This changes the name in all places where the Python code controls the use of
the name (comments, pydoc, private variable names). It doesn't change the
reference in places it doesn't control (`clusters.json`, `api.thrift`,
`mesos.proto`, and the `Executor` interface from `mesos.interface`).
For ease of review and confidence, I intend to change `src/test/python` in a
follow-up review.
Diffs
-
src/main/python/apache/aurora/client/api/command_runner.py
c7238e274e53138187c2fe6fe5f14b7ae5f43ba2
src/main/python/apache/aurora/client/base.py
487f8e73fa978b150f2e5b60e0f64c71ce783c12
src/main/python/apache/aurora/client/cli/task.py
d1f2568ac0afdd95c65523fde41f0dd16670a7a8
src/main/python/apache/aurora/executor/aurora_executor.py
96d7a336deebc4c95405d237df0ee11e7e055aa2
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py
b3e8bf1e924999306e0b8a1314273b22c51028e7
src/main/python/apache/aurora/executor/common/announcer.py
Review Request 37860: Rpm: fix install dep on daemonize, be permissive with newer mesos versions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37860/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging Description --- Rpm: fix install dep on daemonize, be permissive with newer mesos versions. Diffs - specs/rpm/aurora.spec 3e7b8bef2272d935f3efb3e3ea6e4ac510026b7d Diff: https://reviews.apache.org/r/37860/diff/ Testing --- Successfully ran what jenkins runs: ``` ./build-artifact.sh builder/rpm/centos-7 ~/snapshot.tar.gz 0.10.0snapshot.2015.08.27 ``` Thanks, Bill Farner
Re: Review Request 37860: Rpm: fix install dep on daemonize, be permissive with newer mesos versions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37860/#review96782 --- specs/rpm/aurora.spec (line 100) https://reviews.apache.org/r/37860/#comment152429 Can you explain the rationale behind this change - unpinned mesos runs the risk of not working with the executor it was compiled against. Much as we might wish that this will work, we don't know that it will and it's much easier to debug an error from yum than a runtime linker issue. If a user is convinced that we're wrong here they can always override with `--nodeps`. - Kevin Sweeney On Aug. 27, 2015, 3:50 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37860/ --- (Updated Aug. 27, 2015, 3:50 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging Description --- Rpm: fix install dep on daemonize, be permissive with newer mesos versions. Diffs - specs/rpm/aurora.spec 3e7b8bef2272d935f3efb3e3ea6e4ac510026b7d Diff: https://reviews.apache.org/r/37860/diff/ Testing --- Successfully ran what jenkins runs: ``` ./build-artifact.sh builder/rpm/centos-7 ~/snapshot.tar.gz 0.10.0snapshot.2015.08.27 ``` Thanks, Bill Farner
Re: Review Request 37861: Add a convenience to build all artifacts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37861/#review96786 --- Ship it! Ship It! - Kevin Sweeney On Aug. 27, 2015, 4:05 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37861/ --- (Updated Aug. 27, 2015, 4:05 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging Description --- This pulls in some complexity from the jenkins job, and is generally useful when iterating on the tooling. Diffs - build-artifact.sh bb24b3619c76e80317ad65386f81ab70a44105bc Diff: https://reviews.apache.org/r/37861/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 37861: Add a convenience to build all artifacts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37861/#review96785 --- Ship it! Ship It! - Kevin Sweeney On Aug. 27, 2015, 4:05 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37861/ --- (Updated Aug. 27, 2015, 4:05 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging Description --- This pulls in some complexity from the jenkins job, and is generally useful when iterating on the tooling. Diffs - build-artifact.sh bb24b3619c76e80317ad65386f81ab70a44105bc Diff: https://reviews.apache.org/r/37861/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 37862: Rpm: remove daemonize dep for rhel =7.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37862/#review96787 --- Ship it! Ship It! - Kevin Sweeney On Aug. 27, 2015, 4:08 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37862/ --- (Updated Aug. 27, 2015, 4:08 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging Description --- This appears to have been a mistake in the original spec. This patch makes the thermos block match the scheduler block. Diffs - specs/rpm/aurora.spec 3e7b8bef2272d935f3efb3e3ea6e4ac510026b7d Diff: https://reviews.apache.org/r/37862/diff/ Testing --- Thanks, Bill Farner
Review Request 37862: Rpm: remove daemonize dep for rhel =7.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37862/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging Description --- This appears to have been a mistake in the original spec. This patch makes the thermos block match the scheduler block. Diffs - specs/rpm/aurora.spec 3e7b8bef2272d935f3efb3e3ea6e4ac510026b7d Diff: https://reviews.apache.org/r/37862/diff/ Testing --- Thanks, Bill Farner
Review Request 37872: Remove unused classes from commons fork.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37872/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --- Starting with low-hanging fruit - remove (almost exclusively) classes that are unused. Diffs - commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java 6a48b84b3a04671498c012ecb7a31ace512b5394 commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java f786f9e028ce049cd55bf95bba86057e7abbaccb commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java e2160e7d5c9db18bd2377ddabc03608e5143a72a commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java d09631757a942f15337836fdea8fff30ec735233 commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java e4c58a21c1fdb2f12ce67efaaa888c33b48c commons/src/main/java/org/apache/aurora/common/application/http/Registration.java b66c8c8878001953422f9799cdd4545bdd931c51 commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java b3e59e78b3f863cb352289ab2d3411c914d33264 commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java 107e3aa51c7cf3729bb56800adece05742c55d30 commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java ba93d4c8f4707bd6ccb13e108216483625240698 commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java 55236dfc53f4f842bc34b6d66d9fceeab39e4433 commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 3a1511dc8bf3651ccd91157db5716321485dfa5b commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java b4f2d53293552164613119426993c5ae94558f1f commons/src/main/java/org/apache/aurora/common/base/Either.java a746e72a95fee6e6108dbf0eead960f6a2227216 commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java f06c66cd027147903ea18ede9490c4c5c6ce122f commons/src/main/java/org/apache/aurora/common/base/SupplierE.java ecad43e08e399db5b70b9f6b5fcdb401725b4efc commons/src/main/java/org/apache/aurora/common/collections/Bits.java f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java 9cb6f547dfa470808def5d088984636a58dbf93c commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 38fbe4dc692b51595499b392dcfb75af4b3edc44 commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java 7543ff1dedc55897d7ec45d35be74caf42e74a56 commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 commons/src/main/java/org/apache/aurora/common/io/Streamer.java 902676036f1e50da7bd794ea23704bf6c5dc26c5 commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java a83895df65a399c1a85e421254d5e1ec167f4521 commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java 8a9e18e09e2184301af1c79f3027a380731451a3 commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java 14bbd4cbb7cfeec6889f282c3fcb40dde008b600 commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java c5126dc4580d6e15222533071ec64bce529c8782 commons/src/main/java/org/apache/aurora/common/net/ProxyConfig.java fa474b5b3ef2a0e3e1e9c74ad4d6990ba65073b2 commons/src/main/java/org/apache/aurora/common/net/UrlHelper.java 3f06d6335074119fa4a3dd3e364eaa9e69396b03 commons/src/main/java/org/apache/aurora/common/net/UrlResolver.java 96c5f072b62ba74f3a96239a0069180f720bc200 commons/src/main/java/org/apache/aurora/common/net/UrlResolverUtil.java 4b95bb7655cb86a6001b346df7bc66619b276ac8 commons/src/main/java/org/apache/aurora/common/net/UrlTokenizerUtil.java 67798a3203e24b88da2403393a042fbd1d3df0ba commons/src/main/java/org/apache/aurora/common/net/http/GuiceServletConfig.java e4fa8aa97da67a697867db88cb6fe3af4b00b115 commons/src/main/java/org/apache/aurora/common/net/http/HttpServerDispatch.java 3208267ba53986dc94402eb834571d65fd1ba293
