Re: Review Request 37874: Remove unused code from commons fork.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37874/#review96972 --- Ship it! Master (356eeac) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 29, 2015, 1:51 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37874/ --- (Updated Aug. 29, 2015, 1:51 a.m.) Review request for Aurora and Zameer Manji. Repository: aurora Description --- Carrying on from https://reviews.apache.org/r/37872/, this patch goes a bit deeper and starts pulling out some unused functions and behavior, which in turn allows for a bunch of additional deletion. Diffs - commons/src/main/java/org/apache/aurora/common/application/modules/LocalServiceRegistry.java 027e4a7114b4c776a86c31aed1033c45e8e20a02 commons/src/main/java/org/apache/aurora/common/base/Closures.java d741e9c54dc4d1006ec2d39235307a5e61edb807 commons/src/main/java/org/apache/aurora/common/base/Commands.java 6d9fc4c321b602149ede49daa6ba16c8d83a3748 commons/src/main/java/org/apache/aurora/common/base/MorePreconditions.java 1fe19d4eb0aeae1626434d9962aae993d1c66527 commons/src/main/java/org/apache/aurora/common/collections/Multimaps.java 7f94a8a595fbff0c1b2e7f4089a9f535120d358a commons/src/main/java/org/apache/aurora/common/inject/Bindings.java f910f22eab01db30bac139fc40a944f3d2bab7fd commons/src/main/java/org/apache/aurora/common/io/CompatibilityCodec.java c49c7dd67f1ead75f23251c2bc5849c952289a3d commons/src/main/java/org/apache/aurora/common/io/ThriftCodec.java 66447880e133aba614ef4b9fb2b48313a308d465 commons/src/main/java/org/apache/aurora/common/net/Environment.java 65fd15ec6ebd6b9063789dd16be17a03f383140e commons/src/main/java/org/apache/aurora/common/stats/Stats.java 2191f77924ab00db978a2ffeb1286d415f761355 commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java cb1c56bc96d61a2863f1addeed111ba611c5df2e commons/src/main/java/org/apache/aurora/common/util/BackoffDecider.java e11a52c690db646472b9d48a1772e4b83f7ae906 commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 8f31ea789676db5abf3510154f05372d9b0c9541 commons/src/main/java/org/apache/aurora/common/util/CommandExecutor.java e591721a2cac51d800a40b3b0e592594f75ac59f commons/src/main/java/org/apache/aurora/common/util/Random.java a1f14968a0400729b4f7d9373b63e56d622f83ce commons/src/main/java/org/apache/aurora/common/util/Stat.java 2fec9d991d779709f2419811457681f53cf15a37 commons/src/main/java/org/apache/aurora/common/util/StateMachine.java 89046da4951cae8931cfc40b044331037ba11a1e commons/src/main/java/org/apache/aurora/common/util/Timer.java 15602acec3c5716e3e152590693ddc075ae29c79 commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java e16a64dda003c7d2c6aef932eeca07ed81f53500 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 9a33d3eddbf73e4cb6dabbb8bb9e7c9867dd772e commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 660f3d6c636ce18902e256c064c2ed83bb18f4a4 commons/src/main/java/org/apache/aurora/common/zookeeper/guice/ServerSetModule.java c8a3214ae7a0db4b61df35508f8ba6251848b221 commons/src/main/java/org/apache/aurora/common/zookeeper/guice/client/ZooKeeperClientModule.java 08cdf550e0866076d0e66e2e6d656e96f9966e84 commons/src/test/java/org/apache/aurora/common/application/modules/LifecycleModuleTest.java fdbef6f054999171c84f394cda2a89209bdd2429 commons/src/test/java/org/apache/aurora/common/application/modules/LocalServiceRegistryTest.java a9fe793f6392140b05ede4663b22aa0361e00df0 commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java d2c9565bbd6c58efdbec7cdce700c8af959b5dda commons/src/test/java/org/apache/aurora/common/base/CommandsTest.java 0a9bad91d7b9135b8837e6ee357424a5a658162b commons/src/test/java/org/apache/aurora/common/collections/Iterables2Test.java e74038d994d66286ad11e97fb67b98f3c6a56618 commons/src/test/java/org/apache/aurora/common/inject/BindingsTest.java a84de3e83dd550f3681cdb2d0af87e94682d786f commons/src/test/java/org/apache/aurora/common/io/CodecTestUtilities.java 4cfd4c997f37e5599b3ae39afe1b46d9f278ee5a commons/src/test/java/org/apache/aurora/common/io/CompatibilityCodecTest.java 4c1b537bb5d08719917c2262705b0ab1fe5f3cdd commons/src/test/java/org/apache/aurora/common/io/ThriftCodecTest.java ce112dc609621ef11709e5ce0fa7d762f3aa4745
Re: Review Request 37874: Remove unused classes from commons fork.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37874/#review96888 --- This diff contains the changes in /r/37872. I'm unable to review it. - Zameer Manji On Aug. 27, 2015, 11:16 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37874/ --- (Updated Aug. 27, 2015, 11:16 p.m.) Review request for Aurora and Zameer Manji. Repository: aurora Description --- Carrying on from https://reviews.apache.org/r/37872/, this patch goes a bit deeper and starts pulling out some unused functions and behavior, which in turn allows for a bunch of additional deletion. Diffs - commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java 6a48b84b3a04671498c012ecb7a31ace512b5394 commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java f786f9e028ce049cd55bf95bba86057e7abbaccb commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java e2160e7d5c9db18bd2377ddabc03608e5143a72a commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java d09631757a942f15337836fdea8fff30ec735233 commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java e4c58a21c1fdb2f12ce67efaaa888c33b48c commons/src/main/java/org/apache/aurora/common/application/http/Registration.java b66c8c8878001953422f9799cdd4545bdd931c51 commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java b3e59e78b3f863cb352289ab2d3411c914d33264 commons/src/main/java/org/apache/aurora/common/application/modules/LocalServiceRegistry.java 027e4a7114b4c776a86c31aed1033c45e8e20a02 commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java 107e3aa51c7cf3729bb56800adece05742c55d30 commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java ba93d4c8f4707bd6ccb13e108216483625240698 commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java 55236dfc53f4f842bc34b6d66d9fceeab39e4433 commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 3a1511dc8bf3651ccd91157db5716321485dfa5b commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java b4f2d53293552164613119426993c5ae94558f1f commons/src/main/java/org/apache/aurora/common/base/Closures.java d741e9c54dc4d1006ec2d39235307a5e61edb807 commons/src/main/java/org/apache/aurora/common/base/Commands.java 6d9fc4c321b602149ede49daa6ba16c8d83a3748 commons/src/main/java/org/apache/aurora/common/base/Either.java a746e72a95fee6e6108dbf0eead960f6a2227216 commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java f06c66cd027147903ea18ede9490c4c5c6ce122f commons/src/main/java/org/apache/aurora/common/base/MorePreconditions.java 1fe19d4eb0aeae1626434d9962aae993d1c66527 commons/src/main/java/org/apache/aurora/common/base/SupplierE.java ecad43e08e399db5b70b9f6b5fcdb401725b4efc commons/src/main/java/org/apache/aurora/common/collections/Bits.java f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 commons/src/main/java/org/apache/aurora/common/collections/Multimaps.java 7f94a8a595fbff0c1b2e7f4089a9f535120d358a commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java 9cb6f547dfa470808def5d088984636a58dbf93c commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 commons/src/main/java/org/apache/aurora/common/inject/Bindings.java f910f22eab01db30bac139fc40a944f3d2bab7fd commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 38fbe4dc692b51595499b392dcfb75af4b3edc44 commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java 7543ff1dedc55897d7ec45d35be74caf42e74a56 commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 commons/src/main/java/org/apache/aurora/common/io/CompatibilityCodec.java c49c7dd67f1ead75f23251c2bc5849c952289a3d commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 commons/src/main/java/org/apache/aurora/common/io/Streamer.java 902676036f1e50da7bd794ea23704bf6c5dc26c5 commons/src/main/java/org/apache/aurora/common/io/ThriftCodec.java 66447880e133aba614ef4b9fb2b48313a308d465
Re: Review Request 37872: Remove unused classes from commons fork.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37872/#review96889 --- Ship it! Ship It! - Zameer Manji On Aug. 27, 2015, 9:46 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37872/ --- (Updated Aug. 27, 2015, 9:46 p.m.) Review request for Aurora and Zameer Manji. Repository: aurora Description --- Starting with low-hanging fruit - remove (almost exclusively) classes that are unused. Diffs - commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java 6a48b84b3a04671498c012ecb7a31ace512b5394 commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java f786f9e028ce049cd55bf95bba86057e7abbaccb commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java e2160e7d5c9db18bd2377ddabc03608e5143a72a commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java d09631757a942f15337836fdea8fff30ec735233 commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java e4c58a21c1fdb2f12ce67efaaa888c33b48c commons/src/main/java/org/apache/aurora/common/application/http/Registration.java b66c8c8878001953422f9799cdd4545bdd931c51 commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java b3e59e78b3f863cb352289ab2d3411c914d33264 commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java 107e3aa51c7cf3729bb56800adece05742c55d30 commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java ba93d4c8f4707bd6ccb13e108216483625240698 commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java 55236dfc53f4f842bc34b6d66d9fceeab39e4433 commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 3a1511dc8bf3651ccd91157db5716321485dfa5b commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java b4f2d53293552164613119426993c5ae94558f1f commons/src/main/java/org/apache/aurora/common/base/Either.java a746e72a95fee6e6108dbf0eead960f6a2227216 commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java f06c66cd027147903ea18ede9490c4c5c6ce122f commons/src/main/java/org/apache/aurora/common/base/SupplierE.java ecad43e08e399db5b70b9f6b5fcdb401725b4efc commons/src/main/java/org/apache/aurora/common/collections/Bits.java f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java 9cb6f547dfa470808def5d088984636a58dbf93c commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 38fbe4dc692b51595499b392dcfb75af4b3edc44 commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java 7543ff1dedc55897d7ec45d35be74caf42e74a56 commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 commons/src/main/java/org/apache/aurora/common/io/Streamer.java 902676036f1e50da7bd794ea23704bf6c5dc26c5 commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java a83895df65a399c1a85e421254d5e1ec167f4521 commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java 8a9e18e09e2184301af1c79f3027a380731451a3 commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java 14bbd4cbb7cfeec6889f282c3fcb40dde008b600 commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java c5126dc4580d6e15222533071ec64bce529c8782 commons/src/main/java/org/apache/aurora/common/net/ProxyConfig.java fa474b5b3ef2a0e3e1e9c74ad4d6990ba65073b2 commons/src/main/java/org/apache/aurora/common/net/UrlHelper.java 3f06d6335074119fa4a3dd3e364eaa9e69396b03 commons/src/main/java/org/apache/aurora/common/net/UrlResolver.java 96c5f072b62ba74f3a96239a0069180f720bc200
Re: Review Request 37872: Remove unused classes from commons fork.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37872/ --- (Updated Aug. 28, 2015, 10:15 a.m.) Review request for Aurora and Zameer Manji. Changes --- removed unused mockito dep, restored previoiusly-ignored test case in ServerSetImplTest. Repository: aurora Description --- Starting with low-hanging fruit - remove (almost exclusively) classes that are unused. Diffs (updated) - build.gradle 9444886377bd7deb6a14604a50c8ed9cac90cdda commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java 6a48b84b3a04671498c012ecb7a31ace512b5394 commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java f786f9e028ce049cd55bf95bba86057e7abbaccb commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java e2160e7d5c9db18bd2377ddabc03608e5143a72a commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java d09631757a942f15337836fdea8fff30ec735233 commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java e4c58a21c1fdb2f12ce67efaaa888c33b48c commons/src/main/java/org/apache/aurora/common/application/http/Registration.java b66c8c8878001953422f9799cdd4545bdd931c51 commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java b3e59e78b3f863cb352289ab2d3411c914d33264 commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java 107e3aa51c7cf3729bb56800adece05742c55d30 commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java ba93d4c8f4707bd6ccb13e108216483625240698 commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java 55236dfc53f4f842bc34b6d66d9fceeab39e4433 commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 3a1511dc8bf3651ccd91157db5716321485dfa5b commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java b4f2d53293552164613119426993c5ae94558f1f commons/src/main/java/org/apache/aurora/common/base/Either.java a746e72a95fee6e6108dbf0eead960f6a2227216 commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java f06c66cd027147903ea18ede9490c4c5c6ce122f commons/src/main/java/org/apache/aurora/common/base/SupplierE.java ecad43e08e399db5b70b9f6b5fcdb401725b4efc commons/src/main/java/org/apache/aurora/common/collections/Bits.java f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java 9cb6f547dfa470808def5d088984636a58dbf93c commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 38fbe4dc692b51595499b392dcfb75af4b3edc44 commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java 7543ff1dedc55897d7ec45d35be74caf42e74a56 commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 commons/src/main/java/org/apache/aurora/common/io/Streamer.java 902676036f1e50da7bd794ea23704bf6c5dc26c5 commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java a83895df65a399c1a85e421254d5e1ec167f4521 commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java 8a9e18e09e2184301af1c79f3027a380731451a3 commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java 14bbd4cbb7cfeec6889f282c3fcb40dde008b600 commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java c5126dc4580d6e15222533071ec64bce529c8782 commons/src/main/java/org/apache/aurora/common/net/ProxyConfig.java fa474b5b3ef2a0e3e1e9c74ad4d6990ba65073b2 commons/src/main/java/org/apache/aurora/common/net/UrlHelper.java 3f06d6335074119fa4a3dd3e364eaa9e69396b03 commons/src/main/java/org/apache/aurora/common/net/UrlResolver.java 96c5f072b62ba74f3a96239a0069180f720bc200 commons/src/main/java/org/apache/aurora/common/net/UrlResolverUtil.java 4b95bb7655cb86a6001b346df7bc66619b276ac8 commons/src/main/java/org/apache/aurora/common/net/UrlTokenizerUtil.java 67798a3203e24b88da2403393a042fbd1d3df0ba
Re: Review Request 37872: Remove unused classes from commons fork.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37872/#review96898 --- Ship it! Master (06ddaad) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 28, 2015, 5:15 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37872/ --- (Updated Aug. 28, 2015, 5:15 p.m.) Review request for Aurora and Zameer Manji. Repository: aurora Description --- Starting with low-hanging fruit - remove (almost exclusively) classes that are unused. Diffs - build.gradle 9444886377bd7deb6a14604a50c8ed9cac90cdda commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java 6a48b84b3a04671498c012ecb7a31ace512b5394 commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java f786f9e028ce049cd55bf95bba86057e7abbaccb commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java e2160e7d5c9db18bd2377ddabc03608e5143a72a commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java d09631757a942f15337836fdea8fff30ec735233 commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java e4c58a21c1fdb2f12ce67efaaa888c33b48c commons/src/main/java/org/apache/aurora/common/application/http/Registration.java b66c8c8878001953422f9799cdd4545bdd931c51 commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java b3e59e78b3f863cb352289ab2d3411c914d33264 commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java 107e3aa51c7cf3729bb56800adece05742c55d30 commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java ba93d4c8f4707bd6ccb13e108216483625240698 commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java 55236dfc53f4f842bc34b6d66d9fceeab39e4433 commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 3a1511dc8bf3651ccd91157db5716321485dfa5b commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java b4f2d53293552164613119426993c5ae94558f1f commons/src/main/java/org/apache/aurora/common/base/Either.java a746e72a95fee6e6108dbf0eead960f6a2227216 commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java f06c66cd027147903ea18ede9490c4c5c6ce122f commons/src/main/java/org/apache/aurora/common/base/SupplierE.java ecad43e08e399db5b70b9f6b5fcdb401725b4efc commons/src/main/java/org/apache/aurora/common/collections/Bits.java f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java 9cb6f547dfa470808def5d088984636a58dbf93c commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 38fbe4dc692b51595499b392dcfb75af4b3edc44 commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java 7543ff1dedc55897d7ec45d35be74caf42e74a56 commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 commons/src/main/java/org/apache/aurora/common/io/Streamer.java 902676036f1e50da7bd794ea23704bf6c5dc26c5 commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java a83895df65a399c1a85e421254d5e1ec167f4521 commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java 8a9e18e09e2184301af1c79f3027a380731451a3 commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java 14bbd4cbb7cfeec6889f282c3fcb40dde008b600 commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java c5126dc4580d6e15222533071ec64bce529c8782 commons/src/main/java/org/apache/aurora/common/net/ProxyConfig.java fa474b5b3ef2a0e3e1e9c74ad4d6990ba65073b2
Re: Review Request 37872: Remove unused classes from commons fork.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37872/#review96886 --- Since you deleted commons/src/main/java/org/apache/aurora/common/testing/mockito/MockitoTest.java would you mind changing build.gradle and removing the dependency on mockito and objenesis dependency? - Zameer Manji On Aug. 27, 2015, 9:46 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37872/ --- (Updated Aug. 27, 2015, 9:46 p.m.) Review request for Aurora and Zameer Manji. Repository: aurora Description --- Starting with low-hanging fruit - remove (almost exclusively) classes that are unused. Diffs - commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java 6a48b84b3a04671498c012ecb7a31ace512b5394 commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java f786f9e028ce049cd55bf95bba86057e7abbaccb commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java e2160e7d5c9db18bd2377ddabc03608e5143a72a commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java d09631757a942f15337836fdea8fff30ec735233 commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java e4c58a21c1fdb2f12ce67efaaa888c33b48c commons/src/main/java/org/apache/aurora/common/application/http/Registration.java b66c8c8878001953422f9799cdd4545bdd931c51 commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java b3e59e78b3f863cb352289ab2d3411c914d33264 commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java 107e3aa51c7cf3729bb56800adece05742c55d30 commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java ba93d4c8f4707bd6ccb13e108216483625240698 commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java 55236dfc53f4f842bc34b6d66d9fceeab39e4433 commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 3a1511dc8bf3651ccd91157db5716321485dfa5b commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java b4f2d53293552164613119426993c5ae94558f1f commons/src/main/java/org/apache/aurora/common/base/Either.java a746e72a95fee6e6108dbf0eead960f6a2227216 commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java f06c66cd027147903ea18ede9490c4c5c6ce122f commons/src/main/java/org/apache/aurora/common/base/SupplierE.java ecad43e08e399db5b70b9f6b5fcdb401725b4efc commons/src/main/java/org/apache/aurora/common/collections/Bits.java f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java 9cb6f547dfa470808def5d088984636a58dbf93c commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 38fbe4dc692b51595499b392dcfb75af4b3edc44 commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java 7543ff1dedc55897d7ec45d35be74caf42e74a56 commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 commons/src/main/java/org/apache/aurora/common/io/Streamer.java 902676036f1e50da7bd794ea23704bf6c5dc26c5 commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java a83895df65a399c1a85e421254d5e1ec167f4521 commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java 8a9e18e09e2184301af1c79f3027a380731451a3 commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java 14bbd4cbb7cfeec6889f282c3fcb40dde008b600 commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java c5126dc4580d6e15222533071ec64bce529c8782 commons/src/main/java/org/apache/aurora/common/net/ProxyConfig.java fa474b5b3ef2a0e3e1e9c74ad4d6990ba65073b2 commons/src/main/java/org/apache/aurora/common/net/UrlHelper.java
Re: Review Request 37825: Adding minimal implementation of the external tier config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review96963 --- Ship it! Master (356eeac) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 28, 2015, 11:46 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/ --- (Updated Aug. 28, 2015, 11:46 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description --- The external config file is optional for now as tiers are not fully defined yet. Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff src/jmh/java/org/apache/aurora/benchmark/Offers.java 26bad1cce987ef7f46368a5936cf056aeb2f63b1 src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca src/main/java/org/apache/aurora/scheduler/TierInfo.java 61bf30a7f11d2d4b9e49c58a6ed9ecd779d7e5ba src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0 src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java d7f3c60d383cf10afb0c0fcf4fe29972b183458c src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 399f58de6196b97abd359ecef8131b63480d591a src/test/java/org/apache/aurora/scheduler/ResourcesTest.java eb1baedcb13c2f169d819d137f22cb8b88db149c src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java adcc7a823ecf30442016ecbdd655622d6aeba65e src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 819b51e4c314749dc48db25693503af7d1ed0c54 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java d8a524d98771ee68d7b4d423fb34e28101a04d27 src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION Diff: https://reviews.apache.org/r/37825/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
