Re: Review Request 37933: Remove dependency on old google testing library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37933/#review97030 --- Ship it! Master (782f883) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 30, 2015, 4:35 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37933/ --- (Updated Aug. 30, 2015, 4:35 p.m.) Review request for Aurora and Zameer Manji. Repository: aurora Description --- Remove dependency on old google testing library. Diffs - build.gradle 05cd36f476f92b157ab2782a6d259a37d7e5c9cb commons/src/main/java/org/apache/aurora/common/testing/TearDownTestCase.java PRE-CREATION commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java 92ba0c30b8b721fa6891bc75d227a52e0a65d863 commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java 88cd6d2ed1c243dab116b79127a616bde1ee87e4 commons/src/test/java/org/apache/aurora/common/io/FileUtilsTest.java 6b8f6d3a66984ac2a1ab667e031031bfe12735ee commons/src/test/java/org/apache/aurora/common/quantity/AmountTest.java 8adf3f65fcd3aa6eed788a85ade7e32f5f6ee769 commons/src/test/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingExecutorServiceTest.java 6cea4b19cfd67aba4a36136dc53b4a1e43a8a815 commons/src/test/java/org/apache/aurora/common/util/concurrent/ExceptionHandlingScheduledExecutorServiceTest.java 3caeeaa90c21b25cd3d6ee19eccaffb50def78bd commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 804b7727db3e01433d1ebe32d7c340dad514ba14 commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceTest.java 7f537ec4abfdbd25adb962bf78b8b8b62f185ebb commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java a64a98face51a689c155b2f4a83f0227d04b9a61 commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java b3c469f27ee260500aa90dbb0c1df6f11b29ad29 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 6447f696277636932c0ad85a43285a161e0547c5 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java efc30a589e808b6383933a5e0962e23d78ada6d3 src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java a5703e5042768b238a4a69e898f814edad29f00f src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 8365c6c434176efc093025bbe5b3f69f2b934052 src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 553eac329a22fe6081c2256c22190c9c3b7fbc06 src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java bc3f364a8d49c0b8efb1164efedd6e0a8e9182c8 src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java a3a7c98056b48fba5e2acc3c6e428e4e6290c7da src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java e38fbd158798577dca721272f5a4455a2135f55d src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 54fc2a61bba1726f874e0cc89cadb2d5969c25d9 src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java 012f2b89d09649e70f14c66a1da02e97090868ca Diff: https://reviews.apache.org/r/37933/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 37825: Adding minimal implementation of the external tier config.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/#review97027
---
Ship it!
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java (line 74)
https://reviews.apache.org/r/37825/#comment152739
You might consider killing the TODO. There probably isn't a great way to
link to the correct documentation, as it would really need to be associated
with the version.
src/main/java/org/apache/aurora/scheduler/TierInfo.java (line 22)
https://reviews.apache.org/r/37825/#comment152742
Totally nit-picking - `TierInfo.DEFAULT_TIER` is a bit redundant, as the
containing class and the field type already contain 'tier'. Consider
`TierInfo.DEFAULT`, and skip the static import where it's used to keep the
context.
src/main/java/org/apache/aurora/scheduler/TierManager.java (line 49)
https://reviews.apache.org/r/37825/#comment152741
You could avoid the annotation with this mapper setting:
```
ObjectMapper mapper = new ObjectMapper();
mapper.setVisibilityChecker(
mapper.getVisibilityChecker().withFieldVisibility(Visibility.ANY));
```
However, the advice below would also remove it and is IMHO a slightly
better approach.
src/main/java/org/apache/aurora/scheduler/TierManager.java (line 54)
https://reviews.apache.org/r/37825/#comment152740
You could avoid the supplier/memoization and instead use a traditional
constructor with annotations:
```
static final TierConfig EMPTY = new TierConfig(ImmutableMap.of());
private final MapString, TierInfo tiers;
@JsonCreator
TierConfig(@JsonProperty(tiers) MapString, TierInfo tiers) {
this.tiers = ImmutableMap.copyOf(tiers);
}
```
I like this since the 'JSON-ness' is completely isolated to the constructor.
- Bill Farner
On Aug. 29, 2015, 11:34 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/
---
(Updated Aug. 29, 2015, 11:34 a.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1437
https://issues.apache.org/jira/browse/AURORA-1437
Repository: aurora
Description
---
The external config file is optional for now as tiers are not fully defined
yet.
Diffs
-
examples/vagrant/upstart/aurora-scheduler-kerberos.conf
744b4a35c61e749734e222b3d4cbd296927665aa
examples/vagrant/upstart/aurora-scheduler.conf
789a3a0315e8530880999432aa9b1e7d0f57d1ff
src/jmh/java/org/apache/aurora/benchmark/Offers.java
26bad1cce987ef7f46368a5936cf056aeb2f63b1
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca
src/main/java/org/apache/aurora/scheduler/TierInfo.java
61bf30a7f11d2d4b9e49c58a6ed9ecd779d7e5ba
src/main/java/org/apache/aurora/scheduler/TierManager.java
652afece17a7eb09b0ca68066707b1b8fbf024f0
src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java
d7f3c60d383cf10afb0c0fcf4fe29972b183458c
src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java
399f58de6196b97abd359ecef8131b63480d591a
src/test/java/org/apache/aurora/scheduler/ResourcesTest.java
eb1baedcb13c2f169d819d137f22cb8b88db149c
src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java
PRE-CREATION
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java
eb0207114e1b93968cb65832f154a9cd3bc3232e
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
adcc7a823ecf30442016ecbdd655622d6aeba65e
src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
819b51e4c314749dc48db25693503af7d1ed0c54
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
d8a524d98771ee68d7b4d423fb34e28101a04d27
src/test/resources/org/apache/aurora/scheduler/tiers-example.json
PRE-CREATION
Diff: https://reviews.apache.org/r/37825/diff/
Testing
---
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 37936: Upgrade to Guava 18
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37936/#review97047 --- Master (4899e2d) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 31, 2015, 12:29 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37936/ --- (Updated Aug. 31, 2015, 12:29 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-586 https://issues.apache.org/jira/browse/AURORA-586 Repository: aurora Description --- Upgrades the Gauva dep to 18. Full release notes can be found here: * https://code.google.com/p/guava-libraries/wiki/Release17 * https://code.google.com/p/guava-libraries/wiki/Release18 Relevant changes are the introduction of `MoreObjects`, removal of `InputSupplier` and `OutputSupplier` interfaces and replacing `MoreExecutors.sameThreadExecutor()` with `MoreExecutors.newDirectExecutorService()`. Diffs - build.gradle 7b9a0822b43a7f3e44cdc096234eece3ddf2a116 commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java e8e64478c71e0de18c263a8924e75e009c8aee2f commons/src/main/java/org/apache/aurora/common/net/http/handlers/AssetHandler.java a514f142e14412d2638dfcacf301835857677fc3 commons/src/test/java/org/apache/aurora/common/net/http/handlers/AssetHandlerTest.java d82816bea6bc9171df989d80ce1d764726cf4097 src/main/java/org/apache/aurora/scheduler/HostOffer.java 5056b60c32ab1c8f1b8d682be4827c489da2a104 src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 11d4a0870505e45422f87f0c06ed8cd06b505a3b src/main/java/org/apache/aurora/scheduler/TierInfo.java 61bf30a7f11d2d4b9e49c58a6ed9ecd779d7e5ba src/main/java/org/apache/aurora/scheduler/base/Query.java 458530fb216fd37048d3e398c07b147a1a71cf57 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 46e89cd51750b92a1e4afcdb03cba0ff22a24109 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 298ac74a0909beb7f8e6da4990c8936ff499b9d7 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 260e11e910e97c1057351c206f0f763c04d4502a src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionProposal.java d598b02b68c5d67610004cbd5eeefab2e9658b69 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8f3161acdab0e2d25403ee224cd6468327ee956f src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 3e258127f452070214d5e9df9da25f5b38d0d886 src/main/java/org/apache/aurora/scheduler/spi/Permissions.java b9dff4471fe6bc6b793f7fb15de3a5c2e2d39209 src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java 6928c663d9f3f46ab81816d3d0ef4e7d0485e368 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 0a1a2925385374dd070b024e7bf2887969b3da37 src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 5b1e2b90601720cd0d9934940513bbecc48b4863 src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java 3f4924266e863587fcc8c44df9cb73b6e1e29259 Diff: https://reviews.apache.org/r/37936/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Review Request 37936: Upgrade to Guava 18
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37936/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-586 https://issues.apache.org/jira/browse/AURORA-586 Repository: aurora Description --- Upgrades the Gauva dep to 18. Full release notes can be found here: * https://code.google.com/p/guava-libraries/wiki/Release17 * https://code.google.com/p/guava-libraries/wiki/Release18 Relevant changes are the introduction of `MoreObjects`, removal of `InputSupplier` and `OutputSupplier` interfaces and replacing `MoreExecutors.sameThreadExecutor()` with `MoreExecutors.newDirectExecutorService()`. Diffs - build.gradle 7b9a0822b43a7f3e44cdc096234eece3ddf2a116 commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java e8e64478c71e0de18c263a8924e75e009c8aee2f commons/src/main/java/org/apache/aurora/common/net/http/handlers/AssetHandler.java a514f142e14412d2638dfcacf301835857677fc3 commons/src/test/java/org/apache/aurora/common/net/http/handlers/AssetHandlerTest.java d82816bea6bc9171df989d80ce1d764726cf4097 src/main/java/org/apache/aurora/scheduler/HostOffer.java 5056b60c32ab1c8f1b8d682be4827c489da2a104 src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 11d4a0870505e45422f87f0c06ed8cd06b505a3b src/main/java/org/apache/aurora/scheduler/TierInfo.java 61bf30a7f11d2d4b9e49c58a6ed9ecd779d7e5ba src/main/java/org/apache/aurora/scheduler/base/Query.java 458530fb216fd37048d3e398c07b147a1a71cf57 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 46e89cd51750b92a1e4afcdb03cba0ff22a24109 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 298ac74a0909beb7f8e6da4990c8936ff499b9d7 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 260e11e910e97c1057351c206f0f763c04d4502a src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionProposal.java d598b02b68c5d67610004cbd5eeefab2e9658b69 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8f3161acdab0e2d25403ee224cd6468327ee956f src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 3e258127f452070214d5e9df9da25f5b38d0d886 src/main/java/org/apache/aurora/scheduler/spi/Permissions.java b9dff4471fe6bc6b793f7fb15de3a5c2e2d39209 src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java 6928c663d9f3f46ab81816d3d0ef4e7d0485e368 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 0a1a2925385374dd070b024e7bf2887969b3da37 src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 5b1e2b90601720cd0d9934940513bbecc48b4863 src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java 3f4924266e863587fcc8c44df9cb73b6e1e29259 Diff: https://reviews.apache.org/r/37936/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 37937: Remove barely used commons classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37937/#review97057 --- Ship it! Awesome! - Bill Farner On Aug. 30, 2015, 9:37 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37937/ --- (Updated Aug. 30, 2015, 9:37 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This patch removes a few barely used or duplicate classes from commons. Diffs - commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 2e22a9244cabe2547149074efbf68ac23902fdf8 commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunction.java f867c350eb7df330fc5913605a0a8099b13cf78c commons/src/main/java/org/apache/aurora/common/base/Function.java d089eb8c3b1eb6ad1617606309624be1fa8bdd5b commons/src/main/java/org/apache/aurora/common/base/MoreSuppliers.java 9ab877d63937a9e8a2741ef30acbd69362c9815b commons/src/main/java/org/apache/aurora/common/base/Supplier.java cb6e86a9ef1b9450a9cde9a252b9b1be1dd6eac5 commons/src/main/java/org/apache/aurora/common/io/FileUtils.java 348e85918dc0c6de5fb517e22b24dd8d0b940e32 commons/src/main/java/org/apache/aurora/common/logging/Log.java 3f045f763720ea6569b38b7c13210d208c38356a commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java 9d9fb9bff09511eade9d8556dda3327ff191ae0d commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogPrinter.java b014e418e82f19494f97c076d20f44f4631ec4fb commons/src/main/java/org/apache/aurora/common/testing/junit/rules/Retry.java 3b97118c2cef8d34a5aa4579e7f4b01f221e400b commons/src/main/java/org/apache/aurora/common/util/StartWatch.java 4d19ed637cf62bd71296e687549d3dfaa3f6f312 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java cb0f3ec2b8850dea0758c5a209da022778657e71 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 18aff9f04f073f6f2860d9c5040bec0a5fec6215 commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java db9e5ca532c0a7fd07ee60cfd79b54c5e2d59353 commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java dc83f7445721ac941affdd9a9895bbc2f1750fb9 commons/src/test/java/org/apache/aurora/common/base/MoreSuppliersTest.java a655f597c7e787a1ef25d0463028387521733950 commons/src/test/java/org/apache/aurora/common/io/FileUtilsTest.java a043451cf12ebbf57b8ed7832b77916b0b81a8c2 commons/src/test/java/org/apache/aurora/common/net/http/handlers/LogPrinterTest.java 2422d7d6dcffa60f337c76ee1bdf4b5e9e6b4db7 commons/src/test/java/org/apache/aurora/common/stats/RateTest.java 15bd65bafd1cee9a30825f102195fb962471c357 commons/src/test/java/org/apache/aurora/common/testing/junit/rules/RetryTest.java 43be9dfcea8dba237e3ab1ca8d4a67c2cccd commons/src/test/java/org/apache/aurora/common/util/BackoffHelperTest.java 6bf71cfd52d51471844d52f90ffcc792bd57 commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 09d9016b7aa8dc5c6ee5b4363107cb75a63722bf src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 67788223bc6ef4a9c1837ce636160c191cd86a74 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 0c59b2dbeaf32964e21b5e837ea95b8a9789a0de src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 05af127a91b6c0e8db089cb828c38e556b07d45f src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 906f3e622b8cd30e21d51c1fa7aa16e97ddd6443 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ed639b6c20a3a51aa829cacb8e5b30265600c9cd src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java cc74d978e5cd74f5be9e2cd54cda693d6f56d9bc src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 6ac0696f0bec46efec263be2ee13ce76df85dd3e Diff: https://reviews.apache.org/r/37937/diff/ Testing --- ./gradlew -Pq Thanks, Zameer Manji
Re: Review Request 37937: Remove barely used commons classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37937/#review97054 --- Master (68447b3) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 31, 2015, 4:20 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37937/ --- (Updated Aug. 31, 2015, 4:20 a.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This patch removes a few barely used or duplicate classes from commons. Diffs - commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 2e22a9244cabe2547149074efbf68ac23902fdf8 commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunction.java f867c350eb7df330fc5913605a0a8099b13cf78c commons/src/main/java/org/apache/aurora/common/base/Function.java d089eb8c3b1eb6ad1617606309624be1fa8bdd5b commons/src/main/java/org/apache/aurora/common/base/MoreSuppliers.java 9ab877d63937a9e8a2741ef30acbd69362c9815b commons/src/main/java/org/apache/aurora/common/base/Supplier.java cb6e86a9ef1b9450a9cde9a252b9b1be1dd6eac5 commons/src/main/java/org/apache/aurora/common/io/FileUtils.java 348e85918dc0c6de5fb517e22b24dd8d0b940e32 commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java 9d9fb9bff09511eade9d8556dda3327ff191ae0d commons/src/main/java/org/apache/aurora/common/testing/junit/rules/Retry.java 3b97118c2cef8d34a5aa4579e7f4b01f221e400b commons/src/main/java/org/apache/aurora/common/util/StartWatch.java 4d19ed637cf62bd71296e687549d3dfaa3f6f312 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java cb0f3ec2b8850dea0758c5a209da022778657e71 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 18aff9f04f073f6f2860d9c5040bec0a5fec6215 commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java db9e5ca532c0a7fd07ee60cfd79b54c5e2d59353 commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java dc83f7445721ac941affdd9a9895bbc2f1750fb9 commons/src/test/java/org/apache/aurora/common/base/MoreSuppliersTest.java a655f597c7e787a1ef25d0463028387521733950 commons/src/test/java/org/apache/aurora/common/io/FileUtilsTest.java a043451cf12ebbf57b8ed7832b77916b0b81a8c2 commons/src/test/java/org/apache/aurora/common/stats/RateTest.java 15bd65bafd1cee9a30825f102195fb962471c357 commons/src/test/java/org/apache/aurora/common/testing/junit/rules/RetryTest.java 43be9dfcea8dba237e3ab1ca8d4a67c2cccd commons/src/test/java/org/apache/aurora/common/util/BackoffHelperTest.java 6bf71cfd52d51471844d52f90ffcc792bd57 commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 09d9016b7aa8dc5c6ee5b4363107cb75a63722bf src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 67788223bc6ef4a9c1837ce636160c191cd86a74 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 0c59b2dbeaf32964e21b5e837ea95b8a9789a0de src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 05af127a91b6c0e8db089cb828c38e556b07d45f src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 906f3e622b8cd30e21d51c1fa7aa16e97ddd6443 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ed639b6c20a3a51aa829cacb8e5b30265600c9cd src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java cc74d978e5cd74f5be9e2cd54cda693d6f56d9bc src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 6ac0696f0bec46efec263be2ee13ce76df85dd3e Diff: https://reviews.apache.org/r/37937/diff/ Testing --- ./gradlew -Pq Thanks, Zameer Manji
