Re: Review Request 37818: Moved executor settings configuration to loadable JSON

[Renan DelValle]

> On Sept. 1, 2015, 2:35 a.m., Bill Farner wrote:
> > examples/vagrant/executors-config.json, line 1
> > 
> >
> > Can you expand this example to include the command executor?  That's 
> > likely to be the first non-default executor folks will want to try.

Sure thing. Although, be advised that the functionality for custom executors is 
not included in this patch. This patch only lays the ground work. The next 
patch will include the ability to actually select them and run them.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37818/#review97231
---


On Sept. 1, 2015, 12:37 a.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37818/
> ---
> 
> (Updated Sept. 1, 2015, 12:37 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is the first stage in a series of patches to create support for custom 
> executors. In an effort to expedite the review process, I have decided to 
> break down my patch into multiple pieces that when/if commited won't break 
> the trunk.
> 
> This patch includes the ability to load configuration from a JSON file. A 
> JSON example file is included in examples/vagrant/executors-config.json
> 
> Command line arguments have been eliminated and moved over to the JSON file. 
> GSON is leveraged and does most of the work with the aid of a few custom 
> deserializers that were needed. 
> 
> Note that right now a global container mount that does not follow 
> specification will cause the scheduler to detect the error an exit early. It 
> is up for discussion if this is the desired behavior or if we should just 
> ignore said mount.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/executors-config.json PRE-CREATION 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 4f43892723db4744db205ea7dd107e9e9ce9d5db 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> e909451892f117e9e6eb80994079661827a0914c 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> c210c0db07bb1f4b3f76668178dcd7e2de56a4ac 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 197184b6edc0768d677636341b5737f262abdf7d 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0c440b5cd5b939872c1ee05d048bf739bfa977cb 
>   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
> aa5ce8b2f14c7dbd0eae120018ee41387c26059f 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
> b3c913892248e4a9a8111412307463985f5ca97f 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> f6ba2c40aea555d3e0ab774218bfe08d7e1c984b 
>   src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 
> 6fad3344042dc6a75cdf74ce79d388fcd4fc9861 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 1a25924d789295c5950947f5e302e1d1fbec68f2 
>   src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
> cd0295780d41bc4e914583f195b37eaed28a46dc 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoaderTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> dddf7952d3f0e508cd736d5fb95e573267708d43 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
> d0987251b058988fcbfab16c1b138c37e0c5b8c6 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor-settings-thermos-no-observer.json
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/no-value-URI.json
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/thermos-settings-example.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37818/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh: directory sandbox failed but it may be a 
> flaky test
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 38014: Remove StartupRegistry.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review97319
---


Reviewer notes


commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 


This is replaced by invoking the @AppStartup service manager in 
SchedulerMain.



commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 


This was moved to SchedulerMain



commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
 


TimeSeriesRepositoryImpl is now a service



commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 


I don't think there's much value behind gating sampling here while shutting 
down.



src/main/java/org/apache/aurora/GuavaUtils.java (lines 115 - 124)


Moved this from AppModule, but i'm not convinced it's valuable.  It seems 
to suggest that we don't have confidence in logging elsewhere in the scheduler 
about why we are tearing down.



src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 


This is now done in SchedulerMain.


- Bill Farner


On Sept. 1, 2015, 11:42 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 1, 2015, 11:42 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> e3e90e3e43744463a2f00552f0041d0d1945bd57 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 1a25924d789295c5950947f5e302e1d1fbec68f2 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 37926: Adding oversubscription e2e tests.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/
---

(Updated Sept. 1, 2015, 5:15 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Bill's comments.


Repository: aurora


Description
---

Also, had to backout client tier validation added earlier until the feature 
exits beta.


Diffs (updated)
-

  examples/vagrant/upstart/aurora-scheduler.conf 
e909451892f117e9e6eb80994079661827a0914c 
  examples/vagrant/upstart/mesos-slave.conf 
2b6a60673fc0a7ea3b73471701cd5d3efd6ce639 
  src/main/java/org/apache/aurora/scheduler/http/Offers.java 
4329ce10189df41a7a45cd6cc369333d7d5f65b0 
  src/main/python/apache/aurora/client/config.py 
f5ac084ae5b448221363add9476334742b217b92 
  src/test/python/apache/aurora/client/test_config.py 
37459f5218e76fac831601806a0331927c0ee2c0 
  src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
c1a10d8ea60be6aa56e4517fb34288d7d5ae1480 
  src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 
870b3e68035fdf86253cf9b92b606645134b3369 
  src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora 
e55aad3a58d4e3c19332e06b70771f51f07aa9b7 
  src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
423dd4d4e8b03c2f852e25acd9340bd6288b7d24 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
018efbe43de0c829799bc2f789958c55b1cb61a4 

Diff: https://reviews.apache.org/r/37926/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 37926: Adding oversubscription e2e tests.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97308
---


Master (f285647) is red with this patch.
  ./build-support/jenkins/build.sh

page = self.process_index(url, page)

  File "/usr/lib/python2.7/dist-packages/setuptools/package_index.py", line 
405, in process_index

self.scan_url(new_url)

  File "/usr/lib/python2.7/dist-packages/setuptools/package_index.py", line 
769, in scan_url

self.process_url(url, True)

  File "/usr/lib/python2.7/dist-packages/setuptools/package_index.py", line 
313, in process_url

page = f.read()

  File "/usr/lib/python2.7/socket.py", line 351, in read

data = self._sock.recv(rbufsize)

  File "/usr/lib/python2.7/httplib.py", line 543, in read

return self._read_chunked(amt)

  File "/usr/lib/python2.7/httplib.py", line 603, in _read_chunked

value.append(self._safe_read(amt))

  File "/usr/lib/python2.7/httplib.py", line 658, in _safe_read

chunk = self.fp.read(min(amt, MAXAMOUNT))

  File "/usr/lib/python2.7/socket.py", line 380, in read

data = self._sock.recv(left)

socket.timeout: timed out


Cleaning up...
Command python setup.py egg_info failed with error code 1 in 
/tmp/user/2395/pip_build_jenkins/protobuf
Storing debug log for failure in /home/jenkins/.pip/pip.log


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 1, 2015, 5:15 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> ---
> 
> (Updated Sept. 1, 2015, 5:15 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Also, had to backout client tier validation added earlier until the feature 
> exits beta.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> e909451892f117e9e6eb80994079661827a0914c 
>   examples/vagrant/upstart/mesos-slave.conf 
> 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> 4329ce10189df41a7a45cd6cc369333d7d5f65b0 
>   src/main/python/apache/aurora/client/config.py 
> f5ac084ae5b448221363add9476334742b217b92 
>   src/test/python/apache/aurora/client/test_config.py 
> 37459f5218e76fac831601806a0331927c0ee2c0 
>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
> c1a10d8ea60be6aa56e4517fb34288d7d5ae1480 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 
> 870b3e68035fdf86253cf9b92b606645134b3369 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora 
> e55aad3a58d4e3c19332e06b70771f51f07aa9b7 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
> 423dd4d4e8b03c2f852e25acd9340bd6288b7d24 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 018efbe43de0c829799bc2f789958c55b1cb61a4 
> 
> Diff: https://reviews.apache.org/r/37926/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/
---

(Updated Sept. 1, 2015, 5:29 p.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Changes
---

Apparently gradle task names are case sensitive!


Repository: aurora


Description
---

Stop in-progress instances from pulsing when update has been aborted.

Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and 
added "ABORTED" to the tooltip for instances that were "UPDATING" when the 
update was aborted. An argument can be made for adding "ABORTED" to the tooltip 
for all non-terminal states (PENDING, etc.), let me know if you think we should 
add it for those as well.


Diffs (updated)
-

  src/main/resources/scheduler/assets/css/app.css 
9437c53e695d1c4009d9df5fb23e34479f5b3d2d 
  src/main/resources/scheduler/assets/js/directives.js 
d8f722c441b9399e7eacd6ae29966b3fb24a422d 
  src/main/resources/scheduler/assets/update.html 
c8867093338593e5561e42fdee7cc5f15be0356e 

Diff: https://reviews.apache.org/r/38010/diff/


Testing
---

./gradlew jshint

Verified the pulsing stops for an aborted update. Also see screenshot for 
tooltip changes.


File Attachments


Screen Shot 2015-09-01 at 12.08.51 PM.png
  
https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png


Thanks,

Joshua Cohen

Re: Review Request 38014: Remove StartupRegistry.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review97322
---



src/main/java/org/apache/aurora/GuavaUtils.java (lines 114 - 124)


Rather than change the purpose of this class from a dumb adapter that makes 
`ServiceManager` mockable, consider adding a `Listener` to `ServiceManager` and 
overriding `stopped`. This fits the canonical example of ServiceManager API 
usage.



src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 


Is this shutdown timeout preserved anywhere? Seems this should move to a 
`Listener` on the below providers.


- Kevin Sweeney


On Sept. 1, 2015, 11:59 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 1, 2015, 11:59 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> e3e90e3e43744463a2f00552f0041d0d1945bd57 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 1a25924d789295c5950947f5e302e1d1fbec68f2 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 37926: Adding oversubscription e2e tests.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97325
---

Ship it!


Master (5a7bd34) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 1, 2015, 5:15 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> ---
> 
> (Updated Sept. 1, 2015, 5:15 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Also, had to backout client tier validation added earlier until the feature 
> exits beta.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> e909451892f117e9e6eb80994079661827a0914c 
>   examples/vagrant/upstart/mesos-slave.conf 
> 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> 4329ce10189df41a7a45cd6cc369333d7d5f65b0 
>   src/main/python/apache/aurora/client/config.py 
> f5ac084ae5b448221363add9476334742b217b92 
>   src/test/python/apache/aurora/client/test_config.py 
> 37459f5218e76fac831601806a0331927c0ee2c0 
>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
> c1a10d8ea60be6aa56e4517fb34288d7d5ae1480 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 
> 870b3e68035fdf86253cf9b92b606645134b3369 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora 
> e55aad3a58d4e3c19332e06b70771f51f07aa9b7 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
> 423dd4d4e8b03c2f852e25acd9340bd6288b7d24 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 018efbe43de0c829799bc2f789958c55b1cb61a4 
> 
> Diff: https://reviews.apache.org/r/37926/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/#review97307
---


Master (f285647) is red with this patch.
  ./build-support/jenkins/build.sh

Note: Recompile with -Xlint:unchecked for details.

:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
'JobUpdateStatus' is not defined. 
(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/directives.js:173:42)
> var aborted = scope.status === JobUpdateStatus.ABORTED;

:jsHint FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':jsHint'.
> Process 'command 
> '/home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk1.8.0_45/bin/java'' 
> finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 33.774 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 1, 2015, 5:17 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38010/
> ---
> 
> (Updated Sept. 1, 2015, 5:17 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stop in-progress instances from pulsing when update has been aborted.
> 
> Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and 
> added "ABORTED" to the tooltip for instances that were "UPDATING" when the 
> update was aborted. An argument can be made for adding "ABORTED" to the 
> tooltip for all non-terminal states (PENDING, etc.), let me know if you think 
> we should add it for those as well.
> 
> 
> Diffs
> -
> 
>   src/main/resources/scheduler/assets/css/app.css 
> 9437c53e695d1c4009d9df5fb23e34479f5b3d2d 
>   src/main/resources/scheduler/assets/js/directives.js 
> d8f722c441b9399e7eacd6ae29966b3fb24a422d 
>   src/main/resources/scheduler/assets/update.html 
> c8867093338593e5561e42fdee7cc5f15be0356e 
> 
> Diff: https://reviews.apache.org/r/38010/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jshint
> 
> Verified the pulsing stops for an aborted update. Also see screenshot for 
> tooltip changes.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2015-09-01 at 12.08.51 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 37926: Adding oversubscription e2e tests.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97315
---


@ReviewBot retry

- Maxim Khutornenko


On Sept. 1, 2015, 5:15 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> ---
> 
> (Updated Sept. 1, 2015, 5:15 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Also, had to backout client tier validation added earlier until the feature 
> exits beta.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> e909451892f117e9e6eb80994079661827a0914c 
>   examples/vagrant/upstart/mesos-slave.conf 
> 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> 4329ce10189df41a7a45cd6cc369333d7d5f65b0 
>   src/main/python/apache/aurora/client/config.py 
> f5ac084ae5b448221363add9476334742b217b92 
>   src/test/python/apache/aurora/client/test_config.py 
> 37459f5218e76fac831601806a0331927c0ee2c0 
>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
> c1a10d8ea60be6aa56e4517fb34288d7d5ae1480 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 
> 870b3e68035fdf86253cf9b92b606645134b3369 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora 
> e55aad3a58d4e3c19332e06b70771f51f07aa9b7 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
> 423dd4d4e8b03c2f852e25acd9340bd6288b7d24 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 018efbe43de0c829799bc2f789958c55b1cb61a4 
> 
> Diff: https://reviews.apache.org/r/37926/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/#review97323
---

Ship it!


Ship It!

- David McLaughlin


On Sept. 1, 2015, 5:29 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38010/
> ---
> 
> (Updated Sept. 1, 2015, 5:29 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stop in-progress instances from pulsing when update has been aborted.
> 
> Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and 
> added "ABORTED" to the tooltip for instances that were "UPDATING" when the 
> update was aborted. An argument can be made for adding "ABORTED" to the 
> tooltip for all non-terminal states (PENDING, etc.), let me know if you think 
> we should add it for those as well.
> 
> 
> Diffs
> -
> 
>   src/main/resources/scheduler/assets/css/app.css 
> 9437c53e695d1c4009d9df5fb23e34479f5b3d2d 
>   src/main/resources/scheduler/assets/js/directives.js 
> d8f722c441b9399e7eacd6ae29966b3fb24a422d 
>   src/main/resources/scheduler/assets/update.html 
> c8867093338593e5561e42fdee7cc5f15be0356e 
> 
> Diff: https://reviews.apache.org/r/38010/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jshint
> 
> Verified the pulsing stops for an aborted update. Also see screenshot for 
> tooltip changes.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2015-09-01 at 12.08.51 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/
---

Review request for Aurora, David McLaughlin and Bill Farner.


Repository: aurora


Description
---

Stop in-progress instances from pulsing when update has been aborted.

Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and 
added "ABORTED" to the tooltip for instances that were "UPDATING" when the 
update was aborted. An argument can be made for adding "ABORTED" to the tooltip 
for all non-terminal states (PENDING, etc.), let me know if you think we should 
add it for those as well.


Diffs
-

  src/main/resources/scheduler/assets/css/app.css 
9437c53e695d1c4009d9df5fb23e34479f5b3d2d 
  src/main/resources/scheduler/assets/js/directives.js 
d8f722c441b9399e7eacd6ae29966b3fb24a422d 
  src/main/resources/scheduler/assets/update.html 
c8867093338593e5561e42fdee7cc5f15be0356e 

Diff: https://reviews.apache.org/r/38010/diff/


Testing
---

./gradlew jshint

Verified the pulsing stops for an aborted update. Also see screenshot for 
tooltip changes.


File Attachments


Screen Shot 2015-09-01 at 12.08.51 PM.png
  
https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png


Thanks,

Joshua Cohen

Review Request 38014: Remove StartupRegistry.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/
---

Review request for Aurora, Kevin Sweeney and Zameer Manji.


Repository: aurora


Description
---

Remove StartupRegistry.


Diffs
-

  commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
78ed7d0aae50c976eba9045b17587258edc588b0 
  
commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java 
997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
  commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
80509010f37894108881d40cad9d8ade8610f309 
  
commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
  
commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
 3959ce3d688dd50399185925d91f0014fc1c43f9 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java 
6928e48073d152915ca42b6f46236b21c0882086 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 387e379a9c84d663f2af23e4760754a023219860 
  config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
  src/main/java/org/apache/aurora/GuavaUtils.java 
e3e90e3e43744463a2f00552f0041d0d1945bd57 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
1077816b696c4d2e97aafa59900b6acf2adce064 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
6892a70042e25fd672475517325b4e4b69a0adab 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
8047622e206c9827e5cd8e40152a278d495bd0ff 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
1a25924d789295c5950947f5e302e1d1fbec68f2 
  
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
 4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
cb38c3e047efac483445f43b941c7eea8862cc9c 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
3f045ff38d672266ce2e2bb26f729b0ca4657e81 

Diff: https://reviews.apache.org/r/38014/diff/


Testing
---

test suite
./gradlew run
end-to-end tests


Thanks,

Bill Farner

Re: Review Request 38014: Remove StartupRegistry.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/
---

(Updated Sept. 1, 2015, 11:59 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

Addressing two regressions in the first patch.


Repository: aurora


Description
---

Remove StartupRegistry.


Diffs (updated)
-

  commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
78ed7d0aae50c976eba9045b17587258edc588b0 
  
commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java 
997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
  commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
80509010f37894108881d40cad9d8ade8610f309 
  
commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
  
commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
 3959ce3d688dd50399185925d91f0014fc1c43f9 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java 
6928e48073d152915ca42b6f46236b21c0882086 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 387e379a9c84d663f2af23e4760754a023219860 
  config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
  src/main/java/org/apache/aurora/GuavaUtils.java 
e3e90e3e43744463a2f00552f0041d0d1945bd57 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
1077816b696c4d2e97aafa59900b6acf2adce064 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
6892a70042e25fd672475517325b4e4b69a0adab 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
8047622e206c9827e5cd8e40152a278d495bd0ff 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
1a25924d789295c5950947f5e302e1d1fbec68f2 
  
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
 4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
cb38c3e047efac483445f43b941c7eea8862cc9c 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
3f045ff38d672266ce2e2bb26f729b0ca4657e81 

Diff: https://reviews.apache.org/r/38014/diff/


Testing
---

test suite
./gradlew run
end-to-end tests


Thanks,

Bill Farner

Re: Review Request 38018: Fix link to update page for the update list.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38018/#review97342
---


Master (5a7bd34) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 1, 2015, 9:27 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38018/
> ---
> 
> (Updated Sept. 1, 2015, 9:27 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was missed when I added the instance page. The redirect in the instance 
> controller catches this, but it makes going back impossible (since you land 
> back on the instance page and immediately get redirected again).
> 
> 
> Diffs
> -
> 
>   src/main/resources/scheduler/assets/latestUpdates.html 
> 54bcdedf49ed852ab6eb0475250b81cb1ebc3b28 
> 
> Diff: https://reviews.apache.org/r/38018/diff/
> 
> 
> Testing
> ---
> 
> Verified link goes directly to the update page.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Review Request 38018: Fix link to update page for the update list.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38018/
---

Review request for Aurora and Zameer Manji.


Repository: aurora


Description
---

This was missed when I added the instance page. The redirect in the instance 
controller catches this, but it makes going back impossible (since you land 
back on the instance page and immediately get redirected again).


Diffs
-

  src/main/resources/scheduler/assets/latestUpdates.html 
54bcdedf49ed852ab6eb0475250b81cb1ebc3b28 

Diff: https://reviews.apache.org/r/38018/diff/


Testing
---

Verified link goes directly to the update page.


Thanks,

Joshua Cohen

Re: Review Request 38018: Fix link to update page for the update list.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38018/#review97340
---

Ship it!


Ship It!

- Zameer Manji


On Sept. 1, 2015, 2:27 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38018/
> ---
> 
> (Updated Sept. 1, 2015, 2:27 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was missed when I added the instance page. The redirect in the instance 
> controller catches this, but it makes going back impossible (since you land 
> back on the instance page and immediately get redirected again).
> 
> 
> Diffs
> -
> 
>   src/main/resources/scheduler/assets/latestUpdates.html 
> 54bcdedf49ed852ab6eb0475250b81cb1ebc3b28 
> 
> Diff: https://reviews.apache.org/r/38018/diff/
> 
> 
> Testing
> ---
> 
> Verified link goes directly to the update page.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Review Request 38039: Remove ExceptionalClosure interface.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38039/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Remove ExceptionalClosure interface.


Diffs
-

  commons/src/main/java/org/apache/aurora/common/base/Closure.java 
9467255b25977e68a3346d7b7825fe86aed9ba8c 
  commons/src/main/java/org/apache/aurora/common/base/ExceptionalClosure.java 
66b3314fdc93e2634d208603b1c72be00707d48d 
  commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java 
574ab4018e6d7c25e2de18d714d586c23b6a96bd 

Diff: https://reviews.apache.org/r/38039/diff/


Testing
---

./gradlew build


Thanks,

Zameer Manji

Re: Review Request 38039: Remove ExceptionalClosure interface.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38039/#review97397
---


Master (64c00f1) is red with this patch.
  ./build-support/jenkins/build.sh

Unknown file extension: 
commons/src/main/resources/org/apache/aurora/common/net/http/handlers/thrift.st
Unknown file extension: 
commons/src/main/resources/org/apache/aurora/common/net/http/handlers/logconfig.st
Unknown file extension: 
commons/src/main/resources/org/apache/aurora/common/net/http/handlers/logprinter.st
:commons:licenseMain UP-TO-DATE
:commons:licenseTest
Unknown file extension: 
commons/src/test/resources/org/apache/aurora/common/util/templating/template.st
:commons:licenseTest UP-TO-DATE
:commons:license UP-TO-DATE
:commons:compileTestJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/classes/test/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/classes/test/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/test/java/org/apache/aurora/common/collections/Iterables2Test.java
 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:commons:processTestResources
:commons:testClasses
:commons:test

org.apache.aurora.common.zookeeper.ServerSetImplTest > testOrdering FAILED
org.apache.aurora.common.net.pool.DynamicHostSet$MonitorException at 
ServerSetImplTest.java:162
Caused by: org.apache.aurora.common.zookeeper.Group$WatchException at 
ServerSetImplTest.java:162
Caused by: org.apache.aurora.common.zookeeper.Group$JoinException 
at ServerSetImplTest.java:162
Caused by: java.lang.InterruptedException at 
ServerSetImplTest.java:162

203 tests completed, 1 failed
:commons:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':commons:test'.
> There were failing tests. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 5 mins 20.053 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 2, 2015, 3:38 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38039/
> ---
> 
> (Updated Sept. 2, 2015, 3:38 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove ExceptionalClosure interface.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/base/Closure.java 
> 9467255b25977e68a3346d7b7825fe86aed9ba8c 
>   commons/src/main/java/org/apache/aurora/common/base/ExceptionalClosure.java 
> 66b3314fdc93e2634d208603b1c72be00707d48d 
>   commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java 
> 574ab4018e6d7c25e2de18d714d586c23b6a96bd 
> 
> Diff: https://reviews.apache.org/r/38039/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>