Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review98053 --- Ship it! NEWS (line 16)

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/ --- (Updated Sept. 8, 2015, 9:10 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98080 --- Ship it! Master (2773826) is green with this patch.

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/#review98069 --- This patch does not apply cleanly on master (2773826), do you need

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-08 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/#review98084 --- src/main/resources/scheduler/assets/js/controllers.js (line 183)

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-08 Thread Maxim Khutornenko
> On Sept. 8, 2015, 10:04 p.m., Maxim Khutornenko wrote: > > Waiting for the aforementioned rationale write up and related risk analysis > > (e.g.: non-stable mutable->immutable->mutable loop). > > Bill Farner wrote: > Working on that now, but i'm not sure exactly what you're looking for

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 8, 2015, 2:49 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98118 --- @ReviewBot retry - Bill Farner On Sept. 8, 2015, 4:21 p.m., Bill

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-08 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98111 --- Ship it! Ship It! - Kevin Sweeney On Sept. 8, 2015, 3:47 p.m.,

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 8, 2015, 4:21 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/ --- (Updated Sept. 8, 2015, 10:54 p.m.) Review request for Aurora, David

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/#review98106 --- This patch does not apply cleanly on master (2773826), do you need

Re: Review Request 38086: Add test environments for RPMs and debs.

2015-09-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38086/#review98135 --- Ping - Bill Farner On Sept. 2, 2015, 7:59 p.m., Bill Farner

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98137 --- Ship it! I'm not very familiar with this code but after a careful

Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-08 Thread Jeffrey Schroeder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38200/ --- Review request for Aurora. Bugs: AURORA-1484

Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38200/#review98140 --- Ship it! Master (2773826) is green with this patch.

Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38200/#review98147 --- Ship it! docs/deploying-aurora-scheduler.md (line 297)

Review Request 38202: Replace BoundedQueue with Guava's EvictingQueue.

2015-09-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38202/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-08 Thread Bill Farner
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote: > > examples/vagrant/executors-config.json, lines 4-7 > > > > > > The code later converts this array into a single command string. I > > suggest we just make this a

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review98023 --- Ship it! Master (2773826) is green with this patch.

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-08 Thread Maxim Khutornenko
> On Sept. 8, 2015, 3:55 p.m., Bill Farner wrote: > > Looks good! Holding back the ship until a `NEWS` entry is included in the > > patch. Thanks for reminding! Added. > On Sept. 8, 2015, 3:55 p.m., Bill Farner wrote: > >

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/#review98014 --- src/main/resources/scheduler/assets/js/controllers.js (line 178)

Re: Review Request 38202: Replace BoundedQueue with Guava's EvictingQueue.

2015-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38202/#review98149 --- Master (2773826) is red with this patch.