date:20160202

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117520
---



This is on master now.

- Zameer Manji


On Feb. 2, 2016, 3:24 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 3:24 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117519
---


Ship it!




Ship It!

- Zameer Manji


On Feb. 2, 2016, 3:24 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 3:24 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zhitao Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/
---

(Updated Feb. 2, 2016, 11:24 p.m.)


Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.


Changes
---

Put issue number in TODO.


Repository: aurora


Description
---

Make --announcer-enable optional no-op instead of removing it completely.

For easy upgrade purpose.


Diffs (updated)
-

  NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f4f5cd77b6444c225ec960c7e2cf5349a80bd344 

Diff: https://reviews.apache.org/r/43112/diff/


Testing
---

./pants test src/test/python/apache/aurora/executor:executor


Thanks,

Zhitao Li

Re: Review Request 43013: Move lifecycle documentation into separate file

2016-02-02 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43013/#review117518
---


Ship it!




Master (2f485e8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2016, 10:45 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43013/
> ---
> 
> (Updated Feb. 2, 2016, 10:45 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington, John Sirois, Kevin Sweeney, and 
> Brian Wickman.
> 
> 
> Bugs: AURORA-1068, AURORA-1262, AURORA-489, and AURORA-734
> https://issues.apache.org/jira/browse/AURORA-1068
> https://issues.apache.org/jira/browse/AURORA-1262
> https://issues.apache.org/jira/browse/AURORA-489
> https://issues.apache.org/jira/browse/AURORA-734
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> In addition to the move, a couple of releted additions and adjustements have 
> been made:
> 
> * slight reorganization
> * documentation of missing states (THROTTELD, DRAINING)
> * custom section on reconciliation
> * remark regarding the uniqueness of an instance
> * updated documentation of the teardown of a task (HTTPLifecycleConfig and 
> finalization_wait)
> 
> 
> Diffs
> -
> 
>   docs/README.md 8ebc06121c1fd985027bebfab4f0c7123b66a6bb 
>   docs/configuration-reference.md 995f70654c89829a092e7b745a8390459244325d 
>   docs/task-lifecycle.md PRE-CREATION 
>   docs/user-guide.md df63468ddacb4a584938cd502004e47876347253 
> 
> Diff: https://reviews.apache.org/r/43013/diff/
> 
> 
> Testing
> ---
> 
> Rendered version is available at 
> https://github.com/StephanErb/aurora/blob/tasklifecycle/docs/task-lifecycle.md
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117516
---


Ship it!




Master (2f485e8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2016, 9:51 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> ---
> 
> (Updated Feb. 2, 2016, 9:51 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 12400a77db71084e91fc9082132d1e601f8088f0 
>   examples/vagrant/clusters_direct.json PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 470b2d2339284de9246b35daa0af1c2b832c232d 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1b2ce4d44f3650d7136006ed12319cdf37ae353e 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 86366240a48ebb576f7e3e5406cbc207fcd8df59 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 21371d951f8c6e44c40f97793d6acd26d3ca5614 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 4c4caaf76ce9f529c834f33f786036022766044d 
>   src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
> PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1171dca4af01a11e684f0b7a63a50250a8da1d22 
> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 43013: Move lifecycle documentation into separate file

2016-02-02 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43013/#review117510
---


Ship it!




If others listed in `People` do not respond by this time tomorrow I'll submit 
this then.

- John Sirois


On Feb. 2, 2016, 3:45 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43013/
> ---
> 
> (Updated Feb. 2, 2016, 3:45 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington, John Sirois, Kevin Sweeney, and 
> Brian Wickman.
> 
> 
> Bugs: AURORA-1068, AURORA-1262, AURORA-489, and AURORA-734
> https://issues.apache.org/jira/browse/AURORA-1068
> https://issues.apache.org/jira/browse/AURORA-1262
> https://issues.apache.org/jira/browse/AURORA-489
> https://issues.apache.org/jira/browse/AURORA-734
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> In addition to the move, a couple of releted additions and adjustements have 
> been made:
> 
> * slight reorganization
> * documentation of missing states (THROTTELD, DRAINING)
> * custom section on reconciliation
> * remark regarding the uniqueness of an instance
> * updated documentation of the teardown of a task (HTTPLifecycleConfig and 
> finalization_wait)
> 
> 
> Diffs
> -
> 
>   docs/README.md 8ebc06121c1fd985027bebfab4f0c7123b66a6bb 
>   docs/configuration-reference.md 995f70654c89829a092e7b745a8390459244325d 
>   docs/task-lifecycle.md PRE-CREATION 
>   docs/user-guide.md df63468ddacb4a584938cd502004e47876347253 
> 
> Diff: https://reviews.apache.org/r/43013/diff/
> 
> 
> Testing
> ---
> 
> Rendered version is available at 
> https://github.com/StephanErb/aurora/blob/tasklifecycle/docs/task-lifecycle.md
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 43013: Move lifecycle documentation into separate file

2016-02-02 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43013/
---

(Updated Feb. 2, 2016, 11:45 p.m.)


Review request for Aurora, Jay Buffington, John Sirois, Kevin Sweeney, and 
Brian Wickman.


Changes
---

Review changes + minor fix to user-guide regarding now optional HTTP health 
checking requirements.


Bugs: AURORA-1068, AURORA-1262, AURORA-489, and AURORA-734
https://issues.apache.org/jira/browse/AURORA-1068
https://issues.apache.org/jira/browse/AURORA-1262
https://issues.apache.org/jira/browse/AURORA-489
https://issues.apache.org/jira/browse/AURORA-734


Repository: aurora


Description
---

In addition to the move, a couple of releted additions and adjustements have 
been made:

* slight reorganization
* documentation of missing states (THROTTELD, DRAINING)
* custom section on reconciliation
* remark regarding the uniqueness of an instance
* updated documentation of the teardown of a task (HTTPLifecycleConfig and 
finalization_wait)


Diffs (updated)
-

  docs/README.md 8ebc06121c1fd985027bebfab4f0c7123b66a6bb 
  docs/configuration-reference.md 995f70654c89829a092e7b745a8390459244325d 
  docs/task-lifecycle.md PRE-CREATION 
  docs/user-guide.md df63468ddacb4a584938cd502004e47876347253 

Diff: https://reviews.apache.org/r/43013/diff/


Testing
---

Rendered version is available at 
https://github.com/StephanErb/aurora/blob/tasklifecycle/docs/task-lifecycle.md


Thanks,

Stephan Erb

Re: Review Request 43013: Move lifecycle documentation into separate file

2016-02-02 Thread Stephan Erb



> On Feb. 2, 2016, 5:30 p.m., John Sirois wrote:
> > docs/configuration-reference.md, line 330
> > 
> >
> > Checking my understanding - did you get this from here?: 
> > https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/executor/thermos_task_runner.py#L317-L318

I would not claim to fully grasp Thermos, but yes, that's probably it. As 
additional evidence we have this comment from Brian 
https://issues.apache.org/jira/browse/AURORA-734 and personal experience with 
misbehaving processes.


> On Feb. 2, 2016, 5:30 p.m., John Sirois wrote:
> > docs/task-lifecycle.md, line 140
> > 
> >
> > Checking - the 1 hour figure comes from here?: 
> > https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java#L78-L83

Yes.


> On Feb. 2, 2016, 5:30 p.m., John Sirois wrote:
> > docs/task-lifecycle.md, line 12
> > 
> >
> > A note that clarifies some states are missing from the diagram is 
> > probably in order as is a new issue to update the diagram unless you intend 
> > to keep https://issues.apache.org/jira/browse/AURORA-489 open for that 
> > second step.

Added the note. I'll keep the linked issue open until the diagram is updated in 
a new review request coming soon-ish.


> On Feb. 2, 2016, 5:30 p.m., John Sirois wrote:
> > docs/task-lifecycle.md, line 41
> > 
> >
> > s/how/that/

Done.


> On Feb. 2, 2016, 5:30 p.m., John Sirois wrote:
> > docs/task-lifecycle.md, line 51
> > 
> >
> > s/world. `Or/world.`, or/

Done


> On Feb. 2, 2016, 5:30 p.m., John Sirois wrote:
> > docs/task-lifecycle.md, line 78
> > 
> >
> > This is out of date (If a ShellHealthChecker is configured then steps 
> > 2&3 are replaced by a new step 2), but this is also out of scope for your 
> > change here.  As you see fit.

AFAIK even if `ShellHealthChecker` is used for health checking, lifecycle is 
only controled via HTTP 
https://github.com/apache/aurora/blob/0d7f946f76e4600cec878e23d5b2a44702f9b4f6/src/main/python/apache/aurora/executor/http_lifecycle.py#L34


> On Feb. 2, 2016, 5:30 p.m., John Sirois wrote:
> > docs/task-lifecycle.md, line 113
> > 
> >
> > I'm not sure this sentence is needed.  By definition the production 
> > bit, as described above, leads to production preference and pre-emption of 
> > non-production.  "Important" is a bit of a loaded term.

Dropped.


> On Feb. 2, 2016, 5:30 p.m., John Sirois wrote:
> > docs/user-guide.md, line 5
> > 
> >
> > The [Job Lifecycle] could stay and be ppolated with a few sentences 
> > including a link off to the new task-lifecycle doc.  Something like: Jobs 
> > have a rich lifecycle that is described here, but in day to day use, you'll 
> > be primarily concerned with launching new jobs and updating existing ones...
> > 
> > That would lead into the [Task Updates] and [HTTP Health Checking and 
> > Graceful Shutdown] a little more cleanly and provide a natural spot to note 
> > the more detailed docs.

Good idea. to keep the user-guide intact for now.

My longterm goal is to get rid of the user-guide and replace it by a high-level 
description, a document on service discovery and a document on 
ports/healthchecking. But that will take more time and will not make it into 
0.12.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43013/#review117408
---


On Jan. 30, 2016, 9:41 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43013/
> ---
> 
> (Updated Jan. 30, 2016, 9:41 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington, John Sirois, Kevin Sweeney, and 
> Brian Wickman.
> 
> 
> Bugs: AURORA-1068, AURORA-1262, AURORA-489, and AURORA-734
> https://issues.apache.org/jira/browse/AURORA-1068
> https://issues.apache.org/jira/browse/AURORA-1262
> https://issues.apache.org/jira/browse/AURORA-489
> https://issues.apache.org/jira/browse/AURORA-734
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> In addition to the move, a couple of releted additions and adjustements have 
> been made:
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117507
---



Master (2f485e8) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2016, 10:13 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 10:13 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117505
---




src/main/python/apache/aurora/executor/bin/thermos_executor_main.py (line 62)


Please reference `AURORA-1606` here.


- Zameer Manji


On Feb. 2, 2016, 2:13 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 2:13 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Kunal Thakar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117504
---


Ship it!




Ship It!

- Kunal Thakar


On Feb. 2, 2016, 10:13 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 10:13 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zhitao Li



> On Feb. 2, 2016, 10:08 p.m., Bill Farner wrote:
> > Ship It!
> 
> Bill Farner wrote:
> Please also file a ticket to do the actual removal, make it a blocker for 
> https://issues.apache.org/jira/browse/AURORA-1586

https://issues.apache.org/jira/browse/AURORA-1606


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117494
---


On Feb. 2, 2016, 10:13 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 10:13 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117502
---


Ship it!




Ship It!

- Stephan Erb


On Feb. 2, 2016, 11:13 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 11:13 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zhitao Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/
---

(Updated Feb. 2, 2016, 10:13 p.m.)


Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.


Changes
---

Rebase to pick up NEWS change.


Repository: aurora


Description
---

Make --announcer-enable optional no-op instead of removing it completely.

For easy upgrade purpose.


Diffs (updated)
-

  NEWS 318979ed5e408e42df0c5a77c35a653f14bc7233 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f4f5cd77b6444c225ec960c7e2cf5349a80bd344 

Diff: https://reviews.apache.org/r/43112/diff/


Testing
---

./pants test src/test/python/apache/aurora/executor:executor


Thanks,

Zhitao Li

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Bill Farner



> On Feb. 2, 2016, 2:08 p.m., Bill Farner wrote:
> > Ship It!

Please also file a ticket to do the actual removal, make it a blocker for 
https://issues.apache.org/jira/browse/AURORA-1586


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117494
---


On Feb. 2, 2016, 2:07 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 2:07 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS b1713602c2531ac39fc97c2044e024c21808ad63 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117495
---



Please rebase against master to pickup NEWS reorganization.

- John Sirois


On Feb. 2, 2016, 3:07 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 3:07 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS b1713602c2531ac39fc97c2044e024c21808ad63 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117494
---


Ship it!




Ship It!

- Bill Farner


On Feb. 2, 2016, 2:07 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43112/
> ---
> 
> (Updated Feb. 2, 2016, 2:07 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make --announcer-enable optional no-op instead of removing it completely.
> 
> For easy upgrade purpose.
> 
> 
> Diffs
> -
> 
>   NEWS b1713602c2531ac39fc97c2044e024c21808ad63 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f4f5cd77b6444c225ec960c7e2cf5349a80bd344 
> 
> Diff: https://reviews.apache.org/r/43112/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/executor:executor
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-02-02 Thread Zhitao Li



> On Feb. 2, 2016, 9:31 p.m., Zhitao Li wrote:
> > Sorry for coming to this only after it's committed, but I think this might 
> > create trouble for operators during upgrade.
> > 
> > Because the new executor will not understand the `--announce-enable` flag 
> > and crashes, the operator has to coordinate disabling the flag from 
> > scheduler side first, and push executor. Also, during this window between 
> > scheduler upgrade and cluster-wise executor upgrade, announce might be 
> > broken.
> > 
> > Can I suggest to make this flag optional and no-op for the deprecation 
> > cycle (max of one version or 90 days according to recent email 
> > conversations), then remove this afterwards?
> 
> Bill Farner wrote:
> You could work around this with a script that wraps the executor, but 
> that would be overly-complicated.  Your suggestion sounds spot on.  I'm not 
> available at the moment to put together the patch, but i can review/ship!

https://reviews.apache.org/r/43112/ includes a quick patch.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42727/#review117482
---


On Jan. 26, 2016, 6:40 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42727/
> ---
> 
> (Updated Jan. 26, 2016, 6:40 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the --announcer-enable executor flag.
> 
> 
> Diffs
> -
> 
>   NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 57fa312ca6c007731fd88ace1bea507320d14700 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 69025dd85011751b1036615af9944a4f7693bb15 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
> 6214882cd60211b18fa4ce6f43442184b2dccac8 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 12726936ee85d2ee3dba19eb497873d7422886e6 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
>  8d4d90b18451d8a2cc7cbe2d25f64942d0045491 
> 
> Diff: https://reviews.apache.org/r/42727/diff/
> 
> 
> Testing
> ---
> 
> Running tests now.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Zhitao Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/
---

Review request for Aurora, Kunal Thakar, Bill Farner, and Zameer Manji.


Repository: aurora


Description
---

Make --announcer-enable optional no-op instead of removing it completely.

For easy upgrade purpose.


Diffs
-

  NEWS b1713602c2531ac39fc97c2044e024c21808ad63 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f4f5cd77b6444c225ec960c7e2cf5349a80bd344 

Diff: https://reviews.apache.org/r/43112/diff/


Testing
---

./pants test src/test/python/apache/aurora/executor:executor


Thanks,

Zhitao Li

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117488
---


Ship it!




Ship It!

- Zameer Manji


On Feb. 2, 2016, 1:51 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> ---
> 
> (Updated Feb. 2, 2016, 1:51 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 12400a77db71084e91fc9082132d1e601f8088f0 
>   examples/vagrant/clusters_direct.json PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 470b2d2339284de9246b35daa0af1c2b832c232d 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1b2ce4d44f3650d7136006ed12319cdf37ae353e 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 86366240a48ebb576f7e3e5406cbc207fcd8df59 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 21371d951f8c6e44c40f97793d6acd26d3ca5614 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 4c4caaf76ce9f529c834f33f786036022766044d 
>   src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
> PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1171dca4af01a11e684f0b7a63a50250a8da1d22 
> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117491
---


Ship it!




Thanks for adding the test coverage!

- Bill Farner


On Feb. 2, 2016, 1:51 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> ---
> 
> (Updated Feb. 2, 2016, 1:51 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 12400a77db71084e91fc9082132d1e601f8088f0 
>   examples/vagrant/clusters_direct.json PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 470b2d2339284de9246b35daa0af1c2b832c232d 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1b2ce4d44f3650d7136006ed12319cdf37ae353e 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 86366240a48ebb576f7e3e5406cbc207fcd8df59 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 21371d951f8c6e44c40f97793d6acd26d3ca5614 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 4c4caaf76ce9f529c834f33f786036022766044d 
>   src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
> PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1171dca4af01a11e684f0b7a63a50250a8da1d22 
> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Joshua Cohen



> On Feb. 2, 2016, 9:29 p.m., Bill Farner wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1172
> > 
> >
> > Nit - rather than track the class name `LeaderRedirectFilter`, refer to 
> > the behavior.

Fixed.


> On Feb. 2, 2016, 9:29 p.m., Bill Farner wrote:
> > examples/vagrant/upstart/aurora-scheduler-await-registration.conf, line 1
> > 
> >
> > Did you consider tearing down the master and restarting the scheduler 
> > instead?
> > 
> > ```
> > sudo stop mesos-master
> > sudo restart aurora-scheduler
> > ```

Ahh, yes, that's a bit simpler, thanks.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117471
---


On Feb. 2, 2016, 9:51 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> ---
> 
> (Updated Feb. 2, 2016, 9:51 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 12400a77db71084e91fc9082132d1e601f8088f0 
>   examples/vagrant/clusters_direct.json PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 470b2d2339284de9246b35daa0af1c2b832c232d 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1b2ce4d44f3650d7136006ed12319cdf37ae353e 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 86366240a48ebb576f7e3e5406cbc207fcd8df59 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 21371d951f8c6e44c40f97793d6acd26d3ca5614 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 4c4caaf76ce9f529c834f33f786036022766044d 
>   src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
> PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1171dca4af01a11e684f0b7a63a50250a8da1d22 
> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/
---

(Updated Feb. 2, 2016, 9:51 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Simplify end to end test.


Bugs: AURORA-1601
https://issues.apache.org/jira/browse/AURORA-1601


Repository: aurora


Description
---

Add header to allow bypassing the LeaderRedirectFilter.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
12400a77db71084e91fc9082132d1e601f8088f0 
  examples/vagrant/clusters_direct.json PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
  src/main/python/apache/aurora/admin/admin.py 
750b616dc9c4855733ddb2ff89c29d5a85af29af 
  src/main/python/apache/aurora/admin/aurora_admin.py 
470b2d2339284de9246b35daa0af1c2b832c232d 
  src/main/python/apache/aurora/client/api/__init__.py 
1b2ce4d44f3650d7136006ed12319cdf37ae353e 
  src/main/python/apache/aurora/client/api/scheduler_client.py 
86366240a48ebb576f7e3e5406cbc207fcd8df59 
  src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
21371d951f8c6e44c40f97793d6acd26d3ca5614 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
4c4caaf76ce9f529c834f33f786036022766044d 
  src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
PRE-CREATION 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
1171dca4af01a11e684f0b7a63a50250a8da1d22 

Diff: https://reviews.apache.org/r/42964/diff/


Testing
---

./gradlew build -Pq


Thanks,

Joshua Cohen

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-02-02 Thread Bill Farner



> On Feb. 2, 2016, 1:31 p.m., Zhitao Li wrote:
> > Sorry for coming to this only after it's committed, but I think this might 
> > create trouble for operators during upgrade.
> > 
> > Because the new executor will not understand the `--announce-enable` flag 
> > and crashes, the operator has to coordinate disabling the flag from 
> > scheduler side first, and push executor. Also, during this window between 
> > scheduler upgrade and cluster-wise executor upgrade, announce might be 
> > broken.
> > 
> > Can I suggest to make this flag optional and no-op for the deprecation 
> > cycle (max of one version or 90 days according to recent email 
> > conversations), then remove this afterwards?

You could work around this with a script that wraps the executor, but that 
would be overly-complicated.  Your suggestion sounds spot on.  I'm not 
available at the moment to put together the patch, but i can review/ship!


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42727/#review117482
---


On Jan. 26, 2016, 10:40 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42727/
> ---
> 
> (Updated Jan. 26, 2016, 10:40 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the --announcer-enable executor flag.
> 
> 
> Diffs
> -
> 
>   NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 57fa312ca6c007731fd88ace1bea507320d14700 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 69025dd85011751b1036615af9944a4f7693bb15 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
> 6214882cd60211b18fa4ce6f43442184b2dccac8 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 12726936ee85d2ee3dba19eb497873d7422886e6 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
>  8d4d90b18451d8a2cc7cbe2d25f64942d0045491 
> 
> Diff: https://reviews.apache.org/r/42727/diff/
> 
> 
> Testing
> ---
> 
> Running tests now.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 43109: Reorganize NEWS into updates and deprecations

2016-02-02 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43109/#review117485
---


Ship it!




Ship It!

- John Sirois


On Feb. 2, 2016, 2:33 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43109/
> ---
> 
> (Updated Feb. 2, 2016, 2:33 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've splitted all releases with additions and deprecations into too sections. 
> This should make it much easier to track past deprecations.
> 
> 
> Diffs
> -
> 
>   NEWS b1713602c2531ac39fc97c2044e024c21808ad63 
> 
> Diff: https://reviews.apache.org/r/43109/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 43109: Reorganize NEWS into updates and deprecations

2016-02-02 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43109/
---

(Updated Feb. 2, 2016, 10:33 p.m.)


Review request for Aurora and John Sirois.


Changes
---

Rebase.


Repository: aurora


Description
---

I've splitted all releases with additions and deprecations into too sections. 
This should make it much easier to track past deprecations.


Diffs (updated)
-

  NEWS b1713602c2531ac39fc97c2044e024c21808ad63 

Diff: https://reviews.apache.org/r/43109/diff/


Testing
---


Thanks,

Stephan Erb

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-02-02 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42727/#review117482
---

Sorry for coming to this only after it's committed, but I think this might 
create trouble for operators during upgrade.

Because the new executor will not understand the `--announce-enable` flag and 
crashes, the operator has to coordinate disabling the flag from scheduler side 
first, and push executor. Also, during this window between scheduler upgrade 
and cluster-wise executor upgrade, announce might be broken.

Can I suggest to make this flag optional and no-op for the deprecation cycle 
(max of one version or 90 days according to recent email conversations), then 
remove this afterwards?

- Zhitao Li

On Jan. 26, 2016, 6:40 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42727/
> ---
> 
> (Updated Jan. 26, 2016, 6:40 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the --announcer-enable executor flag.
> 
> 
> Diffs
> -
> 
>   NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 57fa312ca6c007731fd88ace1bea507320d14700 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 69025dd85011751b1036615af9944a4f7693bb15 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
> 6214882cd60211b18fa4ce6f43442184b2dccac8 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 12726936ee85d2ee3dba19eb497873d7422886e6 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
>  8d4d90b18451d8a2cc7cbe2d25f64942d0045491 
> 
> Diff: https://reviews.apache.org/r/42727/diff/
> 
> 
> Testing
> ---
> 
> Running tests now.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117471
---




api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 1172)


Nit - rather than track the class name `LeaderRedirectFilter`, refer to the 
behavior.



examples/vagrant/upstart/aurora-scheduler-await-registration.conf (line 1)


Did you consider tearing down the master and restarting the scheduler 
instead?

```
sudo stop mesos-master
sudo restart aurora-scheduler
```


- Bill Farner


On Feb. 2, 2016, 12:54 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> ---
> 
> (Updated Feb. 2, 2016, 12:54 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 12400a77db71084e91fc9082132d1e601f8088f0 
>   examples/vagrant/clusters_direct.json PRE-CREATION 
>   examples/vagrant/upstart/aurora-scheduler-await-registration.conf 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 470b2d2339284de9246b35daa0af1c2b832c232d 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1b2ce4d44f3650d7136006ed12319cdf37ae353e 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 86366240a48ebb576f7e3e5406cbc207fcd8df59 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 21371d951f8c6e44c40f97793d6acd26d3ca5614 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 4c4caaf76ce9f529c834f33f786036022766044d 
>   src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
> PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1171dca4af01a11e684f0b7a63a50250a8da1d22 
> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-02 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review117480
---


Ship it!




Master (3fc9dc2) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2016, 8:50 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> ---
> 
> (Updated Feb. 2, 2016, 8:50 p.m.)
> 
> 
> Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.
> 
> 
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Map Aurora task metadata to Mesos task labels
> 
> 
> Diffs
> -
> 
>   NEWS a6c2a906ee8e018cca756c1af0d20f221120d42f 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> cc2a4155008672056410086b05b6cc875485f669 
> 
> Diff: https://reviews.apache.org/r/35990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 43109: Reorganize NEWS into updates and deprecations

2016-02-02 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43109/#review117481
---



This patch does not apply cleanly against master (2a28cfc), do you need to 
rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2016, 9:17 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43109/
> ---
> 
> (Updated Feb. 2, 2016, 9:17 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've splitted all releases with additions and deprecations into too sections. 
> This should make it much easier to track past deprecations.
> 
> 
> Diffs
> -
> 
>   NEWS a6c2a906ee8e018cca756c1af0d20f221120d42f 
> 
> Diff: https://reviews.apache.org/r/43109/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 43109: Reorganize NEWS into updates and deprecations

2016-02-02 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43109/#review117478
---



This needs a rebase against master and then I can patch it in.

- John Sirois


On Feb. 2, 2016, 2:17 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43109/
> ---
> 
> (Updated Feb. 2, 2016, 2:17 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've splitted all releases with additions and deprecations into too sections. 
> This should make it much easier to track past deprecations.
> 
> 
> Diffs
> -
> 
>   NEWS a6c2a906ee8e018cca756c1af0d20f221120d42f 
> 
> Diff: https://reviews.apache.org/r/43109/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 43109: Reorganize NEWS into updates and deprecations

2016-02-02 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43109/#review117476
---


Ship it!




Ship It!

- John Sirois


On Feb. 2, 2016, 2:17 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43109/
> ---
> 
> (Updated Feb. 2, 2016, 2:17 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've splitted all releases with additions and deprecations into too sections. 
> This should make it much easier to track past deprecations.
> 
> 
> Diffs
> -
> 
>   NEWS a6c2a906ee8e018cca756c1af0d20f221120d42f 
> 
> Diff: https://reviews.apache.org/r/43109/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 43109: Reorganize NEWS into updates and deprecations

2016-02-02 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43109/
---

Review request for Aurora and John Sirois.


Repository: aurora


Description
---

I've splitted all releases with additions and deprecations into too sections. 
This should make it much easier to track past deprecations.


Diffs
-

  NEWS a6c2a906ee8e018cca756c1af0d20f221120d42f 

Diff: https://reviews.apache.org/r/43109/diff/


Testing
---


Thanks,

Stephan Erb

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117473
---


Ship it!




Master (3fc9dc2) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2016, 8:54 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> ---
> 
> (Updated Feb. 2, 2016, 8:54 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 12400a77db71084e91fc9082132d1e601f8088f0 
>   examples/vagrant/clusters_direct.json PRE-CREATION 
>   examples/vagrant/upstart/aurora-scheduler-await-registration.conf 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 470b2d2339284de9246b35daa0af1c2b832c232d 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1b2ce4d44f3650d7136006ed12319cdf37ae353e 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 86366240a48ebb576f7e3e5406cbc207fcd8df59 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 21371d951f8c6e44c40f97793d6acd26d3ca5614 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 4c4caaf76ce9f529c834f33f786036022766044d 
>   src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
> PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1171dca4af01a11e684f0b7a63a50250a8da1d22 
> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Joshua Cohen



> On Feb. 1, 2016, 8:40 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/admin/admin.py, line 72
> > 
> >
> > I think you can just do `options.bypass_leader_redirect` because there 
> > is a default.

Yep, fixed.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117260
---


On Feb. 2, 2016, 8:54 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> ---
> 
> (Updated Feb. 2, 2016, 8:54 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 12400a77db71084e91fc9082132d1e601f8088f0 
>   examples/vagrant/clusters_direct.json PRE-CREATION 
>   examples/vagrant/upstart/aurora-scheduler-await-registration.conf 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 470b2d2339284de9246b35daa0af1c2b832c232d 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1b2ce4d44f3650d7136006ed12319cdf37ae353e 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 86366240a48ebb576f7e3e5406cbc207fcd8df59 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 21371d951f8c6e44c40f97793d6acd26d3ca5614 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 4c4caaf76ce9f529c834f33f786036022766044d 
>   src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
> PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1171dca4af01a11e684f0b7a63a50250a8da1d22 
> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Joshua Cohen



> On Feb. 1, 2016, 8:38 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/api/scheduler_client.py, line 56
> > 
> >
> > Strings don't match - all the more reason this demands:
> > 
> > a.) a constant, likely in api.thrift
> > b.) an end-to-end test (you could turn off ZK and make sure you can 
> > still send a simple API request to the scheduler)

Added a constant and an end to end test to validate the behavior.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117259
---


On Feb. 2, 2016, 8:54 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> ---
> 
> (Updated Feb. 2, 2016, 8:54 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 12400a77db71084e91fc9082132d1e601f8088f0 
>   examples/vagrant/clusters_direct.json PRE-CREATION 
>   examples/vagrant/upstart/aurora-scheduler-await-registration.conf 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 470b2d2339284de9246b35daa0af1c2b832c232d 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1b2ce4d44f3650d7136006ed12319cdf37ae353e 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 86366240a48ebb576f7e3e5406cbc207fcd8df59 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 21371d951f8c6e44c40f97793d6acd26d3ca5614 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 4c4caaf76ce9f529c834f33f786036022766044d 
>   src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
> PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1171dca4af01a11e684f0b7a63a50250a8da1d22 
> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Joshua Cohen



> On Feb. 1, 2016, 8:41 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java, 
> > line 64
> > 
> >
> > Mini drive-by, but personally i'd rather just see `!= null` here.  More 
> > readable.

Done.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117261
---


On Feb. 2, 2016, 8:54 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> ---
> 
> (Updated Feb. 2, 2016, 8:54 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 12400a77db71084e91fc9082132d1e601f8088f0 
>   examples/vagrant/clusters_direct.json PRE-CREATION 
>   examples/vagrant/upstart/aurora-scheduler-await-registration.conf 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 470b2d2339284de9246b35daa0af1c2b832c232d 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1b2ce4d44f3650d7136006ed12319cdf37ae353e 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 86366240a48ebb576f7e3e5406cbc207fcd8df59 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 21371d951f8c6e44c40f97793d6acd26d3ca5614 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 4c4caaf76ce9f529c834f33f786036022766044d 
>   src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
> PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1171dca4af01a11e684f0b7a63a50250a8da1d22 
> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/
---

(Updated Feb. 2, 2016, 8:54 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Fix admin client option checking.


Bugs: AURORA-1601
https://issues.apache.org/jira/browse/AURORA-1601


Repository: aurora


Description
---

Add header to allow bypassing the LeaderRedirectFilter.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
12400a77db71084e91fc9082132d1e601f8088f0 
  examples/vagrant/clusters_direct.json PRE-CREATION 
  examples/vagrant/upstart/aurora-scheduler-await-registration.conf 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
  src/main/python/apache/aurora/admin/admin.py 
750b616dc9c4855733ddb2ff89c29d5a85af29af 
  src/main/python/apache/aurora/admin/aurora_admin.py 
470b2d2339284de9246b35daa0af1c2b832c232d 
  src/main/python/apache/aurora/client/api/__init__.py 
1b2ce4d44f3650d7136006ed12319cdf37ae353e 
  src/main/python/apache/aurora/client/api/scheduler_client.py 
86366240a48ebb576f7e3e5406cbc207fcd8df59 
  src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
21371d951f8c6e44c40f97793d6acd26d3ca5614 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
4c4caaf76ce9f529c834f33f786036022766044d 
  src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
PRE-CREATION 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
1171dca4af01a11e684f0b7a63a50250a8da1d22 

Diff: https://reviews.apache.org/r/42964/diff/


Testing
---

./gradlew build -Pq


Thanks,

Joshua Cohen

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-02 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/
---

(Updated Feb. 2, 2016, 8:48 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

- Use a thrift constant for the header name to keep the value in sync across 
java/python
- Add an end to end test to verify the behavior of the header.


Bugs: AURORA-1601
https://issues.apache.org/jira/browse/AURORA-1601


Repository: aurora


Description
---

Add header to allow bypassing the LeaderRedirectFilter.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
12400a77db71084e91fc9082132d1e601f8088f0 
  examples/vagrant/clusters_direct.json PRE-CREATION 
  examples/vagrant/upstart/aurora-scheduler-await-registration.conf 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
  src/main/python/apache/aurora/admin/admin.py 
750b616dc9c4855733ddb2ff89c29d5a85af29af 
  src/main/python/apache/aurora/admin/aurora_admin.py 
470b2d2339284de9246b35daa0af1c2b832c232d 
  src/main/python/apache/aurora/client/api/__init__.py 
1b2ce4d44f3650d7136006ed12319cdf37ae353e 
  src/main/python/apache/aurora/client/api/scheduler_client.py 
86366240a48ebb576f7e3e5406cbc207fcd8df59 
  src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
21371d951f8c6e44c40f97793d6acd26d3ca5614 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
4c4caaf76ce9f529c834f33f786036022766044d 
  src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh 
PRE-CREATION 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
1171dca4af01a11e684f0b7a63a50250a8da1d22 

Diff: https://reviews.apache.org/r/42964/diff/


Testing
---

./gradlew build -Pq


Thanks,

Joshua Cohen

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-02 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/
---

(Updated Feb. 2, 2016, 9:50 p.m.)


Review request for Aurora, Bill Farner, Zhitao Li, and Zameer Manji.


Changes
---

Rebase


Bugs: AURORA-1052
https://issues.apache.org/jira/browse/AURORA-1052


Repository: aurora


Description
---

Map Aurora task metadata to Mesos task labels


Diffs (updated)
-

  NEWS a6c2a906ee8e018cca756c1af0d20f221120d42f 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
cc2a4155008672056410086b05b6cc875485f669 

Diff: https://reviews.apache.org/r/35990/diff/


Testing
---

./gradlew -Pq build


Thanks,

Stephan Erb

Re: Review Request 43098: Upgrade to pants 0.0.70.

2016-02-02 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43098/#review117447
---


Ship it!




Ship It!

- Zameer Manji


On Feb. 2, 2016, 9:37 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43098/
> ---
> 
> (Updated Feb. 2, 2016, 9:37 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This bumps us to last week's regular weekly release.
> The changelog is here:
>   http://pantsbuild.github.io/changelog.html
> 
> No changes of note directly impacting Aurora, just keeping up
> with the release train.
> 
>  pants.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   pants.ini b0406ae4bae421dc4af9b60a83762a8c28c41a59 
> 
> Diff: https://reviews.apache.org/r/43098/diff/
> 
> 
> Testing
> ---
> 
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 43104: Reverting deprecated field removal patches.

2016-02-02 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43104/#review117446
---


Ship it!




Ship It!

- Bill Farner


On Feb. 2, 2016, 10:52 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43104/
> ---
> 
> (Updated Feb. 2, 2016, 10:52 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1603
> https://issues.apache.org/jira/browse/AURORA-1603
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The cleanest way is to revert both commits below. Otherwise, there is a nasty 
> conflict to resolve when we un-revert these patches in 0.13.0.
> 
> This reverts commit e1b55fa544765c12251ce6c1736e6352da3f7edb.
> 
> This reverts commit 89fad5a8895482b6c3fa45356137aa250d766dfe.
> 
> 
> Diffs
> -
> 
>   NEWS aef8a1aab2fee74ded8e1666f795885380690247 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8409c9bbae53ddc200132fb3c4c0a6eb6a4fcbf4 
>   src/main/java/org/apache/aurora/scheduler/base/Query.java 
> ee01eaa4d0230d6bf0909b6460f27a74f03240db 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  6300e5f83b039a9798e7093f6b46c84566e507e0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> eb848add00fba6d3571657bb9080be0599b2756a 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  d217faf44ab3d6132db3b3c4eed67effd03fb6fa 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/client/api/sla.py 
> e282ec96ec6999492f712d072f7ab1c09c022474 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 67ab4f01eca911aea041328410c6104b63ff8344 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/main/python/apache/aurora/config/thrift.py 
> be0cd68674a71bd4baadf276f40a4bc0223ce4be 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> 4780232318ffdf8c6bbbe78bee518886cffd580a 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 
> 1434f45ca0bc188bfb0f2ef3c25fbcd102a3ccb1 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  b1394cf44b7ddafcbc47bb1968306d0b33293380 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 
> ae52c402ee131167ca6099dd8218ce7315fede4c 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 84417ebeadfae57d55b9f12e8a985825bd620fc8 
>   src/main/resources/scheduler/assets/js/services.js 
> d9ce52065f9573b0aa68a95da7da7c50fb14310a 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 
> 469b53b2ab9407ad7cab41deee757207c75af985 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 
> 3c5ecd698557cafdf8eeacdc472589a379018896 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
>  b6f5e4632ac1e028fdf93da1735463373e2d2788 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java
>  c316e497a34a45c7ada2ca83a1115e826c0f572f 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 0256c06ee0794bf50bccaa283c5086da7642f3f6 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> be98f3862d537602c05275ba2466e2fdbf5e9b55 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  3ba03429748448642571cfe0858278a50148745a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c774ac0f0e2fdda7fe9b64fd9181f107b3fd9eca 
>   src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java 
> 09d13a3abf72a25c5b7bfc1d7db3bdfb8ec11c6d 
>   src/test/python/apache/aurora/admin/test_admin.py 
> 22605ec8c28cf6d3b66c3dacc9634776d0afe8ff 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 974fc7e5a8ea13020e2c01a2088a8535947f05bc 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 2bc2dd965ac0d7e2d959771b5a33ddc942bda734 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 7f36b4627bdbaaec4e6358500beeb143de4fcb7a 
>   src/test/python/apache/aurora/client/cli/util.py 
> 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 88292d3c4423c0555088a0adaee3c0e62ed0

Re: Review Request 43104: Reverting deprecated field removal patches.

2016-02-02 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43104/#review117445
---


Ship it!




Ship It!

- John Sirois


On Feb. 2, 2016, 11:52 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43104/
> ---
> 
> (Updated Feb. 2, 2016, 11:52 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1603
> https://issues.apache.org/jira/browse/AURORA-1603
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The cleanest way is to revert both commits below. Otherwise, there is a nasty 
> conflict to resolve when we un-revert these patches in 0.13.0.
> 
> This reverts commit e1b55fa544765c12251ce6c1736e6352da3f7edb.
> 
> This reverts commit 89fad5a8895482b6c3fa45356137aa250d766dfe.
> 
> 
> Diffs
> -
> 
>   NEWS aef8a1aab2fee74ded8e1666f795885380690247 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8409c9bbae53ddc200132fb3c4c0a6eb6a4fcbf4 
>   src/main/java/org/apache/aurora/scheduler/base/Query.java 
> ee01eaa4d0230d6bf0909b6460f27a74f03240db 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  6300e5f83b039a9798e7093f6b46c84566e507e0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> eb848add00fba6d3571657bb9080be0599b2756a 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  d217faf44ab3d6132db3b3c4eed67effd03fb6fa 
>   src/main/python/apache/aurora/admin/admin.py 
> 750b616dc9c4855733ddb2ff89c29d5a85af29af 
>   src/main/python/apache/aurora/client/api/sla.py 
> e282ec96ec6999492f712d072f7ab1c09c022474 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 67ab4f01eca911aea041328410c6104b63ff8344 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/main/python/apache/aurora/config/thrift.py 
> be0cd68674a71bd4baadf276f40a4bc0223ce4be 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> 4780232318ffdf8c6bbbe78bee518886cffd580a 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 
> 1434f45ca0bc188bfb0f2ef3c25fbcd102a3ccb1 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  b1394cf44b7ddafcbc47bb1968306d0b33293380 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 
> ae52c402ee131167ca6099dd8218ce7315fede4c 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 84417ebeadfae57d55b9f12e8a985825bd620fc8 
>   src/main/resources/scheduler/assets/js/services.js 
> d9ce52065f9573b0aa68a95da7da7c50fb14310a 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 
> 469b53b2ab9407ad7cab41deee757207c75af985 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 
> 3c5ecd698557cafdf8eeacdc472589a379018896 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
>  b6f5e4632ac1e028fdf93da1735463373e2d2788 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java
>  c316e497a34a45c7ada2ca83a1115e826c0f572f 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 0256c06ee0794bf50bccaa283c5086da7642f3f6 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> be98f3862d537602c05275ba2466e2fdbf5e9b55 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  3ba03429748448642571cfe0858278a50148745a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c774ac0f0e2fdda7fe9b64fd9181f107b3fd9eca 
>   src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java 
> 09d13a3abf72a25c5b7bfc1d7db3bdfb8ec11c6d 
>   src/test/python/apache/aurora/admin/test_admin.py 
> 22605ec8c28cf6d3b66c3dacc9634776d0afe8ff 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 974fc7e5a8ea13020e2c01a2088a8535947f05bc 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 2bc2dd965ac0d7e2d959771b5a33ddc942bda734 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 7f36b4627bdbaaec4e6358500beeb143de4fcb7a 
>   src/test/python/apache/aurora/client/cli/util.py 
> 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 88292d3c4423c0555088a0adaee3c0e62ed0

Review Request 43104: Reverting deprecated field removal patches.

2016-02-02 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43104/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1603
https://issues.apache.org/jira/browse/AURORA-1603


Repository: aurora


Description
---

The cleanest way is to revert both commits below. Otherwise, there is a nasty 
conflict to resolve when we un-revert these patches in 0.13.0.

This reverts commit e1b55fa544765c12251ce6c1736e6352da3f7edb.

This reverts commit 89fad5a8895482b6c3fa45356137aa250d766dfe.


Diffs
-

  NEWS aef8a1aab2fee74ded8e1666f795885380690247 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
8409c9bbae53ddc200132fb3c4c0a6eb6a4fcbf4 
  src/main/java/org/apache/aurora/scheduler/base/Query.java 
ee01eaa4d0230d6bf0909b6460f27a74f03240db 
  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 6300e5f83b039a9798e7093f6b46c84566e507e0 
  src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
eb848add00fba6d3571657bb9080be0599b2756a 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
d217faf44ab3d6132db3b3c4eed67effd03fb6fa 
  src/main/python/apache/aurora/admin/admin.py 
750b616dc9c4855733ddb2ff89c29d5a85af29af 
  src/main/python/apache/aurora/client/api/sla.py 
e282ec96ec6999492f712d072f7ab1c09c022474 
  src/main/python/apache/aurora/client/cli/jobs.py 
67ab4f01eca911aea041328410c6104b63ff8344 
  src/main/python/apache/aurora/client/cli/task.py 
a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
  src/main/python/apache/aurora/config/thrift.py 
be0cd68674a71bd4baadf276f40a4bc0223ce4be 
  src/main/python/apache/aurora/executor/common/announcer.py 
34e36e0a59093468a8934f58bacb68512949347c 
  src/main/python/apache/aurora/executor/common/sandbox.py 
4780232318ffdf8c6bbbe78bee518886cffd580a 
  src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 
1434f45ca0bc188bfb0f2ef3c25fbcd102a3ccb1 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 
b1394cf44b7ddafcbc47bb1968306d0b33293380 
  src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 
ae52c402ee131167ca6099dd8218ce7315fede4c 
  src/main/resources/scheduler/assets/js/controllers.js 
84417ebeadfae57d55b9f12e8a985825bd620fc8 
  src/main/resources/scheduler/assets/js/services.js 
d9ce52065f9573b0aa68a95da7da7c50fb14310a 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 
469b53b2ab9407ad7cab41deee757207c75af985 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 
3c5ecd698557cafdf8eeacdc472589a379018896 
  
src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
 b6f5e4632ac1e028fdf93da1735463373e2d2788 
  
src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 
c316e497a34a45c7ada2ca83a1115e826c0f572f 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
0256c06ee0794bf50bccaa283c5086da7642f3f6 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
be98f3862d537602c05275ba2466e2fdbf5e9b55 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
3ba03429748448642571cfe0858278a50148745a 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 c774ac0f0e2fdda7fe9b64fd9181f107b3fd9eca 
  src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java 
09d13a3abf72a25c5b7bfc1d7db3bdfb8ec11c6d 
  src/test/python/apache/aurora/admin/test_admin.py 
22605ec8c28cf6d3b66c3dacc9634776d0afe8ff 
  src/test/python/apache/aurora/client/api/test_api.py 
974fc7e5a8ea13020e2c01a2088a8535947f05bc 
  src/test/python/apache/aurora/client/api/test_sla.py 
2bc2dd965ac0d7e2d959771b5a33ddc942bda734 
  src/test/python/apache/aurora/client/cli/test_status.py 
7f36b4627bdbaaec4e6358500beeb143de4fcb7a 
  src/test/python/apache/aurora/client/cli/util.py 
7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e 
  src/test/python/apache/aurora/config/test_thrift.py 
88292d3c4423c0555088a0adaee3c0e62ed0567e 
  src/test/python/apache/aurora/executor/common/test_announcer.py 
f4032c7302f4733ab5670322b1905102c200f1c9 
  
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
 fe74bd1d3ecd89fca1b5b2251202cbbc0f24 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
ef60ec2d654d7dfc839df5110a80fe70a80a5d63 

Diff: https://reviews.apache.org/r/43104/diff/


Testing
---

./gradlew -Pq build
e2e tests


Thanks,

Maxim Khutornenko

Re: Review Request 43098: Upgrade to pants 0.0.70.

2016-02-02 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43098/#review117443
---


Ship it!




Master (e1b55fa) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2016, 5:37 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43098/
> ---
> 
> (Updated Feb. 2, 2016, 5:37 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This bumps us to last week's regular weekly release.
> The changelog is here:
>   http://pantsbuild.github.io/changelog.html
> 
> No changes of note directly impacting Aurora, just keeping up
> with the release train.
> 
>  pants.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   pants.ini b0406ae4bae421dc4af9b60a83762a8c28c41a59 
> 
> Diff: https://reviews.apache.org/r/43098/diff/
> 
> 
> Testing
> ---
> 
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Review Request 43098: Upgrade to pants 0.0.70.

2016-02-02 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43098/
---

Review request for Aurora and Zameer Manji.


Repository: aurora


Description
---

This bumps us to last week's regular weekly release.
The changelog is here:
  http://pantsbuild.github.io/changelog.html

No changes of note directly impacting Aurora, just keeping up
with the release train.

 pants.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Diffs
-

  pants.ini b0406ae4bae421dc4af9b60a83762a8c28c41a59 

Diff: https://reviews.apache.org/r/43098/diff/


Testing
---

Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```


Thanks,

John Sirois

Re: Review Request 43013: Move lifecycle documentation into separate file

2016-02-02 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43013/#review117408
---

This LGTM, some things noted are not yours so as you see fit.

docs/configuration-reference.md (line 330)

Checking my understanding - did you get this from here?: 
https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/executor/thermos_task_runner.py#L317-L318

docs/task-lifecycle.md (line 12)

A note that clarifies some states are missing from the diagram is probably 
in order as is a new issue to update the diagram unless you intend to keep 
https://issues.apache.org/jira/browse/AURORA-489 open for that second step.

docs/task-lifecycle.md (line 41)

s/how/that/

docs/task-lifecycle.md (line 51)

s/world. `Or/world.`, or/

docs/task-lifecycle.md (line 78)

This is out of date (If a ShellHealthChecker is configured then steps 2&3 
are replaced by a new step 2), but this is also out of scope for your change 
here.  As you see fit.

docs/task-lifecycle.md (line 113)

I'm not sure this sentence is needed.  By definition the production bit, as 
described above, leads to production preference and pre-emption of 
non-production.  "Important" is a bit of a loaded term.

docs/task-lifecycle.md (line 140)

Checking - the 1 hour figure comes from here?: 
https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java#L78-L83

docs/user-guide.md 

The [Job Lifecycle] could stay and be ppolated with a few sentences 
including a link off to the new task-lifecycle doc.  Something like: Jobs have 
a rich lifecycle that is described here, but in day to day use, you'll be 
primarily concerned with launching new jobs and updating existing ones...

That would lead into the [Task Updates] and [HTTP Health Checking and 
Graceful Shutdown] a little more cleanly and provide a natural spot to note the 
more detailed docs.

- John Sirois

On Jan. 30, 2016, 1:41 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43013/
> ---
> 
> (Updated Jan. 30, 2016, 1:41 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington, John Sirois, Kevin Sweeney, and 
> Brian Wickman.
> 
> 
> Bugs: AURORA-1068, AURORA-1262, AURORA-489, and AURORA-734
> https://issues.apache.org/jira/browse/AURORA-1068
> https://issues.apache.org/jira/browse/AURORA-1262
> https://issues.apache.org/jira/browse/AURORA-489
> https://issues.apache.org/jira/browse/AURORA-734
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> In addition to the move, a couple of releted additions and adjustements have 
> been made:
> 
> * slight reorganization
> * documentation of missing states (THROTTELD, DRAINING)
> * custom section on reconciliation
> * remark regarding the uniqueness of an instance
> * updated documentation of the teardown of a task (HTTPLifecycleConfig and 
> finalization_wait)
> 
> 
> Diffs
> -
> 
>   docs/README.md 8ebc06121c1fd985027bebfab4f0c7123b66a6bb 
>   docs/configuration-reference.md 995f70654c89829a092e7b745a8390459244325d 
>   docs/task-lifecycle.md PRE-CREATION 
>   docs/user-guide.md df63468ddacb4a584938cd502004e47876347253 
> 
> Diff: https://reviews.apache.org/r/43013/diff/
> 
> 
> Testing
> ---
> 
> Rendered version is available at 
> https://github.com/StephanErb/aurora/blob/tasklifecycle/docs/task-lifecycle.md
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 42748: [1/3] Introduce a thrift java code generator.

2016-02-02 Thread John Sirois



> On Jan. 27, 2016, 4:51 p.m., John Sirois wrote:
> > buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftStruct.java,
> >  line 34
> > 
> >
> > NB: actual generated structs have a no-arg `builder()` method - this is 
> > just for reflective applications.
> 
> Zameer Manji wrote:
> I don't think I saw any uses of this method. Is there a reflective 
> application/usecase that you are targeting here?

Yes, GsonMessageBodyHandler uses this over in RB 3/3 
https://reviews.apache.org/r/42756/diff/2?page=4#70 line 201


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42748/#review116653
---


On Jan. 26, 2016, 10:16 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42748/
> ---
> 
> (Updated Jan. 26, 2016, 10:16 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This generator emits immutable objects and carries over thrift
> annotations to java annotations for both subsequent build-time
> code generation via annotation processors and for runtime use
> in interceptors and other reflective tools.
> 
>  .gitignore   
>   |   3 +
>  build.gradle 
>   |  47 ++-
>  buildSrc/build.gradle
>   |  61 
>  settings.gradle => buildSrc/settings.gradle  
>   |   3 +-
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftAnnotation.java
> |  45 +++
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftAnnotations.java
>|  38 +++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftEntity.java  
>   |  70 
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftFields.java  
>   |  65 
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftService.java 
>   |  43 +++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftStruct.java  
>   |  80 +
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftUnion.java   
>   |  76 +
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/AbstractStructRenderer.java
> | 132 
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/BaseEmitter.java
>| 143 +
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/BaseVisitor.java
>| 533 +++
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ConstVisitor.java
>   |  72 +
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/IntegerEnumVisitor.java
> | 102 ++
>  buildSrc/{build.gradle => 
> thriftGen/src/main/java/org/apache/aurora/thrift/build/ParseException.java}   
>|  15 +-
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ServiceVisitor.java
> | 279 
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/StructVisitor.java
>  | 619 +++
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/SymbolTable.java
>| 180 +++
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ThriftGen.java
>  | 190 +++
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ThriftGenVisitor.java
>   | 122 +++
>  buildSrc/{build.gradle => 
> thriftGen/src/main/java/org/apache/aurora/thrift/build/UnexpectedTypeException.java}
>  |  13 +-
>  
> buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/UnionVisitor.java
>   | 254 +++
>  buildSrc/{build.gradle => 
> thriftGen/src/main/java/org/apache/aurora/thrift/build/UnsupportedFeatureException.java}
>  |  12 +-
>  buildSrc/

Re: Review Request 42748: [1/3] Introduce a thrift java code generator.

2016-02-02 Thread John Sirois



> On Jan. 31, 2016, 6:13 p.m., Zameer Manji wrote:
> > This is just a quick first pass review where I checked for overall 
> > organization of the code and structure. I was able to follow along and 
> > understand the organization just fine. After spending time reading this 
> > carefully, I now better understand the possible concern of the maintenance 
> > burden of this much non-trival code. A subsequent review of this will have 
> > me focusing on the implementation of each visitor and codegen.
> > 
> > I have left some comments for small things that stood out to me as I was 
> > reviewing.

Thanks for looking, but I'm going to close this review series out as discarded 
and make that more clear on the PROPOSAL thread since consensus has settled 
there on working through Apache Thrift 1st, and that will move the work done 
here in 1/3 over to Thrift.


> On Jan. 31, 2016, 6:13 p.m., Zameer Manji wrote:
> > buildSrc/build.gradle, line 56
> > 
> >
> > It seems to me that the `guava`, `libthrift`, `slf4j` and `junit` 
> > versions should stay in sync with the ones defined in `build.gradle` in the 
> > root.
> > 
> > Do you know if it is possible to pass down variables from build.gradle 
> > into this script? If not, would you mind adding comments both in 
> > `build.gradle` and here telling us that they should be kept in sync?

Yeah - passing variables down definitely works, I have a TODO for exactly this 
in my branch for 3/3 https://reviews.apache.org/r/42756/diff/2?page=1#5 line 
36.  This file deserves the same treatment and TODO though.


> On Jan. 31, 2016, 6:13 p.m., Zameer Manji wrote:
> > buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftAnnotations.java,
> >  line 37
> > 
> >
> > Perhaps this should be a `List` than an array?

Annotation types can only have - for some definition of primitive - primitive 
typed values.  Arrays, other annotation types, enums and Class instances are 
the oddest of these primitive types


> On Jan. 31, 2016, 6:13 p.m., Zameer Manji wrote:
> > buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ThriftGen.java,
> >  line 159
> > 
> >
> > I think the `PathCharSource` could just be replaced with 
> > `com.google.common.io.Files#asCharSource` where you call `toFile` on 
> > `thriftFile`.
> > 
> > No need to create another class here.

Nack - Path.toFile works for the native FS layer provided by the JDK but is an 
optional operation and - importantly - not one supported by Jimfs which is used 
in unit tests.


> On Jan. 31, 2016, 6:13 p.m., Zameer Manji wrote:
> > buildSrc/build.gradle, line 65
> > 
> >
> > The SLF4J dependency seems like overkill here, is there a reason why 
> > the thrift generation code doesn't just use `j.u.logging`?

Agreed - this dep is un-needed.


> On Jan. 31, 2016, 6:13 p.m., Zameer Manji wrote:
> > buildSrc/build.gradle, line 21
> > 
> >
> > This `compileJava` clause seems to be uncessary. I have been able to 
> > remove it and have the project compile successfully.

You're right - although the proof of the pudding is a failed compile for, say 
`JAVA_HOME=/usr/lib/jvm/java-7-openjdk ./gradlew...`.  ThriftGen was top-level 
in buildSrc when I added this and it now can be removed since the `subprojects 
{...}` now handles the check.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42748/#review117164
---


On Jan. 26, 2016, 10:16 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42748/
> ---
> 
> (Updated Jan. 26, 2016, 10:16 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This generator emits immutable objects and carries over thrift
> annotations to java annotations for both subsequent build-time
> code generation via annotation processors and for runtime use
> in interceptors and other reflective tools.
> 
>  .gitignore   
>   |   3 +
>  build.gradle 
>   |  47 ++-
>  buildSrc/build.gradle
>   |

49 matches

Mail list logo