Re: Review Request 43457: Increase throughput of DbTaskStore

2016-02-12 Thread John Sirois
> On Feb. 10, 2016, 5:23 p.m., John Sirois wrote: > > > and removes the population of an object via a constructor which is slower > > > than populating an object via setters. > > > > For clarification, is this optimization the much smaller of the 2? Naively > > - I'd hope construction would

Re: Review Request 43457: Increase throughput of DbTaskStore

2016-02-12 Thread John Sirois
> On Feb. 10, 2016, 5:23 p.m., John Sirois wrote: > > > and removes the population of an object via a constructor which is slower > > > than populating an object via setters. > > > > For clarification, is this optimization the much smaller of the 2? Naively > > - I'd hope construction would

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43534/#review119058 --- @ReviewBot retry - John Sirois On Feb. 12, 2016, 11:31 a.m.,

Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43534/ --- Review request for Aurora and Stephan Erb. Bugs: AURORA-1617

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43534/#review119057 --- Master (7d57cf4) is red with this patch.

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43534/#review119063 --- Ship it! docs/installing.md (line 239)

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43534/ --- (Updated Feb. 12, 2016, 11:40 a.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43534/ --- (Updated Feb. 12, 2016, 11:44 a.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43534/#review119061 --- Master (7d57cf4) is red with this patch.

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43534/#review119062 --- @ReviewBot retry - John Sirois On Feb. 12, 2016, 11:44 a.m.,

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43534/#review119067 --- Ship it! Master (7d57cf4) is green with this patch.

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread John Sirois
> On Feb. 12, 2016, 12:11 p.m., Stephan Erb wrote: > > docs/installing.md, line 239 > > > > > > I fear that the listed options here might easily become outdated > > without us noticing. Can you suggest a

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread John Sirois
> On Feb. 12, 2016, 12:11 p.m., Stephan Erb wrote: > > docs/installing.md, line 239 > > > > > > I fear that the listed options here might easily become outdated > > without us noticing. > > John Sirois wrote: >

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

2016-02-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43534/ --- (Updated Feb. 12, 2016, 12:36 p.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 43554: Update pants wrapper to match upstream

2016-02-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43554/#review119125 --- Ship it! - John Sirois On Feb. 12, 2016, 7 p.m., Benjamin

Re: Review Request 43554: Update pants wrapper to match upstream

2016-02-12 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43554/ --- (Updated Feb. 12, 2016, 6 p.m.) Review request for Aurora and John Sirois.

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review119132 --- Master (2b48f22) is red with this patch.

Review Request 43554: Update pants wrapper to match upstream

2016-02-12 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43554/ --- Review request for Aurora. Repository: aurora Description --- Picking

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-12 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/ --- (Updated Feb. 12, 2016, 6:17 p.m.) Review request for Aurora. Bugs: