Re: Review Request 44827: Do not split the shell command string passed into shell health check script

2016-03-14 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44827/ --- (Updated March 15, 2016, 3:49 a.m.) Review request for Aurora, John Sirois,

Re: Review Request 44806: Rename NEWS to RELEASE-NOTES.md

2016-03-14 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44806/#review123554 --- Ship it! Ship It! - Jake Farrell On March 14, 2016, 8:44

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-14 Thread Stephan Erb
On March 13, 2016, 1:04 p.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in

Re: Review Request 44806: Rename NEWS to RELEASE-NOTES.md

2016-03-14 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44806/#review123548 --- Ship it! Ship It! - Zameer Manji On March 14, 2016, 1:44

Re: Review Request 44806: Rename NEWS to RELEASE-NOTES.md

2016-03-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44806/#review123542 --- Ship it! Ship It! - Stephan Erb On March 14, 2016, 9:44

Re: Review Request 44806: Rename NEWS to RELEASE-NOTES.md

2016-03-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44806/#review123518 --- Ship it! Master (3806e62) is green with this patch.

Re: Review Request 44806: Rename NEWS to RELEASE-NOTES.md

2016-03-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44806/#review123507 --- Ship it! NEWS (line 21)

Review Request 44806: Rename NEWS to RELEASE-NOTES.md

2016-03-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44806/ --- Review request for Aurora, Stephan Erb and Zameer Manji. Repository: aurora

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

2016-03-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123504 --- Ship it! Ship It! - Joshua Cohen On March 14, 2016, 7:43

Re: Review Request 44770: Create scheduler-configuration.md

2016-03-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44770/#review123501 --- Ship it! docs/scheduler-configuration.md (line 3)

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-14 Thread Bill Farner
> On March 10, 2016, 2:04 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95 > > > > > > Specifying the command here feels kind of weird. All other options we

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

2016-03-14 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123496 --- Ship it! Ship It! - John Sirois On March 14, 2016, 1:43

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

2016-03-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/ --- (Updated March 14, 2016, 12:43 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 44799: Fixup rpm builder and test docs.

2016-03-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44799/#review123482 --- Ship it! Ship It! - Bill Farner On March 14, 2016, 11:53

Review Request 44799: Fixup rpm builder and test docs.

2016-03-14 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44799/ --- Review request for Aurora and Bill Farner. Repository: aurora-packaging

Re: Review Request 44763: Remove cyrus-sasl and docker RPM dpendencies.

2016-03-14 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44763/#review123461 --- I'm going to patch this in presently to base my rpm tweaks for

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-14 Thread Maxim Khutornenko
On March 13, 2016, 12:04 p.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

2016-03-14 Thread John Sirois
> On March 14, 2016, 9:51 a.m., Joshua Cohen wrote: > > Actually, one more thing... should we ensure that the task config it has > > either executor config set or uses a Docker container? I think right now > > you could configure the scheduler with `-require_docker_use_executor=False` > > and

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

2016-03-14 Thread Joshua Cohen
> On March 14, 2016, 3:51 p.m., Joshua Cohen wrote: > > Actually, one more thing... should we ensure that the task config it has > > either executor config set or uses a Docker container? I think right now > > you could configure the scheduler with `-require_docker_use_executor=False` > > and

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-14 Thread John Sirois
> On March 14, 2016, 9:31 a.m., Joshua Cohen wrote: > > This seems like something we should cover with the end to end tests? Would > > you mind adding a test that spins up the scheduler to allow executor-less > > tasks, launches a task and then confirms it responds as expected? > > > > Also,

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44745/#review123425 --- This seems like something we should cover with the end to end

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

2016-03-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123414 --- Ship it! lgtm modulo the below.