Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-16 Thread Maxim Khutornenko
> On June 15, 2016, 5:41 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/migration/V006_PopulateTierField.java, > > lines 50-52 > > > > > > This should be unnecessary as zero

Re: Review Request 48796: AURORA-1458 Add tier into the UI "show config" summary

2016-06-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48796/#review138027 --- LGTM. Holding off on shipping it until

Re: Review Request 48786: Remove link to non-existing Locks page

2016-06-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48786/#review138024 --- Ship it! Ship It! - Maxim Khutornenko On June 16, 2016,

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-16 Thread Mehrdad Nurolahzade
> On June 15, 2016, 10:41 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/migration/V006_PopulateTierField.java, > > lines 50-52 > > > > > > This should be unnecessary as zero

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-16 Thread Maxim Khutornenko
> On June 15, 2016, 5:41 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/TierManager.java, lines 125-127 > > > > > > Reiterating my previous comment: can this (and other places checking

Re: Review Request 48796: AURORA-1458 Add tier into the UI "show config" summary

2016-06-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48796/#review138011 --- Master (f9bbfb3) is green with this patch.

Re: Review Request 48786: Remove link to non-existing Locks page

2016-06-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48786/#review138008 --- Master (f9bbfb3) is green with this patch.

Review Request 48796: AURORA-1458 Add tier into the UI "show config" summary

2016-06-16 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48796/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-16 Thread Mehrdad Nurolahzade
> On June 15, 2016, 10:41 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/migration/V006_PopulateTierField.java, > > lines 50-52 > > > > > > This should be unnecessary as zero

Re: Review Request 48786: Remove link to non-existing Locks page

2016-06-16 Thread Martin Hrabovcin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48786/ --- (Updated June 16, 2016, 3:18 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 48786: Remove link to non-existing Locks page

2016-06-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48786/#review137966 --- Master (f9bbfb3) is green with this patch.

Review Request 48786: Remove link to non-existing Locks page

2016-06-16 Thread Martin Hrabovcin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48786/ --- Review request for Aurora. Repository: aurora Description --- Remove