Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141361 --- Master (528198e) is red with this patch. ./build-support/jenkins/build.sh virtualenv-14.0.6/virtualenv_embedded/activate.csh virtualenv-14.0.6/virtualenv_embedded/activate.fish virtualenv-14.0.6/virtualenv_embedded/activate.ps1 virtualenv-14.0.6/virtualenv_embedded/activate.sh virtualenv-14.0.6/virtualenv_embedded/activate_this.py virtualenv-14.0.6/virtualenv_embedded/deactivate.bat virtualenv-14.0.6/virtualenv_embedded/distutils-init.py virtualenv-14.0.6/virtualenv_embedded/distutils.cfg virtualenv-14.0.6/virtualenv_embedded/python-config virtualenv-14.0.6/virtualenv_embedded/site.py virtualenv-14.0.6/virtualenv_support/ virtualenv-14.0.6/virtualenv_support/__init__.py virtualenv-14.0.6/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/setuptools-20.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl + touch virtualenv-14.0.6/BOOTSTRAPPED + popd /home/jenkins/jenkins-slave/workspace/AuroraBot + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-14.0.6/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python Installing setuptools, pip, wheel...done. Collecting isort==4.0.0 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:318: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning. SNIMissingWarning /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning Downloading isort-4.0.0-py2.py3-none-any.whl Installing collected packages: isort Successfully installed isort-4.0.0 + ./pants test.pytest --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results src/main/python:: src/test/python:: -- -v % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 1679k 100 1679k0 0 17.5M 0 --:--:-- --:--:-- --:--:-- 17.6M New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.bd93Vs/install/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.bd93Vs/install/bin/python Installing setuptools, pip, wheel...done. ./pants: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.bd93Vs/install/bin/pip: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/boot: bad interpreter: No such file or directory ./pants: line 95: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-pre6/bin/pants: No such file or directory I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 8, 2016, 11:15 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > --- > > (Updated July 8, 2016, 11:15 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1710 > https://issues.apache.org/jira/browse/AURORA-1710 > > > Repository: aurora > > > Description > --- > > AURORA-1710 Make 'tier' required and remove
Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated July 8, 2016, 4:15 p.m.) Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Changes --- The logic was originally correct but then I modified it based on review comments without noticing that the refactoring has broken the logic. Bugs: AURORA-1710 https://issues.apache.org/jira/browse/AURORA-1710 Repository: aurora Description --- AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes Diffs (updated) - RELEASE-NOTES.md 29d224d5596eb060356f1343cf347db79b1ad687 src/main/python/apache/aurora/client/api/__init__.py 68baf8fdb90cd26100159401c46c9963c24332b3 src/main/python/apache/aurora/client/cli/context.py 9b1511801d031ff48b81c25688a55cb586b8ac66 src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e src/test/python/apache/aurora/client/cli/test_command_hooks.py 2130f1fa71be02a004cdf8e476a270c81a7105d3 src/test/python/apache/aurora/client/cli/test_context.py 204ca092adad8bf43c5032a02f61bf303fb0b2fc src/test/python/apache/aurora/client/cli/test_create.py 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c src/test/python/apache/aurora/client/cli/test_cron.py f3c522ed94a2d774865811ceb546bf9df083c14f src/test/python/apache/aurora/client/cli/test_plugins.py a545fece5e2b3e0017a61e1be9ac478372b1f34d src/test/python/apache/aurora/client/cli/test_restart.py 967d560e5c7eb0ed85b215fb11d9751b8666acb5 src/test/python/apache/aurora/client/cli/util.py 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e src/test/python/apache/aurora/client/test_config.py b1a3c1865819899ef19173be0f861783a2631d0a Diff: https://reviews.apache.org/r/49048/diff/ Testing --- ``` ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh *** OK (All tests passed) *** mesos-master start/running, process 26868 + RETCODE=0 + restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real19m46.324s user0m1.496s sys 0m0.774s ``` Thanks, Mehrdad Nurolahzade
Re: Review Request 49732: Update package scripts to 0.15.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49732/#review141352 --- Ship it! I think - going forward, just TBR to master makes more sense. This TBR to a branch (on origin) confused me at least. - John Sirois On July 6, 2016, 6:30 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49732/ > --- > > (Updated July 6, 2016, 6:30 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora-packaging > > > Description > --- > > Update package scripts to 0.15.0. > > > Diffs > - > > README.md 3a7cf45034b7896c23588fed83176468ca627ebc > specs/debian/control e4d23ba6190ebbd3afbb930e305d76f5b61a5dac > specs/rpm/aurora.spec 7a368fd8128153a3167032727fe011a8a7457853 > test/deb/debian-jessie/README.md a98407b96c673eb6ca6269d646755926d51fd4ab > test/deb/debian-jessie/provision.sh > ed4364f69a63493d7a1fd6791ef743609c99b924 > test/deb/ubuntu-trusty/README.md c5579857443c73d8343a82210e34be98ad3a86da > test/deb/ubuntu-trusty/provision.sh > 5b4ec472a23d5d401a64a6a72743c392d048f949 > test/rpm/centos-7/README.md e5649015934e4714a054a5be7a83f9c333b70144 > test/rpm/centos-7/provision.sh 5aa88a5d86a990131cdbdae5d93aeb75a1dc7c90 > > Diff: https://reviews.apache.org/r/49732/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 49732: Update package scripts to 0.15.0.
> On July 6, 2016, 8:33 p.m., John Sirois wrote: > > I am slightly worried the tests only seem to work after this change ... > > IIUC Aurora 0.15.0 should work with mesos 0.27.2 (Aurora should work with > > the mesos its developed against +/- 1). > > John Sirois wrote: > Oh, now I understand I think. You used this patch to do the 0.15.0 > release, which is in error. The 0.15.0 release should have a >= 0.27.2 mesos > constraint. > > If that makes sense, un-shipit. > > Stephan Erb wrote: > That observation regarding specifying >=0.27 even though we have build > against 0.28 probably correct. > > FWIW, our previous packages have been inconsistent in that regard as well: > > * 0.12 is build against Mesos 0.25 but specifies >=0.21.1 for Debian and > ==0.25 for Centos > * 0.13 is build against Mesos 0.26 but specifies >=0.26 > * 0.14 is build against Mesos 0.27.2 but specifies >=0.27.2 > > Maxim Khutornenko wrote: > > Aurora should work with the mesos its developed against > > That may or may not be true. It all depends on what we change in Aurora > to bump up the Mesos version. In 0.15.0, we upgraded Mesos to 0.28.2 that > required us to treat the new Mesos task state (KILLING). This means 0.15.0 > cannot rely on 0.27.2 anymore and >= 0.28.2 seems the only logical constraint > there. > > Joshua Cohen wrote: > Yeah, unfortunately there's no great way to upgrade to 0.28.2 without > explicitly depending on the new `TaskState.KILLING` value. We either had to > make the change I made (add explicit support for the state to `Conversions` > or we would have had to update `ConversionsTest` to explicitly ignore that > task state, either way it would require 0.28.2. I suppose we *could* ignore > it in the test by checking for `"KILLING".equals(state.getName())`. That > seems a bit hacky but it would allow us to upgrade to 0.28.2 while letting > 0.15.0 still run against 0.27.x. > > Is that preferable, or are we ok with bending the rules in this instance? > > Maxim Khutornenko wrote: > I don't think we can shy away from the fact that Mesos upgrades may and > will require making backwards incompatible Aurora changes as far as Mesos > versions go. The whole purpose of supporting the ">=" syntax is to define the > cluster upgrade as "first, upgrade Mesos then - Aurora". Trying to support -1 > version in addition to +1 will only make our lifes harder and may even be > impossible in the future (e.g.: switching from `launchTasks` to > `acceptOffers`) > > John, given the above, how would like to proceed with this patch? > > Joshua Cohen wrote: > Yeah, we're going to have a similar issue for the 1.0 upgrade in that if > we operators opt in to GPU resources we're going to have to send a framework > capability that was only recently introduced. I have 0 issues with certain releases violating a policy if well communicated. My concern was based off of 2 false premises: a non-existant +/- 1 policy and lack of commnication this would be a non -1 release. Thanks for setting me straight. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49732/#review141120 --- On July 6, 2016, 6:30 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49732/ > --- > > (Updated July 6, 2016, 6:30 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora-packaging > > > Description > --- > > Update package scripts to 0.15.0. > > > Diffs > - > > README.md 3a7cf45034b7896c23588fed83176468ca627ebc > specs/debian/control e4d23ba6190ebbd3afbb930e305d76f5b61a5dac > specs/rpm/aurora.spec 7a368fd8128153a3167032727fe011a8a7457853 > test/deb/debian-jessie/README.md a98407b96c673eb6ca6269d646755926d51fd4ab > test/deb/debian-jessie/provision.sh > ed4364f69a63493d7a1fd6791ef743609c99b924 > test/deb/ubuntu-trusty/README.md c5579857443c73d8343a82210e34be98ad3a86da > test/deb/ubuntu-trusty/provision.sh > 5b4ec472a23d5d401a64a6a72743c392d048f949 > test/rpm/centos-7/README.md e5649015934e4714a054a5be7a83f9c333b70144 > test/rpm/centos-7/provision.sh 5aa88a5d86a990131cdbdae5d93aeb75a1dc7c90 > > Diff: https://reviews.apache.org/r/49732/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141331 --- Master (70d0ef2) is red with this patch. ./build-support/jenkins/build.sh virtualenv-14.0.6/virtualenv_embedded/activate.csh virtualenv-14.0.6/virtualenv_embedded/activate.fish virtualenv-14.0.6/virtualenv_embedded/activate.ps1 virtualenv-14.0.6/virtualenv_embedded/activate.sh virtualenv-14.0.6/virtualenv_embedded/activate_this.py virtualenv-14.0.6/virtualenv_embedded/deactivate.bat virtualenv-14.0.6/virtualenv_embedded/distutils-init.py virtualenv-14.0.6/virtualenv_embedded/distutils.cfg virtualenv-14.0.6/virtualenv_embedded/python-config virtualenv-14.0.6/virtualenv_embedded/site.py virtualenv-14.0.6/virtualenv_support/ virtualenv-14.0.6/virtualenv_support/__init__.py virtualenv-14.0.6/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/setuptools-20.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl + touch virtualenv-14.0.6/BOOTSTRAPPED + popd /home/jenkins/jenkins-slave/workspace/AuroraBot + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-14.0.6/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python Installing setuptools, pip, wheel...done. Collecting isort==4.0.0 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:318: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning. SNIMissingWarning /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning Downloading isort-4.0.0-py2.py3-none-any.whl Installing collected packages: isort Successfully installed isort-4.0.0 + ./pants test.pytest --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results src/main/python:: src/test/python:: -- -v % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 1679k 100 1679k0 0 17.9M 0 --:--:-- --:--:-- --:--:-- 18.0M New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.wZCv6o/install/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.wZCv6o/install/bin/python Installing setuptools, pip, wheel...done. ./pants: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.wZCv6o/install/bin/pip: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/boot: bad interpreter: No such file or directory ./pants: line 95: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-pre6/bin/pants: No such file or directory I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 8, 2016, 8:12 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > --- > > (Updated July 8, 2016, 8:12 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1710 > https://issues.apache.org/jira/browse/AURORA-1710 > > > Repository: aurora > > > Description > --- > > AURORA-1710 Make 'tier' required and remove s
Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141329 --- @ReviewBot retry - Mehrdad Nurolahzade On July 8, 2016, 1:12 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > --- > > (Updated July 8, 2016, 1:12 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1710 > https://issues.apache.org/jira/browse/AURORA-1710 > > > Repository: aurora > > > Description > --- > > AURORA-1710 Make 'tier' required and remove support for 'production' flag in > Job configuration - CLI changes > > > Diffs > - > > RELEASE-NOTES.md 29d224d5596eb060356f1343cf347db79b1ad687 > src/main/python/apache/aurora/client/api/__init__.py > 68baf8fdb90cd26100159401c46c9963c24332b3 > src/main/python/apache/aurora/client/cli/context.py > 9b1511801d031ff48b81c25688a55cb586b8ac66 > src/main/python/apache/aurora/client/config.py > 2fc12559016d406c347adb416a5166cca31c961e > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 2130f1fa71be02a004cdf8e476a270c81a7105d3 > src/test/python/apache/aurora/client/cli/test_context.py > 204ca092adad8bf43c5032a02f61bf303fb0b2fc > src/test/python/apache/aurora/client/cli/test_create.py > 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c > src/test/python/apache/aurora/client/cli/test_cron.py > f3c522ed94a2d774865811ceb546bf9df083c14f > src/test/python/apache/aurora/client/cli/test_plugins.py > a545fece5e2b3e0017a61e1be9ac478372b1f34d > src/test/python/apache/aurora/client/cli/test_restart.py > 967d560e5c7eb0ed85b215fb11d9751b8666acb5 > src/test/python/apache/aurora/client/cli/util.py > 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e > src/test/python/apache/aurora/client/test_config.py > b1a3c1865819899ef19173be0f861783a2631d0a > > Diff: https://reviews.apache.org/r/49048/diff/ > > > Testing > --- > > ``` > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > *** OK (All tests passed) *** > > mesos-master start/running, process 26868 > + RETCODE=0 > + restore_netrc > + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc > + true > Connection to 127.0.0.1 closed. > > real 19m46.324s > user 0m1.496s > sys 0m0.774s > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141327 --- Master (70d0ef2) is red with this patch. ./build-support/jenkins/build.sh virtualenv-14.0.6/virtualenv_embedded/activate.csh virtualenv-14.0.6/virtualenv_embedded/activate.fish virtualenv-14.0.6/virtualenv_embedded/activate.ps1 virtualenv-14.0.6/virtualenv_embedded/activate.sh virtualenv-14.0.6/virtualenv_embedded/activate_this.py virtualenv-14.0.6/virtualenv_embedded/deactivate.bat virtualenv-14.0.6/virtualenv_embedded/distutils-init.py virtualenv-14.0.6/virtualenv_embedded/distutils.cfg virtualenv-14.0.6/virtualenv_embedded/python-config virtualenv-14.0.6/virtualenv_embedded/site.py virtualenv-14.0.6/virtualenv_support/ virtualenv-14.0.6/virtualenv_support/__init__.py virtualenv-14.0.6/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/setuptools-20.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl + touch virtualenv-14.0.6/BOOTSTRAPPED + popd /home/jenkins/jenkins-slave/workspace/AuroraBot + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-14.0.6/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python Installing setuptools, pip, wheel...done. Collecting isort==4.0.0 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:318: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning. SNIMissingWarning /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning Downloading isort-4.0.0-py2.py3-none-any.whl Installing collected packages: isort Successfully installed isort-4.0.0 + ./pants test.pytest --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results src/main/python:: src/test/python:: -- -v % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 1679k 100 1679k0 0 16.6M 0 --:--:-- --:--:-- --:--:-- 16.7M New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.2sPB39/install/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.2sPB39/install/bin/python Installing setuptools, pip, wheel...done. ./pants: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.2sPB39/install/bin/pip: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/boot: bad interpreter: No such file or directory ./pants: line 95: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-pre6/bin/pants: No such file or directory I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 8, 2016, 8:12 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > --- > > (Updated July 8, 2016, 8:12 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1710 > https://issues.apache.org/jira/browse/AURORA-1710 > > > Repository: aurora > > > Description > --- > > AURORA-1710 Make 'tier' required and remove s
Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated July 8, 2016, 1:12 p.m.) Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Changes --- Rebased to master Bugs: AURORA-1710 https://issues.apache.org/jira/browse/AURORA-1710 Repository: aurora Description --- AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes Diffs (updated) - RELEASE-NOTES.md 29d224d5596eb060356f1343cf347db79b1ad687 src/main/python/apache/aurora/client/api/__init__.py 68baf8fdb90cd26100159401c46c9963c24332b3 src/main/python/apache/aurora/client/cli/context.py 9b1511801d031ff48b81c25688a55cb586b8ac66 src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e src/test/python/apache/aurora/client/cli/test_command_hooks.py 2130f1fa71be02a004cdf8e476a270c81a7105d3 src/test/python/apache/aurora/client/cli/test_context.py 204ca092adad8bf43c5032a02f61bf303fb0b2fc src/test/python/apache/aurora/client/cli/test_create.py 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c src/test/python/apache/aurora/client/cli/test_cron.py f3c522ed94a2d774865811ceb546bf9df083c14f src/test/python/apache/aurora/client/cli/test_plugins.py a545fece5e2b3e0017a61e1be9ac478372b1f34d src/test/python/apache/aurora/client/cli/test_restart.py 967d560e5c7eb0ed85b215fb11d9751b8666acb5 src/test/python/apache/aurora/client/cli/util.py 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e src/test/python/apache/aurora/client/test_config.py b1a3c1865819899ef19173be0f861783a2631d0a Diff: https://reviews.apache.org/r/49048/diff/ Testing --- ``` ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh *** OK (All tests passed) *** mesos-master start/running, process 26868 + RETCODE=0 + restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real19m46.324s user0m1.496s sys 0m0.774s ``` Thanks, Mehrdad Nurolahzade
Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes
> On June 28, 2016, 8:39 p.m., Joshua Cohen wrote: > > > > Mehrdad Nurolahzade wrote: > Should this be merged with upstream now that 0.15 is released? > > Joshua Cohen wrote: > Yes, we can land this now. Would you mind rebasing? Then I can commit it. Alright, running tests locally now, going to push shortly. - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139923 --- On June 28, 2016, 4:57 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > --- > > (Updated June 28, 2016, 4:57 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1710 > https://issues.apache.org/jira/browse/AURORA-1710 > > > Repository: aurora > > > Description > --- > > AURORA-1710 Make 'tier' required and remove support for 'production' flag in > Job configuration - CLI changes > > > Diffs > - > > RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec > src/main/python/apache/aurora/client/api/__init__.py > 68baf8fdb90cd26100159401c46c9963c24332b3 > src/main/python/apache/aurora/client/cli/context.py > 9b1511801d031ff48b81c25688a55cb586b8ac66 > src/main/python/apache/aurora/client/config.py > 2fc12559016d406c347adb416a5166cca31c961e > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 2130f1fa71be02a004cdf8e476a270c81a7105d3 > src/test/python/apache/aurora/client/cli/test_context.py > 204ca092adad8bf43c5032a02f61bf303fb0b2fc > src/test/python/apache/aurora/client/cli/test_create.py > 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c > src/test/python/apache/aurora/client/cli/test_cron.py > f3c522ed94a2d774865811ceb546bf9df083c14f > src/test/python/apache/aurora/client/cli/test_plugins.py > a545fece5e2b3e0017a61e1be9ac478372b1f34d > src/test/python/apache/aurora/client/cli/test_restart.py > 967d560e5c7eb0ed85b215fb11d9751b8666acb5 > src/test/python/apache/aurora/client/cli/util.py > 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e > src/test/python/apache/aurora/client/test_config.py > b1a3c1865819899ef19173be0f861783a2631d0a > > Diff: https://reviews.apache.org/r/49048/diff/ > > > Testing > --- > > ``` > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > *** OK (All tests passed) *** > > mesos-master start/running, process 26868 > + RETCODE=0 > + restore_netrc > + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc > + true > Connection to 127.0.0.1 closed. > > real 19m46.324s > user 0m1.496s > sys 0m0.774s > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes
> On June 29, 2016, 3:39 a.m., Joshua Cohen wrote: > > > > Mehrdad Nurolahzade wrote: > Should this be merged with upstream now that 0.15 is released? Yes, we can land this now. Would you mind rebasing? Then I can commit it. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139923 --- On June 28, 2016, 11:57 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > --- > > (Updated June 28, 2016, 11:57 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1710 > https://issues.apache.org/jira/browse/AURORA-1710 > > > Repository: aurora > > > Description > --- > > AURORA-1710 Make 'tier' required and remove support for 'production' flag in > Job configuration - CLI changes > > > Diffs > - > > RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec > src/main/python/apache/aurora/client/api/__init__.py > 68baf8fdb90cd26100159401c46c9963c24332b3 > src/main/python/apache/aurora/client/cli/context.py > 9b1511801d031ff48b81c25688a55cb586b8ac66 > src/main/python/apache/aurora/client/config.py > 2fc12559016d406c347adb416a5166cca31c961e > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 2130f1fa71be02a004cdf8e476a270c81a7105d3 > src/test/python/apache/aurora/client/cli/test_context.py > 204ca092adad8bf43c5032a02f61bf303fb0b2fc > src/test/python/apache/aurora/client/cli/test_create.py > 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c > src/test/python/apache/aurora/client/cli/test_cron.py > f3c522ed94a2d774865811ceb546bf9df083c14f > src/test/python/apache/aurora/client/cli/test_plugins.py > a545fece5e2b3e0017a61e1be9ac478372b1f34d > src/test/python/apache/aurora/client/cli/test_restart.py > 967d560e5c7eb0ed85b215fb11d9751b8666acb5 > src/test/python/apache/aurora/client/cli/util.py > 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e > src/test/python/apache/aurora/client/test_config.py > b1a3c1865819899ef19173be0f861783a2631d0a > > Diff: https://reviews.apache.org/r/49048/diff/ > > > Testing > --- > > ``` > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > *** OK (All tests passed) *** > > mesos-master start/running, process 26868 > + RETCODE=0 > + restore_netrc > + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc > + true > Connection to 127.0.0.1 closed. > > real 19m46.324s > user 0m1.496s > sys 0m0.774s > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes
> On June 28, 2016, 8:39 p.m., Joshua Cohen wrote: > > Should this be merged with upstream now that 0.15 is released? - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139923 --- On June 28, 2016, 4:57 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > --- > > (Updated June 28, 2016, 4:57 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1710 > https://issues.apache.org/jira/browse/AURORA-1710 > > > Repository: aurora > > > Description > --- > > AURORA-1710 Make 'tier' required and remove support for 'production' flag in > Job configuration - CLI changes > > > Diffs > - > > RELEASE-NOTES.md af2061c7605c12a066778bd99ec1a3857bee6dec > src/main/python/apache/aurora/client/api/__init__.py > 68baf8fdb90cd26100159401c46c9963c24332b3 > src/main/python/apache/aurora/client/cli/context.py > 9b1511801d031ff48b81c25688a55cb586b8ac66 > src/main/python/apache/aurora/client/config.py > 2fc12559016d406c347adb416a5166cca31c961e > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 2130f1fa71be02a004cdf8e476a270c81a7105d3 > src/test/python/apache/aurora/client/cli/test_context.py > 204ca092adad8bf43c5032a02f61bf303fb0b2fc > src/test/python/apache/aurora/client/cli/test_create.py > 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c > src/test/python/apache/aurora/client/cli/test_cron.py > f3c522ed94a2d774865811ceb546bf9df083c14f > src/test/python/apache/aurora/client/cli/test_plugins.py > a545fece5e2b3e0017a61e1be9ac478372b1f34d > src/test/python/apache/aurora/client/cli/test_restart.py > 967d560e5c7eb0ed85b215fb11d9751b8666acb5 > src/test/python/apache/aurora/client/cli/util.py > 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e > src/test/python/apache/aurora/client/test_config.py > b1a3c1865819899ef19173be0f861783a2631d0a > > Diff: https://reviews.apache.org/r/49048/diff/ > > > Testing > --- > > ``` > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > *** OK (All tests passed) *** > > mesos-master start/running, process 26868 > + RETCODE=0 > + restore_netrc > + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc > + true > Connection to 127.0.0.1 closed. > > real 19m46.324s > user 0m1.496s > sys 0m0.774s > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
