Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-09-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51384/#review147967 --- Ship it! Master (19866b5) is green with this patch.

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-09-06 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51384/ --- (Updated Sept. 6, 2016, 8:29 p.m.) Review request for Aurora, David

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review147957 --- Ship it! Master (19866b5) is green with this patch.

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review147953 --- @ReviewBot retry - Karthik Anantha Padmanabhan On Sept. 6,

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review147950 --- Master (19866b5) is red with this patch.

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- (Updated Sept. 6, 2016, 11:34 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- (Updated Sept. 6, 2016, 11:18 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51667: Remove HttpServletRequestParams

2016-09-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51667/#review147937 --- Ship it! Master (0c90c86) is green with this patch.

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Kai Huang
> On Sept. 6, 2016, 8:56 p.m., Stephan Erb wrote: > > The current default of `watch_secs` is 45 seconds. Should we drop that to 0 > > and also adapt the docs accordingly? That would optimize the default > > settings for the health check driven updates, which I think would be a good > > thing.

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147922 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 6, 2016,

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Maxim Khutornenko
> On Sept. 6, 2016, 8:56 p.m., Stephan Erb wrote: > > The current default of `watch_secs` is 45 seconds. Should we drop that to 0 > > and also adapt the docs accordingly? That would optimize the default > > settings for the health check driven updates, which I think would be a good > > thing.

Re: Review Request 51667: Remove HttpServletRequestParams

2016-09-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51667/#review147919 --- Ship it! Ship It! - Stephan Erb On Sept. 6, 2016, 10:37

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147917 --- The current default of `watch_secs` is 45 seconds. Should we drop

Re: Review Request 51664: Document the Mesos containerizer

2016-09-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51664/#review147914 --- Ship it! Master (0c90c86) is green with this patch.

Review Request 51667: Remove HttpServletRequestParams

2016-09-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51667/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description

Re: Review Request 51664: Document the Mesos containerizer

2016-09-06 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51664/#review147908 --- docs/features/containers.md (lines 55 - 56)

Re: Review Request 51664: Document the Mesos containerizer

2016-09-06 Thread Zhitao Li
> On Sept. 6, 2016, 8 p.m., Zhitao Li wrote: > > docs/features/containers.md, lines 55-56 > > > > > > Add a sentence to indicate that: > > > > `Otherwise, this user and its primary group has to exist in the

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147900 --- This change is now on master at

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147899 --- Ship it! Ship It! - Zameer Manji On Sept. 5, 2016, 11:56

Re: Review Request 51664: Document the Mesos containerizer

2016-09-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51664/#review147898 --- docs/operations/configuration.md (line 34)

Review Request 51664: Document the Mesos containerizer

2016-09-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51664/ --- Review request for Aurora and Joshua Cohen. Bugs: AURORA-1640

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review147894 --- Master (5d3f945) is red with this patch.

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147893 --- Ship it! Master (5d3f945) is green with this patch.

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 6, 2016, 6:46 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- (Updated Sept. 6, 2016, 6:42 p.m.) Review request for Aurora and Maxim

Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-09-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51469/#review147856 --- Ship it! I'm fine with trimming dead code from our commons

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147855 --- Ship it! Ship It! - Joshua Cohen On Sept. 5, 2016, 6:56

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147853 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 5, 2016,